Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp2282382ybl; Thu, 19 Dec 2019 10:58:45 -0800 (PST) X-Google-Smtp-Source: APXvYqy7YqHCld94ImqcEz2RSeVEhHWhp9g+EEo/AN6CbEzyNp2FFNPZqZldScb9w1f/i/n7yRl7 X-Received: by 2002:a05:6830:18f1:: with SMTP id d17mr5219286otf.298.1576781925567; Thu, 19 Dec 2019 10:58:45 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1576781925; cv=none; d=google.com; s=arc-20160816; b=sLVIre5aGaEcdWJXon4D71vnWXopS6YMP6OuTwytXD6dDizqOJuGU2Qo0bgFCXzC4r 3Go2TsnW2HCgjN7lEEhhbYcGokucj3hH+UMWDcb7xWQlKdd1lvcEKIsjzfS3qwGSaWTU j/RPQlOBI66GlbaXANY+bYu4FGm5Ca2X7NNeJew0/LfGkJOXKaeizGV5a1nRbT3Y0ZFR EEP8JXG2nhTrxyba9rBCoOG8AsUgTYxqTSHM4jpYOdvAR8U/q0jIzoyUVk8QysKCEMIY AalfXeIjQDjJd4Oeg8Upkh9pSvninqe/yeDn6GcUasveF2cpe0lTz4Z8oxjcD2n4lD0w 6nHg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=9vsq6eUhXFhyKZHNnQUAqX7ncKTQp+sx/uBM53TW/LE=; b=ig7Yhkg5NXjEw1fxCZx5Epx4ElXcH8ZHvQHTDtR/pxSXc8iR9l/WrJYo9s2S2haMof yyUffv4SRSH4SneVyphVzeflDc7MHIHsIla2+hu4ZSn8EYwjoenuFrIC2dBvVTgDKOS2 b6P/UJ94xC1C6Z0ODnuxfuh2DzviC74ApJEiFumNi0lBUBVQ/uIt5N5K9WL5nKKk9ekw UFTRwq1X/aUeREDTiWJCiUSyePS0KMSRihRAz2EyI0XDYuhKgl1AifgWQGwYFD1dyUzI lzR7iFgj+mDFm+QkQG43KLzwhoL9rw4RbPPlhXjFKjcsAp0lxKmMBL3RnLKywIIrGpLX 5oTA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=aQQWg4To; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h6si3689396oie.215.2019.12.19.10.58.32; Thu, 19 Dec 2019 10:58:45 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=aQQWg4To; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730763AbfLSS4F (ORCPT + 99 others); Thu, 19 Dec 2019 13:56:05 -0500 Received: from mail.kernel.org ([198.145.29.99]:52410 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730757AbfLSS4C (ORCPT ); Thu, 19 Dec 2019 13:56:02 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 85C872465E; Thu, 19 Dec 2019 18:56:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576781762; bh=TV7reKbOwC/Y7RHTX7qKGlBuIi38AILlTu9b0ggzADY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=aQQWg4Toge7/Pw0ATEpIGtDjGW+sVt1WVfuqdACCZ+3U01Bw+1Ek0heU6zCxlMHYV h6ZVzfdxXPlsvX91xoXf8eljz6tx6YyO6Zk2N3VSp9VL74SNzPFSShEtQhIP0DkGhl PLVP+I9a1SkxHTMCLdx5tKh03xpa51HYk8LfRT/k= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Daniel Drake , Paulo Zanoni , Jian-Hong Pan , Maarten Lankhorst , =?UTF-8?q?Ville=20Syrj=C3=A4l=C3=A4?= , Joonas Lahtinen Subject: [PATCH 5.4 69/80] drm/i915/fbc: Disable fbc by default on all glk+ Date: Thu, 19 Dec 2019 19:35:01 +0100 Message-Id: <20191219183140.351406355@linuxfoundation.org> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20191219183031.278083125@linuxfoundation.org> References: <20191219183031.278083125@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Ville Syrjälä commit 0eb8e74f7202a4a98bbc0c1adeed3986cf50b66a upstream. We're missing a workaround in the fbc code for all glk+ platforms which can cause corruption around the top of the screen. So enabling fbc by default is a bad idea. I'm not keen to backport the w/a so let's start by disabling fbc by default on all glk+. We'll lift the restriction once the w/a is in place. Cc: stable@vger.kernel.org Cc: Daniel Drake Cc: Paulo Zanoni Cc: Jian-Hong Pan Cc: Maarten Lankhorst Signed-off-by: Ville Syrjälä Link: https://patchwork.freedesktop.org/patch/msgid/20191127201222.16669-2-ville.syrjala@linux.intel.com Reviewed-by: Maarten Lankhorst (cherry picked from commit cd8c021b36a66833cefe2c90a79a9e312a2a5690) Signed-off-by: Joonas Lahtinen Signed-off-by: Greg Kroah-Hartman --- drivers/gpu/drm/i915/display/intel_fbc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/gpu/drm/i915/display/intel_fbc.c +++ b/drivers/gpu/drm/i915/display/intel_fbc.c @@ -1284,7 +1284,7 @@ static int intel_sanitize_fbc_option(str return 0; /* https://bugs.freedesktop.org/show_bug.cgi?id=108085 */ - if (IS_GEMINILAKE(dev_priv)) + if (INTEL_GEN(dev_priv) >= 10 || IS_GEMINILAKE(dev_priv)) return 0; if (IS_BROADWELL(dev_priv) || INTEL_GEN(dev_priv) >= 9)