Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp2496461ybl; Thu, 19 Dec 2019 14:52:51 -0800 (PST) X-Google-Smtp-Source: APXvYqzKXGKNrTr53Xo0yYtGzYFm0hW79g2ZhY+QaZZaXh8uN5itPjs8feOWp65NWJKvpL33sk5B X-Received: by 2002:a05:6830:1e5c:: with SMTP id e28mr11629109otj.293.1576795971824; Thu, 19 Dec 2019 14:52:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1576795971; cv=none; d=google.com; s=arc-20160816; b=iWdO+hCMzUfGl32LdiDJs5+EoVmsIz2BqjsdC3U2JKO5K+M8E3E3HBBtq46xl/tMVn 5lTIq4G7QoU9lhrbIhnDcqDV86Tcc4bCAo4ETN4u76E/1g2HJn8IygxKdp9eY6YRrud0 BpOYeNW0YRT7CrwsRvQXlKLmqhHcxaaDp+rhhDLQRYTeyn0K5Y9m/RPjQSbHDYX9c3xS AY7Ugbowm9ejziSlLxko/YfdzuSnoz7bxESAke6He+4MzyxZGwJSeJEZO6DPWKL2y5XE 2MQavkKXvGtdjOx9EPHwPSbdLtVNfwciBkgDvblPG9kls7IzhZDzRN2pnr2Cv/PdsJnn xSZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=oqp0ZOgIzBFCfbou9MpDkexGf0+ceDQ9/zrmzo/7alk=; b=ZYc7yjyiBuQh8qUUFyqNrzeRVcH8F96zwin2g1VuGgJMXtI34B3KbHmyoNLybxd8Zd SaHaXKXl1jWKALxuCr7xbPGuEzwTN7dU+64/t48DPdH4MDJxUODozyqFRkl3E8C6IJ9x YnlYIR0TJBY+F3igPq380AggmM0/79lzSIIqYYB+5fjVy/bkNvQqGbb8zEm87Wa5CvqI 4YegplWaDiJ/hZYQ4nyJ1ap9FTut4L7+ut0KpEoGkv7IB6EyuYxmmuwu95eca40XVo/W DOlc/S5yPF+DWoVMQ/OAZmviO50hzV+NlJqgmU4ocyxYT07JyPezD0vY00AsPrIfYpiw WDRA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 11si1361669otu.301.2019.12.19.14.52.39; Thu, 19 Dec 2019 14:52:51 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727140AbfLSWvT (ORCPT + 99 others); Thu, 19 Dec 2019 17:51:19 -0500 Received: from mga17.intel.com ([192.55.52.151]:27773 "EHLO mga17.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726982AbfLSWvT (ORCPT ); Thu, 19 Dec 2019 17:51:19 -0500 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Dec 2019 14:51:06 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,333,1571727600"; d="scan'208";a="366220427" Received: from romley-ivt3.sc.intel.com ([172.25.110.60]) by orsmga004.jf.intel.com with ESMTP; 19 Dec 2019 14:51:06 -0800 Date: Thu, 19 Dec 2019 15:02:32 -0800 From: Fenghua Yu To: Shakeel Butt Cc: Reinette Chatre , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] x86/resctrl: Fix potential memory leak Message-ID: <20191219230232.GA241295@romley-ivt3.sc.intel.com> References: <20191219223834.233692-1-shakeelb@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191219223834.233692-1-shakeelb@google.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 19, 2019 at 02:38:34PM -0800, Shakeel Butt wrote: > The set_cache_qos_cfg() is leaking memory when the given level is not > RDT_RESOURCE_L3 or RDT_RESOURCE_L2. Fix that. > > Fixes: 99adde9b370de ("x86/intel_rdt: Enable L2 CDP in MSR IA32_L2_QOS_CFG") > Signed-off-by: Shakeel Butt Acked-by: Fenghua Yu Thanks. -Fenghua