Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20191219201340.196259-1-pmalani@chromium.org> <20191219201340.196259-2-pmalani@chromium.org>
In-Reply-To: <20191219201340.196259-2-pmalani@chromium.org>
From:   Benson Leung <bleung@chromium.org>
Date:   Thu, 19 Dec 2019 16:13:59 -0800
Message-ID: <CANLzEktdkZvdpJusvC67xjyxw5+botWH+TLBmfT8hg6u6P+yPA@mail.gmail.com>
Subject: Re: [PATCH 2/2] mfd: cros_ec: Add usbpd-notify to usbpd_charger
To:     Prashant Malani <pmalani@chromium.org>
Cc:     Enric Balletbo i Serra <enric.balletbo@collabora.com>,
        Guenter Roeck <groeck@chromium.org>,
        Lee Jones <lee.jones@linaro.org>,
        Linux Kernel <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hey Prashant,

On Thu, Dec 19, 2019 at 12:14 PM Prashant Malani <pmalani@chromium.org> wrote:
>
> Add the cros-usbpd-notify driver as a cell for the cros_usbpd_charger
> subdevice on non-ACPI platforms.
>
> This driver allows other cros-ec devices to receive PD event
> notifications from the Chrome OS Embedded Controller (EC) via a
> notification chain.
>
> Change-Id: I4c062d261fa1a504b43b0a0c0a98a661829593b9

Make sure to strip Gerrit's Change-Ids before sending upstream. They
don't have any meaning outside of chromiumos.

> Signed-off-by: Prashant Malani <pmalani@chromium.org>
> ---
>  drivers/mfd/cros_ec_dev.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/drivers/mfd/cros_ec_dev.c b/drivers/mfd/cros_ec_dev.c
> index c4b977a5dd966..1dde480f35b93 100644
> --- a/drivers/mfd/cros_ec_dev.c
> +++ b/drivers/mfd/cros_ec_dev.c
> @@ -85,6 +85,9 @@ static const struct mfd_cell cros_ec_sensorhub_cells[] = {
>  static const struct mfd_cell cros_usbpd_charger_cells[] = {
>         { .name = "cros-usbpd-charger", },
>         { .name = "cros-usbpd-logger", },
> +#ifndef CONFIG_ACPI
> +       { .name = "cros-usbpd-notify", },
> +#endif
>  };
>
>  static const struct cros_feature_to_cells cros_subdevices[] = {
> --
> 2.24.1.735.g03f4e72817-goog
>


-- 
Benson Leung
Staff Software Engineer
Chrome OS Kernel
Google Inc.
bleung@google.com
Chromium OS Project
bleung@chromium.org