Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 19 Dec 2019 20:56:31 -0500
From:   Steven Rostedt <rostedt@goodmis.org>
To:     Hewenliang <hewenliang4@huawei.com>
Cc:     <acme@redhat.com>, <tstoyanov@vmware.com>,
        <linux-kernel@vger.kernel.org>, <linfeilong@huawei.com>
Subject: Re: [PATCH] tools lib traceevent: Fix memory leakage in
 filter_event
Message-ID: <20191219205631.2e12571c@rorschach.local.home>
In-Reply-To: <20191209063549.59941-1-hewenliang4@huawei.com>
References: <20191209063549.59941-1-hewenliang4@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, 9 Dec 2019 01:35:49 -0500
Hewenliang <hewenliang4@huawei.com> wrote:

> It is necessary to call free_arg(arg) when add_filter_type returns NULL in
> the function of filter_event.
> 
> Signed-off-by: Hewenliang <hewenliang4@huawei.com>

This looks fine.

Reviewed-by: Steven Rostedt (VMware) <rostedt@goodmis.org>

Arnaldo, care to take this?

-- Steve

> ---
>  tools/lib/traceevent/parse-filter.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/lib/traceevent/parse-filter.c b/tools/lib/traceevent/parse-filter.c
> index f3cbf86e51ac..20eed719542e 100644
> --- a/tools/lib/traceevent/parse-filter.c
> +++ b/tools/lib/traceevent/parse-filter.c
> @@ -1228,8 +1228,10 @@ filter_event(struct tep_event_filter *filter, struct tep_event *event,
>  	}
>  
>  	filter_type = add_filter_type(filter, event->id);
> -	if (filter_type == NULL)
> +	if (filter_type == NULL) {
> +		free_arg(arg);
>  		return TEP_ERRNO__MEM_ALLOC_FAILED;
> +	}
>  
>  	if (filter_type->filter)
>  		free_arg(filter_type->filter);