Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp2746464ybl; Thu, 19 Dec 2019 20:23:37 -0800 (PST) X-Google-Smtp-Source: APXvYqxlOSm4KXdYGnlxkOjwjfjecN9mRdlBFdOfote6i0sywdsEWdoVCEtzc1/sfK8vXYCQ8qjv X-Received: by 2002:a05:6830:2001:: with SMTP id e1mr12120431otp.97.1576815817637; Thu, 19 Dec 2019 20:23:37 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1576815817; cv=none; d=google.com; s=arc-20160816; b=QukCPtLKp1qQdtFvxvECZuzHKS2bHgo+scAjGQwWNcIGZjivr+2tSJ5YBZT2M19pHI vRYCfxQdbqWWjSe1ENkfY52T2rQ4IV1i9MAW5zY7xSYcxCj/fU2NH1VJh3y4XbEqV55o WjVjwVmcLVZkQ2qKEOik2bfhjh8Ij265f8lDQ+NnnHfbzJa23A6Lyqnq8dP4IlNUFReU Rh9cboFKH4ZeAXJHzhF+SJ2ROi6cPU1OfCK/j8eNXc79GTL/v3zsfzXHLGjypbNLhGM4 G9QV6hqy6d0/RAq9BLZU0ZTcf5YFNmsSmemWVmayTafxe07PhnXWBYaxCWsA9UAVliAh uE9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=nUqZyzxgB+kFXpSchEYJ5MscqQPpG3NL8XQ0XqNS9Y8=; b=LCLIxEQjig9P+Sth2RuJIZX0h26r6W857MJQkpjzdA9htl2q6Xc5NVebQqN7lILvPw 3qXOK4259CZ7l+gGOuJNbgS8h4DlaAEOMHyEW5tLfQF+j6ryVV3J72MfvjccWrwGDy8p WY7wB+i1MmC7DlM9r05hx0MmBUD5EtHi9CPkqzVaSrYoT5hZDwNrsViNzp3zLns+l5ei wiSYcquck3UpEU0F5gxKhPWLnFMZjF6TESSyyiw9gXLjwQMpTJIXPSYCs5fCj5c13bKj wQgV4SJ9RNp/Ymqwsr1lFtPrSzg19xkPhM/kURc0D0aEUQ5udrO2f4JBVZ+tnyPzpcLc 4MpQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=QmM0djdz; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 77si4330498oie.10.2019.12.19.20.23.22; Thu, 19 Dec 2019 20:23:37 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=QmM0djdz; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727165AbfLTEV3 (ORCPT + 99 others); Thu, 19 Dec 2019 23:21:29 -0500 Received: from mail.kernel.org ([198.145.29.99]:45010 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726986AbfLTEV3 (ORCPT ); Thu, 19 Dec 2019 23:21:29 -0500 Received: from localhost (unknown [106.201.107.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 788B921D7D; Fri, 20 Dec 2019 04:21:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576815688; bh=TEM0b/JaWXh5vC0Me0WpSth4fQG3Gksa+E3z056weGw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=QmM0djdzoD5smoRw/7poKBsNkM4Wwhz9RSg2N67KXQsvEwKSUVNIsbuFSRxzS0UvA mCCDjztcD1+/uNHygFSGG1qvsqBhp1IiPunDdklJ/6BRC07aofviK6fi4dhQOPJUBs CnEF8p+fcgZtNjCIvvYhbqwy6O33MmCa8n7ABEGA= Date: Fri, 20 Dec 2019 09:51:23 +0530 From: Vinod Koul To: Bjorn Andersson Cc: Kishon Vijay Abraham I , linux-arm-msm@vger.kernel.org, Andy Gross , Can Guo , Jeffrey Hugo , linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/4] phy: qcom-qmp: Increase the phy init timeout Message-ID: <20191220042123.GC2536@vkoul-mobl> References: <20191219150433.2785427-1-vkoul@kernel.org> <20191219150433.2785427-2-vkoul@kernel.org> <20191220020835.GK448416@yoga> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191220020835.GK448416@yoga> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 19-12-19, 18:08, Bjorn Andersson wrote: > On Thu 19 Dec 07:04 PST 2019, Vinod Koul wrote: > > > If we do full reset of the phy, it seems to take a couple of ms to come > > up on my system so increase the timeout to 10ms. > > > > This was found by full reset addition by commit 870b1279c7a0 > > ("scsi: ufs-qcom: Add reset control support for host controller") and > > fixes the regression to platforms by this commit. > > > > Suggested-by: Can Guo > > Signed-off-by: Vinod Koul > > This does look familiar... > > https://lore.kernel.org/linux-arm-msm/20191107000917.1092409-3-bjorn.andersson@linaro.org/ > > > --- > > drivers/phy/qualcomm/phy-qcom-qmp.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/phy/qualcomm/phy-qcom-qmp.c b/drivers/phy/qualcomm/phy-qcom-qmp.c > > index 091e20303a14..c2e800a3825a 100644 > > --- a/drivers/phy/qualcomm/phy-qcom-qmp.c > > +++ b/drivers/phy/qualcomm/phy-qcom-qmp.c > > @@ -66,7 +66,7 @@ > > /* QPHY_V3_PCS_MISC_CLAMP_ENABLE register bits */ > > #define CLAMP_EN BIT(0) /* enables i/o clamp_n */ > > > > -#define PHY_INIT_COMPLETE_TIMEOUT 1000 > > +#define PHY_INIT_COMPLETE_TIMEOUT 100000 > > 100ms seems a little bit excessive, and we do end up waiting this long > when we have PCIe links without an attached device... > > Do you need >10ms or could we just have my patch merged? Yeah I quick tested 10ms as well and seems good for me, so either ways if fine, but lets get it applied quickly :-) -- ~Vinod