Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
Date:   Fri, 20 Dec 2019 13:45:49 +0800
From:   Huang Shijie <sjhuang@iluvatar.ai>
To:     Jason Baron <jbaron@akamai.com>
CC:     <linux-kernel@vger.kernel.org>, <1537577747@qq.com>,
        Joe Perches <joe@perches.com>
Subject: Re: [PATCH v5] lib/dynamic_debug: make better dynamic log output
Message-ID: <20191220054548.GA18312@hsj-OptiPlex-5060>
References: <20191209094437.14866-1-sjhuang@iluvatar.ai>
 <20191219074735.31640-1-sjhuang@iluvatar.ai>
 <ec04aa8b-5c2a-28be-a32b-6d85a17d2f21@akamai.com>
MIME-Version: 1.0
In-Reply-To: <ec04aa8b-5c2a-28be-a32b-6d85a17d2f21@akamai.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Dec 19, 2019 at 05:10:49PM -0500, Jason Baron wrote:
> 
> 
> On 12/19/19 2:47 AM, Huang Shijie wrote:
> > The driver strings, device name and net device name are not changed for
> > the driver's dynamic log output. But the dynamic_emit_prefix() which contains
> > the function names may change when the function names are changed.
> > 
> > So the patch makes the better dynamic log output.
> 
> Another point here is that currently the output precisely matches the
> non-dynamic debug counterpart strings if not prefix is emitted. So that
> changes with this patch. I think its nice to say that the output is the
> same as the non dynamic debug output except it may have an optional
> prefix....
okay. I will add it in the next version.

Thanks
Huang Shijie