Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp2891726ybl; Thu, 19 Dec 2019 23:54:45 -0800 (PST) X-Google-Smtp-Source: APXvYqyl9VMoaERJ6G+l97zrrbk+I9LG92Ydu3FPoDwlMPDUYBqfb9iMDInLn21YC2FZvXKavYK0 X-Received: by 2002:a9d:754a:: with SMTP id b10mr13650627otl.273.1576828485094; Thu, 19 Dec 2019 23:54:45 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1576828485; cv=none; d=google.com; s=arc-20160816; b=jmi49YpKATu6HZKry6r5BpijkM2iDAt4aQWm1BnCpiY9UJfjgnfTQIjNyZ6379Wt9B lf10z+itSY3ysnd6EOORCZxuI9lEXCEOscOi7x0Xe7Kw7QQnDnR1x1wT2X2RvMppnttV Eqb+xy+/Cy61Vd3jscF+gN8DsQ7/7JKHeIAsok6Jya4mwUahGwgX1qLis5tNIkJ0FPaP W6m2DurbYHmQx3/eFV/GCvJ4n4JpKY4ULdaZmUxYFxm89EW6mTON1jO2ljn7lKwyGP5J Q3T52gzvVl6lrLBtXgLBy1NUpItVV+eVBy99fUdQ/cS+YtgF/CWQKP/Nj361ur4t3MFN pu9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=RS6DQCUQifxXMGDhjlfd2P+rToUJFYs0PviHgluz0Uw=; b=gVpOjXmkoqxrdvmqchLbfPXvVOu4GdGPsCzqCV/2w/FWrSc1Dlz2gHuAn7qNj9rsKk OxXB1VSP9A76/6EO61wu864L+FR+qeb6LZKgGXj8bpIUWvlcvsD4C43wBClR8KFPNiGI 3YNDg/I4W1+dr1vUMCRETc3HX/ic1TjHS+cUsrZuzvBveSeL3HwnsLdBC0s7wHpXGjpF 4D6AYCVEli2VNhmsIVFkfyAwn2Sez0HFQNCIlx6kS663qFWGN2q6ix/PgftShhICJ5BM stmKWAbw71jxlm3V4FBUqYzwoWp2CjE5q1HEZ9WhKTbOOMOiLUfXPe3PVH9254EFY13j QXfw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="yUxz/CFT"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m25si4537263otn.208.2019.12.19.23.54.33; Thu, 19 Dec 2019 23:54:45 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="yUxz/CFT"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727180AbfLTHxo (ORCPT + 99 others); Fri, 20 Dec 2019 02:53:44 -0500 Received: from mail.kernel.org ([198.145.29.99]:43960 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726651AbfLTHxo (ORCPT ); Fri, 20 Dec 2019 02:53:44 -0500 Received: from localhost (unknown [106.201.107.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 990BB20716; Fri, 20 Dec 2019 07:53:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576828423; bh=q+mQGfwkNQv1HURBxfmX2bv2zPEE80IykS2mIjvqiiU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=yUxz/CFTQ4sjWgwFHvYN+tRZEc+brxL8rJeMAVFBaAv8ccMRAAAnmM28vNJ9QqAgW 2oeCsmxA5XEW5BIm9KQ9Zav1bzxkJkQPRoHIYJ7i5/WGHF2gC/BcqRCmyjoUO8EC7w fbnCGxRv/iI3sM7Dix22Pvc2tULBv4KhvGi5dgFg= Date: Fri, 20 Dec 2019 13:23:38 +0530 From: Vinod Koul To: Can Guo Cc: Asutosh Das , Kishon Vijay Abraham I , linux-arm-msm@vger.kernel.org, Bjorn Andersson , Andy Gross , Jeffrey Hugo , linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/4] phy: qcom-qmp: Add optional SW reset Message-ID: <20191220075338.GG2536@vkoul-mobl> References: <20191219150433.2785427-1-vkoul@kernel.org> <20191219150433.2785427-4-vkoul@kernel.org> <9ef99dcac59dbdc59c7e5eb1a8724ea2@codeaurora.org> <20191220042427.GE2536@vkoul-mobl> <20191220071015.GF2536@vkoul-mobl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 20-12-19, 15:41, Can Guo wrote: > On 2019-12-20 15:10, Vinod Koul wrote: > > On 20-12-19, 14:00, Can Guo wrote: > Hi Vinod > > We are just removing the no_pcs_sw_reset for 8150, right? Why is it > possibly impacting 845 or older paltforms? > > In future, we will no longer need no_pcs_sw_reset for any newer QCOM UFS > PHY designs, as it is only for 845 and older platforms. > > I am sure QPHY_SW_RESET will be within PHY's address space since 8150. > Otherwise, it will be a regression in UFS PHY design. We had a lot of > discussion about this on 845 years ago, then design team decided to add > it on later platforms, so I don't see a reason to remove it again. :) > > I am not sure about the other qmp phys, but so long as UFS PHY needs the > reset, we need to keep it, as phy-qcom-qmp.c is a common driver. I am > not sure if I get your point here. Please correct me I am wrong. The argument here is that we are making this UFS specific and we do not know if this will be true in future as QMP is a common phy, so adding a separate flag helps to keep it independent and to be used in other situations. Thanks -- ~Vinod