Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] platform/chrome: cros-ec: make init_lock static
To:     "Ben Dooks (Codethink)" <ben.dooks@codethink.co.uk>
Cc:     Benson Leung <bleung@chromium.org>,
        Guenter Roeck <groeck@chromium.org>,
        linux-kernel@vger.kernel.org
References: <20191218100720.2420401-1-ben.dooks@codethink.co.uk>
From:   Enric Balletbo i Serra <enric.balletbo@collabora.com>
Message-ID: <67800cf2-fb2c-11d4-87cb-18e6e426e437@collabora.com>
Date:   Fri, 20 Dec 2019 10:04:50 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.3.0
MIME-Version: 1.0
In-Reply-To: <20191218100720.2420401-1-ben.dooks@codethink.co.uk>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Ben,

Thanks for the patch.

On 18/12/19 11:07, Ben Dooks (Codethink) wrote:
> The init_lock is not declared or used outside of cros_ec_ishtp.c
> so make it static to avoid the following warning:
> 
> drivers/platform/chrome/cros_ec_ishtp.c:79:1: warning: symbol 'init_lock' was not declared. Should it be static?
> 
> Signed-off-by: Ben Dooks (Codethink) <ben.dooks@codethink.co.uk>

Applied for 5.6

> ---
> Cc: Benson Leung <bleung@chromium.org>
> Cc: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> Cc: Guenter Roeck <groeck@chromium.org>
> Cc: linux-kernel@vger.kernel.org
> ---
>  drivers/platform/chrome/cros_ec_ishtp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/platform/chrome/cros_ec_ishtp.c b/drivers/platform/chrome/cros_ec_ishtp.c
> index e5996821d08b..5f8e76f3022a 100644
> --- a/drivers/platform/chrome/cros_ec_ishtp.c
> +++ b/drivers/platform/chrome/cros_ec_ishtp.c
> @@ -76,7 +76,7 @@ struct cros_ish_in_msg {
>   *
>   * The writers are .reset() and .probe() function.
>   */
> -DECLARE_RWSEM(init_lock);
> +static DECLARE_RWSEM(init_lock);
>  
>  /**
>   * struct response_info - Encapsulate firmware response related
>