Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp2960117ybl; Fri, 20 Dec 2019 01:21:37 -0800 (PST) X-Google-Smtp-Source: APXvYqxjaXIaxjvMw9VJmDZe8JQt6D6E14ECRtw8ndd/a8RHpISwt3clK4jmNrNpUs1Wxw2FUgKI X-Received: by 2002:a9d:588c:: with SMTP id x12mr13490465otg.2.1576833697425; Fri, 20 Dec 2019 01:21:37 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1576833697; cv=none; d=google.com; s=arc-20160816; b=dO0oAuM/NopIGPkD+9xt98CANZjctZ2HvGZkmwnMySkLneGkN/MM/58BoTbc7wcYvQ OXdQGDHNmEuSI26Fg1C4u32NNccvaO3oy0nSDrYQbyIxwJhKNfvPYKmEemqqPmAEHv7E rKBrMEMsjD96Ibz+Dj9Snd+moiKYiwb2fOYyi1VowGEWKqgVMQoS3SdesTooMlUrspyd Cp1HNjNO/B2t48k9Ick0B7IBPQY76aOfnon24t7an2INn0jgzzEKPSVBuO+FjQlYx0PY lTyNhxVHRUv1f4mX8ZVWwPKrbO3bqVEmnnbT14OSY5X7jVv+RxShMblUO6gcEOBFMxO1 9AeA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=8um2Ysf4V5VDMoQBv13W6n30DzWTwq9rVr300dDD9wA=; b=cArGBIAkW8Wy7TbAXRw3frNOKrBYqO2NZG6Rf7jBYLyGv1GzZegmxfhHOqw6cZeG5y qkxhibmThHevOGENB1aIJFl29dB1/jIJkW9SyGgFmLP8ib+MKw3koxPKgXpHivpRY9Ke OIkF9UoNOvFrVIvfwyFamIpmwfi5XOaupaCc5PLbpwUZgQvWfChJcah5+Oj3K0dnYC62 0u5vcqAGuhnnMl5zk9kVwsJLIxlksnqXQRmx/qB4mteXT6g6jD4uppK5qlKXKL8KOTJ6 pESRFR0cHvGZZn2UOTUvmC2GL0Wul95bJh0pXwfRB9ByGx8rNvzXwLD4KzsEywTy1kqN aaUQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p21si2028356otr.58.2019.12.20.01.21.25; Fri, 20 Dec 2019 01:21:37 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727229AbfLTJTd (ORCPT + 99 others); Fri, 20 Dec 2019 04:19:33 -0500 Received: from cloudserver094114.home.pl ([79.96.170.134]:45643 "EHLO cloudserver094114.home.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727177AbfLTJTd (ORCPT ); Fri, 20 Dec 2019 04:19:33 -0500 Received: from 79.184.253.1.ipv4.supernova.orange.pl (79.184.253.1) (HELO kreacher.localnet) by serwer1319399.home.pl (79.96.170.134) with SMTP (IdeaSmtpServer 0.83.320) id b09be8de9d95ff35; Fri, 20 Dec 2019 10:19:31 +0100 From: "Rafael J. Wysocki" To: zhuguangqing83@gmail.com Cc: pavel@ucw.cz, len.brown@intel.com, gregkh@linuxfoundation.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, zhuguangqing Subject: Re: [PATCH v2]PM/wakeup: Add print_wakeup_source_stats(m, &deleted_ws) Date: Fri, 20 Dec 2019 10:19:31 +0100 Message-ID: <2830760.UpLSkk7Ke6@kreacher> In-Reply-To: <20191209093523.15752-1-zhuguangqing83@gmail.com> References: <20191209093523.15752-1-zhuguangqing83@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday, December 9, 2019 10:35:23 AM CET zhuguangqing83@gmail.com wrote: > From: zhuguangqing > > After commit 00ee22c28915 (PM / wakeup: Use seq_open() > to show wakeup stats), print_wakeup_source_stats(m, &deleted_ws) > is deleted in function wakeup_sources_stats_seq_show(). > > Because deleted_ws is one of wakeup sources, so it should > also be showed. This patch add it to the end of all other > wakeup sources. > > Signed-off-by: zhuguangqing > --- > v2: modify judegment condition according to the advice of Rafael J. > > drivers/base/power/wakeup.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/base/power/wakeup.c b/drivers/base/power/wakeup.c > index 5817b51d2b15..53c0519da1e4 100644 > --- a/drivers/base/power/wakeup.c > +++ b/drivers/base/power/wakeup.c > @@ -1071,6 +1071,9 @@ static void *wakeup_sources_stats_seq_next(struct seq_file *m, > break; > } > > + if (!next_ws) > + print_wakeup_source_stats(m, &deleted_ws); > + > return next_ws; > } > > Applied as 5.6 material with some subject and changelog modifications, thanks!