Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 20 Dec 2019 15:27:55 +0530
From:   Vinod Koul <vkoul@kernel.org>
To:     Peter Ujfalusi <peter.ujfalusi@ti.com>
Cc:     robh+dt@kernel.org, nm@ti.com, ssantosh@kernel.org,
        dan.j.williams@intel.com, dmaengine@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, grygorii.strashko@ti.com,
        lokeshvutla@ti.com, t-kristo@ti.com, tony@atomide.com,
        j-keerthy@ti.com, vigneshr@ti.com
Subject: Re: [PATCH v7 05/12] dmaengine: Add support for reporting DMA cached
 data amount
Message-ID: <20191220095755.GN2536@vkoul-mobl>
References: <20191209094332.4047-1-peter.ujfalusi@ti.com>
 <20191209094332.4047-6-peter.ujfalusi@ti.com>
 <20191220083713.GL2536@vkoul-mobl>
 <f28301f7-4624-b4f8-d781-7ebfa4ae7856@ti.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <f28301f7-4624-b4f8-d781-7ebfa4ae7856@ti.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 20-12-19, 10:49, Peter Ujfalusi wrote:

> >> +static inline void dma_set_in_flight_bytes(struct dma_tx_state *state,
> >> +					   u32 in_flight_bytes)
> >> +{
> >> +	if (state)
> >> +		state->in_flight_bytes = in_flight_bytes;
> >> +}
> > 
> > This would be used by dmaengine drivers right, so lets move it to drivers/dma/dmaengine.h
> > 
> > lets not expose this to users :)
> 
> I have put it where the dma_set_residue() was.
> I can add a patch first to move dma_set_residue() then add

not sure I follow, but dma_set_residue() in already in drivers/dma/dmaengine.h

> dma_set_in_flight_bytes() there as well?

-- 
~Vinod