Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 20 Dec 2019 03:08:39 -0800 (PST)
From:   Paul Walmsley <paul.walmsley@sifive.com>
To:     David Abdurachmanov <david.abdurachmanov@gmail.com>
cc:     Palmer Dabbelt <palmer@dabbelt.com>,
        Albert Ou <aou@eecs.berkeley.edu>,
        Anup Patel <anup@brainfault.org>,
        Mike Rapoport <rppt@linux.ibm.com>,
        Greentime Hu <greentime.hu@sifive.com>,
        David Abdurachmanov <david.abdurachmanov@sifive.com>,
        Stefan O'Rear <sorear2@gmail.com>,
        Yash Shah <yash.shah@sifive.com>,
        Logan Gunthorpe <logang@deltatee.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] define vmemmap before pfn_to_page calls
In-Reply-To: <20191218082814.895851-1-david.abdurachmanov@sifive.com>
Message-ID: <alpine.DEB.2.21.9999.1912200307400.3767@viisi.sifive.com>
References: <20191218082814.895851-1-david.abdurachmanov@sifive.com>
User-Agent: Alpine 2.21.9999 (DEB 301 2018-08-15)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, 18 Dec 2019, David Abdurachmanov wrote:

> pfn_to_page & page_to_pfn depend on vmemmap being available before the calls
> if kernel is configured with CONFIG_SPARSEMEM_VMEMMAP=y. This was caused
> by NOMMU changes which moved vmemmap definition bellow functions definitions
> calling pfn_to_page & page_to_pfn.
> 
> Noticed while compiled 5.5-rc2 kernel for Fedora/RISCV.
> 
> v2:
> - Add a comment for vmemmap in source
> 
> Signed-off-by: David Abdurachmanov <david.abdurachmanov@sifive.com>
> Fixes: 6bd33e1ece52 ("riscv: add nommu support")
> Reviewed-by: Anup Patel <anup@brainfault.org>

This looks like it was due to my error when resolving the merge conflicts, 
not Christoph's.  Queued for v5.5-rc, thanks David.


- Paul