Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp3232052ybl; Fri, 20 Dec 2019 06:05:37 -0800 (PST) X-Google-Smtp-Source: APXvYqwIemoyv6LQsKbaVStb2KuUCU1wKzyiwQ8DZUEpvXVHiQhKFhJas8EFeTTatWIkzp5ACK3D X-Received: by 2002:a9d:32e:: with SMTP id 43mr15002666otv.301.1576850736914; Fri, 20 Dec 2019 06:05:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1576850736; cv=none; d=google.com; s=arc-20160816; b=EWdj/zNvUJCGhRZnwo+ZYv6tGbXwyOM5FdOzysRjm4Hgep+ZCCx0k7MzElB5kPMHL5 Lx1XolTdYqZOmnHkb+CzFKwDbvfWeaHuugMLCfr2NtwkH0jmP4kRJMNLDNjBOOdjruOM JcOzSYfSlaSSWO44Coxu3tD/Fsn3FVhb+Rk8QwjDCOV3Kjz/UXwbIm7I2HhXkb6FOlxH g4ma+4SmRo/e1jC744s+9N5pVS/YXLGH+iCB2W9jKYCNNeJVOolGM16QdhYVAjG6b4m6 /ss2wvosnA4wNGMTjWYju3DfIjSIG0ViOOTaHfKyIi7NqlvUoUaPpkp46lcmv5w/D5np 1fmQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=An2AORbLQxpJXQ94o/szUZFNmyIecyVqOFVfAkZIKLw=; b=y2Vu/uuz1eRhymy+eRwMxjZu/StrcMqlsRtpnYa0Gr4lUsIgMslsWS1agNL4YFIqOu MtCP/GFY8N5PSux78EhRbALR0JLX/sBdpy+u4ZzUYuF490SubwoRkVPjobyKzuI2IC7+ poDP13SWtQnNP/p+W+uAsHubl155oEn0Yaa93A3z82GQDTtuK5KuAF3EIwA4QVoiLbKp wS6DJvNqGHZtMdePO71P6Ude6jn5tBMSeusQd83IJrMqe1emy8hb+/yTlca3bKE7Q+2J OzKYB84fYnuPcuDaFAaFecyeuvxrysQFVsWu6AfFHX2xJU7xvAtARZL5vKBpsqyqFz09 3YTQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v18si5523926otn.202.2019.12.20.06.05.08; Fri, 20 Dec 2019 06:05:36 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727437AbfLTOES (ORCPT + 99 others); Fri, 20 Dec 2019 09:04:18 -0500 Received: from mout-p-202.mailbox.org ([80.241.56.172]:9856 "EHLO mout-p-202.mailbox.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727344AbfLTOES (ORCPT ); Fri, 20 Dec 2019 09:04:18 -0500 Received: from smtp1.mailbox.org (smtp1.mailbox.org [IPv6:2001:67c:2050:105:465:1:1:0]) (using TLSv1.2 with cipher ECDHE-RSA-CHACHA20-POLY1305 (256/256 bits)) (No client certificate requested) by mout-p-202.mailbox.org (Postfix) with ESMTPS id 47fVq35p0ZzQlBr; Fri, 20 Dec 2019 15:04:15 +0100 (CET) X-Virus-Scanned: amavisd-new at heinlein-support.de Received: from smtp1.mailbox.org ([80.241.60.240]) by spamfilter06.heinlein-hosting.de (spamfilter06.heinlein-hosting.de [80.241.56.125]) (amavisd-new, port 10030) with ESMTP id UobXaQH75WdR; Fri, 20 Dec 2019 15:04:12 +0100 (CET) From: Aleksa Sarai To: Alexander Viro , Jeff Layton , "J. Bruce Fields" , Shuah Khan Cc: Aleksa Sarai , Florian Weimer , David Laight , Christian Brauner , dev@opencontainers.org, containers@lists.linux-foundation.org, libc-alpha@sourceware.org, linux-api@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: [PATCH v2 0/2] openat2: minor uapi cleanups Date: Sat, 21 Dec 2019 01:03:26 +1100 Message-Id: <20191220140328.20907-1-cyphar@cyphar.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Patch changelog: v2: * Add include to openat2.h. [Florian Weimer] * Move OPEN_HOW_SIZE_* constants out of UAPI. [Florian Weimer] * Switch from __aligned_u64 to __u64 since it isn't necessary. [David Laight] v1: While openat2(2) is still not yet in Linus's tree, we can take this opportunity to iron out some small warts that weren't noticed earlier: * A fix was suggested by Florian Weimer, to separate the openat2 definitions so glibc can use the header directly. I've put the maintainership under VFS but let me know if you'd prefer it belong ot the fcntl folks. * Having heterogenous field sizes in an extensible struct results in "padding hole" problems when adding new fields (in addition the correct error to use for non-zero padding isn't entirely clear ). The simplest solution is to just copy clone(3)'s model -- always use u64s. It will waste a little more space in the struct, but it removes a possible future headache. Aleksa Sarai (2): openat2: drop open_how->__padding field uapi: split openat2(2) definitions from fcntl.h MAINTAINERS | 1 + fs/open.c | 2 - include/linux/fcntl.h | 4 ++ include/uapi/linux/fcntl.h | 37 +----------------- include/uapi/linux/openat2.h | 39 +++++++++++++++++++ tools/testing/selftests/openat2/helpers.h | 7 ++-- .../testing/selftests/openat2/openat2_test.c | 24 ++++-------- 7 files changed, 56 insertions(+), 58 deletions(-) create mode 100644 include/uapi/linux/openat2.h base-commit: 912dfe068c43fa13c587b8d30e73d335c5ba7d44 -- 2.24.0