Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp3395174ybl; Fri, 20 Dec 2019 08:35:39 -0800 (PST) X-Google-Smtp-Source: APXvYqxNUzSFUs6HCCRUEO5zqHj9gZdzDQSpJXskbLj7mw+q0HgYMm1qd8Aa0xpSEYTqtw8Jtr6w X-Received: by 2002:a05:6830:1cd3:: with SMTP id p19mr224071otg.70.1576859738950; Fri, 20 Dec 2019 08:35:38 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1576859738; cv=none; d=google.com; s=arc-20160816; b=N1F+mlBYFbB4IUfGCogOeEZxPW6vYuMwIGGJGV4bMNtm8sCCicjD5hSL3ezT+DzBdm IeQAmtlT9kkSBT2FkxIDwYJMtCqjKunErke97J4Iv1GTVwP99rw9IvQEhlcM4gJCLRlk Jbpv0h7zExr0pNzlwsL/V4UH9gylTYp1KB5rnic7AuJWMo7/ljkQyRt9SiX3mDECvW2Y BqJhk7s/zXdpJ/zYyxSbs4P6gYpwJrqsfXNmKkphH72r7J9jXkZwVNTWZAPlaB5gEOl6 CDnpBG7klFvRf69eg9sFY4hstK50G0JH39eeTRforXqj6aRzPFos9GpbhTlsbuCd+SgQ oJMw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=s2wiG4V9nXDcYp93nFV8wxg+pKyytXlurRJn0olF8cc=; b=lZ7uqbjDsBJrPCsHH4sInPA/cTGNY8bjQyURmzWiCwd4839taTnc3rZwwVT4hQm5kV LLRvUGV8iWNt0VVq+e4D3RRxUWupSY8HMFra1NNHkClxXHKXMwMpIan8mmq8NDqpTh7Q 1w0dG/PdG+/Il2zQQV+zZt9kNHAAurKSOReLRETA2wLpzWSlkhcgWVUS3LhAJalAGWCk oR19x8+Sbs0Essnxq24p0XWnRIrYmo5hR/NtLVUaTEbjgTvPUsR1IjkrnVO83ogZQlkJ xZ7ZvSPAniClJDn3+9/bjFpyKVmxkZRVWwzAVjGrEHRHMRVL7NuMrRQESnQrTiEcv4WH mKcw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=mEbQsjqJ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h11si5276646otr.197.2019.12.20.08.35.25; Fri, 20 Dec 2019 08:35:38 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@gmail.com header.s=20161025 header.b=mEbQsjqJ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727403AbfLTQeo (ORCPT + 99 others); Fri, 20 Dec 2019 11:34:44 -0500 Received: from mail-qt1-f176.google.com ([209.85.160.176]:45902 "EHLO mail-qt1-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726808AbfLTQeo (ORCPT ); Fri, 20 Dec 2019 11:34:44 -0500 Received: by mail-qt1-f176.google.com with SMTP id l12so8645831qtq.12; Fri, 20 Dec 2019 08:34:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=s2wiG4V9nXDcYp93nFV8wxg+pKyytXlurRJn0olF8cc=; b=mEbQsjqJ1j16fUpahYOimus1B1lnXLMQnQLpFURegX8v17kvx4s6H+uyrHvLcriQav 2lEpXor9io+tIVsXk8R0U2mbpNkNgMau9xFmqOycHTIItkTdYgUzzcOUzYXovW4nRvMk nKiT2Kq7R/hWzTH22vxLdKvCyzF/3WCFjHjOmgOm6oflj4gY9oDtpQe0/LIuzM/KjXSd QcaPnUUNDaZtR5palhizK4VrANl7sPB3suRw2PUu/vJdDUKcVMoP6wqDP5goo6mmImxR PDLu11WprAKnGdVb/skReG0K3eSPOFO70nWhNdDkHrq5nY+potj3utsjOyqlg4tjhbAT hMYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to:user-agent; bh=s2wiG4V9nXDcYp93nFV8wxg+pKyytXlurRJn0olF8cc=; b=XeVGYr9onpf8sCYIdliI1b6YMhnMZICWXf+lkZjsY6tX6afPBhj/eWMkVBNgPTp0v4 S7TRK21tXeBjKz4n+frY9mL+gpIKKLtoZ3x5SgL0VA+x6Kv/kbr5R0xwmL9RqisK55jQ 36FdcIJ9DRzOlGsB+fk14HCLAypZTXGKV9pgO+tPFY6ouML3kSACPCFBYHD2fAJLPaVm YzYA0OP+C+0uGL2vM/P/AFMZAaLh8ql53Lg4diFiOl+KA5XW30x4Rbq2jyT9Zi2hR8VV +BbjYtXDM9zTEpX7fC9d1Uj1weUjKpSsZ9Jd4fpy5Dp2qjxysTWZ9YK+MII6EibCywtt JiYQ== X-Gm-Message-State: APjAAAV1FPMCx1hV7HnbAw18RJkWlfOiSHkH+6lTf4byG+NHErzToV5F 7Sn0zpZSEfoKO85aP1KvUAEw5nawChc= X-Received: by 2002:ac8:664a:: with SMTP id j10mr12215392qtp.70.1576859683642; Fri, 20 Dec 2019 08:34:43 -0800 (PST) Received: from localhost ([2620:10d:c091:480::11e7]) by smtp.gmail.com with ESMTPSA id x126sm2955357qkc.42.2019.12.20.08.34.42 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 20 Dec 2019 08:34:43 -0800 (PST) Date: Fri, 20 Dec 2019 08:34:41 -0800 From: Tejun Heo To: Eric Dumazet Cc: Jesper Dangaard Brouer , =?iso-8859-1?Q?Bj=F6rn_T=F6pel?= , bpf , LKML , Christoph Lameter , Dennis Zhou Subject: Re: Percpu variables, benchmarking, and performance weirdness Message-ID: <20191220163441.GH2914998@devbig004.ftw2.facebook.com> References: <20191220103420.6f9304ab@carbon> <20191220151239.GE2914998@devbig004.ftw2.facebook.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 20, 2019 at 08:22:02AM -0800, Eric Dumazet wrote: > I definitely seen expensive per-cpu updates in the stack. > (SNMP counters, or per-cpu stats for packets/bytes counters) > > It might be nice to have an option to use 2M pages. > > (I recall sending some patches in the past about using high-order pages for vmalloc, > but this went nowhere) Yeah, the percpu allocator implementation is half-way prepared for that. There just hasn't been a real need for that yet. If this actually is a difference coming from tlb pressure, this might be it, I guess? Thanks. -- tejun