Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 20 Dec 2019 08:51:13 -0800
From:   Bjorn Andersson <bjorn.andersson@linaro.org>
To:     Georgi Djakov <georgi.djakov@linaro.org>
Cc:     linux-pm@vger.kernel.org, evgreen@chromium.org,
        daidavid1@codeaurora.org, okukatla@codeaurora.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] interconnect: Print the tag in the debugfs summary
Message-ID: <20191220165113.GB549437@yoga>
References: <20191220163846.6485-1-georgi.djakov@linaro.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20191220163846.6485-1-georgi.djakov@linaro.org>
User-Agent: Mutt/1.12.2 (2019-09-21)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri 20 Dec 08:38 PST 2019, Georgi Djakov wrote:

> Now we can have a tag associated with the path. Add this information
> to the interconnect_summary file, as the current information in debugfs
> is incomplete.
> 
> Signed-off-by: Georgi Djakov <georgi.djakov@linaro.org>

Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>

> ---
>  drivers/interconnect/core.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/interconnect/core.c b/drivers/interconnect/core.c
> index 1867fad56c0f..ae80fbea5d2d 100644
> --- a/drivers/interconnect/core.c
> +++ b/drivers/interconnect/core.c
> @@ -34,7 +34,7 @@ static void icc_summary_show_one(struct seq_file *s, struct icc_node *n)
>  	if (!n)
>  		return;
>  
> -	seq_printf(s, "%-30s %12u %12u\n",
> +	seq_printf(s, "%-42s %12u %12u\n",
>  		   n->name, n->avg_bw, n->peak_bw);
>  }
>  
> @@ -42,8 +42,8 @@ static int icc_summary_show(struct seq_file *s, void *data)
>  {
>  	struct icc_provider *provider;
>  
> -	seq_puts(s, " node                                   avg         peak\n");
> -	seq_puts(s, "--------------------------------------------------------\n");
> +	seq_puts(s, " node                                  tag          avg         peak\n");
> +	seq_puts(s, "--------------------------------------------------------------------\n");
>  
>  	mutex_lock(&icc_lock);
>  
> @@ -58,8 +58,8 @@ static int icc_summary_show(struct seq_file *s, void *data)
>  				if (!r->dev)
>  					continue;
>  
> -				seq_printf(s, "    %-26s %12u %12u\n",
> -					   dev_name(r->dev), r->avg_bw,
> +				seq_printf(s, "  %-27s %12u %12u %12u\n",
> +					   dev_name(r->dev), r->tag, r->avg_bw,
>  					   r->peak_bw);
>  			}
>  		}