Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp3459968ybl; Fri, 20 Dec 2019 09:37:42 -0800 (PST) X-Google-Smtp-Source: APXvYqzFqqa7TViyjotIXpohryJRRprXvpMgeEbTRDckRb6BRpVzrNOUA8MxIzFS4r2dLTvB7p4a X-Received: by 2002:a05:6830:154c:: with SMTP id l12mr16064813otp.275.1576863462303; Fri, 20 Dec 2019 09:37:42 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1576863462; cv=none; d=google.com; s=arc-20160816; b=XqKB/AaP95H5jlCsA4suPnh2dAv7z86oG5HbE0PUPIygWvUHieFskMI8fbWDLst3L/ y9q+fizLHnBlqZllY5Gmt+Uz/tQsjDQmIz2wiJWa09r1UMsFngVGBWVK+7HbT6ZiT6tq v7ajRoPagpuxgk0M5zBVDFOmpzjxaVHx6Pquk0zn5PHwyGVpOUbhrqfn5fWRdGJQmyIO S0QgUWlJogF4xRZsbn2Uk+5x+zHy+mvSWmxR7ZZz0TS1JYtJVJpH1ljbN+PRFBNTTGNN JEoOZneXVSTKuaJGlKvrbb1ouglWqXQSD4KS7ZfETzFnlpOjhBJu09KW88ghpTRq1gOR Xj2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=ioEUcjwKUHWcaKOXCgYng/umlg7kyq0xM748xsHZhfE=; b=EoQ1SNrQObNiU7O/oI7YGyPehbF3T8ghCsuUB03L+N+hqVTerCYaRSfuXBsqm5p5ny mLxNFgkEgcGHMDlpn8gX2CgT7zQmt5/jXlAlhZS4/E7Wj8HujnjcW+8WkZ6br1Cj0OKO 9UV7jOSXlKh7je7dKVJeGl3meL+dDFPRNT9eSyQJ2PRt1sBss8DPbhTuJ0XXE/cXWhk2 kJT93ekOgE0hDk4Pr78l8CDu535TMzHNZhXvNIS/r1YTwT88U9gBdh50g7+jTRZP8sCN I9qK915ZyrgyDum0qVyK5HdZKDQ/JiY6S61JeMMkvFsYHx5+BJ/ZYAqiVOp4Z811xmo2 FzZQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r26si5541478otc.163.2019.12.20.09.37.30; Fri, 20 Dec 2019 09:37:42 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727473AbfLTRgY (ORCPT + 99 others); Fri, 20 Dec 2019 12:36:24 -0500 Received: from foss.arm.com ([217.140.110.172]:53638 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727388AbfLTRgX (ORCPT ); Fri, 20 Dec 2019 12:36:23 -0500 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1204C1FB; Fri, 20 Dec 2019 09:36:23 -0800 (PST) Received: from e107158-lin.cambridge.arm.com (e107158-lin.cambridge.arm.com [10.1.195.21]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id D01A13F6CF; Fri, 20 Dec 2019 09:36:21 -0800 (PST) Date: Fri, 20 Dec 2019 17:36:19 +0000 From: Qais Yousef To: Peter Zijlstra Cc: Steven Rostedt , Ingo Molnar , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Ben Segall , Mel Gorman , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] sched: rt: Make RT capacity aware Message-ID: <20191220173619.rf4riiayfrcqqo3o@e107158-lin.cambridge.arm.com> References: <20191009104611.15363-1-qais.yousef@arm.com> <20191028143749.GE4114@hirez.programming.kicks-ass.net> <20191028140147.036a0001@grimm.local.home> <20191028205034.GL4643@worktop.programming.kicks-ass.net> <20191220160149.fj5gdkaxm763fhfl@e107158-lin.cambridge.arm.com> <20191220171806.GQ2827@hirez.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20191220171806.GQ2827@hirez.programming.kicks-ass.net> User-Agent: NeoMutt/20171215 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/20/19 18:18, Peter Zijlstra wrote: > On Fri, Dec 20, 2019 at 04:01:49PM +0000, Qais Yousef wrote: > > On 10/28/19 21:50, Peter Zijlstra wrote: > > > On Mon, Oct 28, 2019 at 02:01:47PM -0400, Steven Rostedt wrote: > > > > On Mon, 28 Oct 2019 15:37:49 +0100 > > > > Peter Zijlstra wrote: > > > > > > > > Works for me; Steve you OK with this? > > > > > > > > Nothing against it, but I want to take a deeper look before we accept > > > > it. Are you OK in waiting a week? I'm currently at Open Source Summit > > > > and still have two more talks to write (giving them Thursday). I wont > > > > have time to look till next week. > > > > > > Sure, I'll keep it in my queue, but will make sure it doesn't hit -tip > > > until you've had time. > > > > Reviewers are happy with this now. It'd be nice if you can pick it up again for > > the next round to -tip. > > > > Sorry, I missed Steve's and Dietmar's replies. It should shorty appear > in queue.git and I'll try and push to -tip over the weekend (provided > the robots don't come up with something fishy). No worries, thanks! It missed the 5.5 merge window anyway. We had 2 reports by the buildbot last time, luckily I kept the fixups at the top of my local branch. Happy to apply locally again or prefer I send v3? Cheers --- diff --git a/kernel/sched/cpupri.c b/kernel/sched/cpupri.c index 799791c01d60..bdfb802d4c12 100644 --- a/kernel/sched/cpupri.c +++ b/kernel/sched/cpupri.c @@ -46,6 +46,8 @@ static int convert_prio(int prio) * @cp: The cpupri context * @p: The task * @lowest_mask: A mask to fill in with selected CPUs (or NULL) + * @fitness_fn: A pointer to a function to do custom checks whether the CPU + * fits a specific criteria so that we only return those CPUs. * * Note: This function returns the recommended CPUs as calculated during the * current invocation. By the time the call returns, the CPUs may have in diff --git a/kernel/sched/rt.c b/kernel/sched/rt.c index 3a68054e15b3..6afecb5557db 100644 --- a/kernel/sched/rt.c +++ b/kernel/sched/rt.c @@ -452,7 +452,7 @@ static inline int on_rt_rq(struct sched_rt_entity *rt_se) * Note that uclamp_min will be clamped to uclamp_max if uclamp_min * > uclamp_max. */ -inline bool rt_task_fits_capacity(struct task_struct *p, int cpu) +static inline bool rt_task_fits_capacity(struct task_struct *p, int cpu) { unsigned int min_cap; unsigned int max_cap;