Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 20 Dec 2019 10:52:40 -0800
From:   Guenter Roeck <linux@roeck-us.net>
To:     Srinivas Neeli <srinivas.neeli@xilinx.com>
Cc:     shubhraj@xilinx.com, sgoud@xilinx.com, michal.simek@xilinx.com,
        wim@linux-watchdog.org, linux-watchdog@vger.kernel.org,
        linux-kernel@vger.kernel.org, git@xilinx.com
Subject: Re: [PATCH] watchdog: cadence: Skip printing pointer value
Message-ID: <20191220185240.GF26293@roeck-us.net>
References: <1576825096-26605-1-git-send-email-srinivas.neeli@xilinx.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1576825096-26605-1-git-send-email-srinivas.neeli@xilinx.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, Dec 20, 2019 at 12:28:16PM +0530, Srinivas Neeli wrote:
> "%p" is not printing the pointer value.
> In driver, printing pointer value is not useful so avoiding print.
> 
> Signed-off-by: Srinivas Neeli <srinivas.neeli@xilinx.com>

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

> ---
>  drivers/watchdog/cadence_wdt.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/watchdog/cadence_wdt.c b/drivers/watchdog/cadence_wdt.c
> index 06bd4e1a5923..672b184da875 100644
> --- a/drivers/watchdog/cadence_wdt.c
> +++ b/drivers/watchdog/cadence_wdt.c
> @@ -369,9 +369,8 @@ static int cdns_wdt_probe(struct platform_device *pdev)
>  		return ret;
>  	platform_set_drvdata(pdev, wdt);
>  
> -	dev_info(dev, "Xilinx Watchdog Timer at %p with timeout %ds%s\n",
> -		 wdt->regs, cdns_wdt_device->timeout,
> -		 nowayout ? ", nowayout" : "");
> +	dev_info(dev, "Xilinx Watchdog Timer with timeout %ds%s\n",
> +		 cdns_wdt_device->timeout, nowayout ? ", nowayout" : "");
>  
>  	return 0;
>  }
> -- 
> 2.7.4
>