Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20191219201340.196259-1-pmalani@chromium.org> <20191219201340.196259-2-pmalani@chromium.org>
 <f3d6267e-2429-e5a0-2a0e-60cab5bb1bb9@collabora.com> <20191220105252.GR18955@dell>
In-Reply-To: <20191220105252.GR18955@dell>
From:   Prashant Malani <pmalani@chromium.org>
Date:   Fri, 20 Dec 2019 11:35:47 -0800
Message-ID: <CACeCKadb7tadNEWg-0=8c_km3XXB25JA=rj1UBiFdWMDj37fYQ@mail.gmail.com>
Subject: Re: [PATCH 2/2] mfd: cros_ec: Add usbpd-notify to usbpd_charger
To:     Lee Jones <lee.jones@linaro.org>
Cc:     Enric Balletbo i Serra <enric.balletbo@collabora.com>,
        Guenter Roeck <groeck@chromium.org>,
        Benson Leung <bleung@chromium.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, Dec 20, 2019 at 2:52 AM Lee Jones <lee.jones@linaro.org> wrote:
>
> On Fri, 20 Dec 2019, Enric Balletbo i Serra wrote:
>
> > Hi Prashant,
> >
> > This should be [PATCH v3 2/2]. All the patches in the series should hav=
e the
> > same version otherwise makes difficult to follow.
> >
> > Thanks,
> >  Enric
> >
> > On 19/12/19 21:13, Prashant Malani wrote:
> > > Add the cros-usbpd-notify driver as a cell for the cros_usbpd_charger
> > > subdevice on non-ACPI platforms.
> > >
> > > This driver allows other cros-ec devices to receive PD event
> > > notifications from the Chrome OS Embedded Controller (EC) via a
> > > notification chain.
> > >
> > > Change-Id: I4c062d261fa1a504b43b0a0c0a98a661829593b9
> > > Signed-off-by: Prashant Malani <pmalani@chromium.org>
> > > ---
> > >  drivers/mfd/cros_ec_dev.c | 3 +++
> > >  1 file changed, 3 insertions(+)
> > >
> > > diff --git a/drivers/mfd/cros_ec_dev.c b/drivers/mfd/cros_ec_dev.c
> > > index c4b977a5dd966..1dde480f35b93 100644
> > > --- a/drivers/mfd/cros_ec_dev.c
> > > +++ b/drivers/mfd/cros_ec_dev.c
> > > @@ -85,6 +85,9 @@ static const struct mfd_cell cros_ec_sensorhub_cell=
s[] =3D {
> > >  static const struct mfd_cell cros_usbpd_charger_cells[] =3D {
> > >     { .name =3D "cros-usbpd-charger", },
> > >     { .name =3D "cros-usbpd-logger", },
> > > +#ifndef CONFIG_ACPI
> > > +   { .name =3D "cros-usbpd-notify", },
> > > +#endif
>
> We don't want #iferry all over our c-files.  If you *have* to rely on
> Kconfig configurations, split this out into a separate cell and use
> IS_ENABLED().
Done. Thanks.
>
> --
> Lee Jones [=E6=9D=8E=E7=90=BC=E6=96=AF]
> Linaro Services Technical Lead
> Linaro.org =E2=94=82 Open source software for ARM SoCs
> Follow Linaro: Facebook | Twitter | Blog