Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20191220004946.113151-2-pmalani@chromium.org> <e64cc02a-ca4e-53e1-c0b6-4d38c7e95192@collabora.com>
In-Reply-To: <e64cc02a-ca4e-53e1-c0b6-4d38c7e95192@collabora.com>
From:   Prashant Malani <pmalani@chromium.org>
Date:   Fri, 20 Dec 2019 11:53:23 -0800
Message-ID: <CACeCKadZfd_JAhXOgqPSzQ=hRamqvHF-cYoweR1poQcsowMnSg@mail.gmail.com>
Subject: Re: [PATCH v2 2/2] mfd: cros_ec: Add usbpd-notify to usbpd_charger
To:     Enric Balletbo i Serra <enric.balletbo@collabora.com>
Cc:     Guenter Roeck <groeck@chromium.org>,
        Benson Leung <bleung@chromium.org>,
        Lee Jones <lee.jones@linaro.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, Dec 20, 2019 at 12:52 AM Enric Balletbo i Serra
<enric.balletbo@collabora.com> wrote:
>
> Hi Prashant,
>
> Please try to maintain versions and changelog consistently. I.e I see v2 here
> but I guess you only send this patch not the full series, also I see that you
> send v3 before this?
>
> In general you should send the full series on every version and maintain a full
> changelog.
>
> I'd like to see v4 including all the series so it's clear from were we pick up
> the patches.
>
> On 20/12/19 1:49, Prashant Malani wrote:
> > Add the cros-usbpd-notify driver as a cell for the cros_usbpd_charger
> > subdevice on non-ACPI platforms.
> >
> > This driver allows other cros-ec devices to receive PD event
> > notifications from the Chrome OS Embedded Controller (EC) via a
> > notification chain.
> >
> > Signed-off-by: Prashant Malani <pmalani@chromium.org>
>
> For v4 you can include:
>
> Acked-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Since the v4 of this patch involves a substantial difference from the
previous version, I determined not to auto-add the Acked-by. My
apologies if you reckon I should've added it anyway.
>
> Thanks,
>  Enric
>
> > ---
> >
> > Changes in v2:
> > - Removed auto-generated Change-Id.
> >
> >  drivers/mfd/cros_ec_dev.c | 3 +++
> >  1 file changed, 3 insertions(+)
> >
> > diff --git a/drivers/mfd/cros_ec_dev.c b/drivers/mfd/cros_ec_dev.c
> > index c4b977a5dd966..1dde480f35b93 100644
> > --- a/drivers/mfd/cros_ec_dev.c
> > +++ b/drivers/mfd/cros_ec_dev.c
> > @@ -85,6 +85,9 @@ static const struct mfd_cell cros_ec_sensorhub_cells[] = {
> >  static const struct mfd_cell cros_usbpd_charger_cells[] = {
> >       { .name = "cros-usbpd-charger", },
> >       { .name = "cros-usbpd-logger", },
> > +#ifndef CONFIG_ACPI
> > +     { .name = "cros-usbpd-notify", },
> > +#endif
> >  };
> >
> >  static const struct cros_feature_to_cells cros_subdevices[] = {
> >