Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 20 Dec 2019 18:47:37 -0300
From:   Arnaldo Carvalho de Melo <acme@redhat.com>
To:     Steven Rostedt <rostedt@goodmis.org>
Cc:     Hewenliang <hewenliang4@huawei.com>, tstoyanov@vmware.com,
        linux-kernel@vger.kernel.org, linfeilong@huawei.com
Subject: Re: [PATCH] tools lib traceevent: Fix memory leakage in filter_event
Message-ID: <20191220214737.GB3582@redhat.com>
References: <20191209063549.59941-1-hewenliang4@huawei.com>
 <20191219205631.2e12571c@rorschach.local.home>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20191219205631.2e12571c@rorschach.local.home>
User-Agent: Mutt/1.5.20 (2009-12-10)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Em Thu, Dec 19, 2019 at 08:56:31PM -0500, Steven Rostedt escreveu:
> On Mon, 9 Dec 2019 01:35:49 -0500
> Hewenliang <hewenliang4@huawei.com> wrote:
> 
> > It is necessary to call free_arg(arg) when add_filter_type returns NULL in
> > the function of filter_event.
> > 
> > Signed-off-by: Hewenliang <hewenliang4@huawei.com>
> 
> This looks fine.
> 
> Reviewed-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
> 
> Arnaldo, care to take this?

Sure, just landed in  acme/perf/urgent :)

- Arnaldo
 
> -- Steve
> 
> > ---
> >  tools/lib/traceevent/parse-filter.c | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> > 
> > diff --git a/tools/lib/traceevent/parse-filter.c b/tools/lib/traceevent/parse-filter.c
> > index f3cbf86e51ac..20eed719542e 100644
> > --- a/tools/lib/traceevent/parse-filter.c
> > +++ b/tools/lib/traceevent/parse-filter.c
> > @@ -1228,8 +1228,10 @@ filter_event(struct tep_event_filter *filter, struct tep_event *event,
> >  	}
> >  
> >  	filter_type = add_filter_type(filter, event->id);
> > -	if (filter_type == NULL)
> > +	if (filter_type == NULL) {
> > +		free_arg(arg);
> >  		return TEP_ERRNO__MEM_ALLOC_FAILED;
> > +	}
> >  
> >  	if (filter_type->filter)
> >  		free_arg(filter_type->filter);