Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp4011268ybl;
        Fri, 20 Dec 2019 21:18:26 -0800 (PST)
X-Google-Smtp-Source: APXvYqxSnr8PAMp+ZJNKBdq2y2bcpgMYHQrR8E/s5v9uDnBapbLORke10COo8B+MRMK38G+bSJ1Z
X-Received: by 2002:a05:6830:2097:: with SMTP id y23mr3112131otq.286.1576905506877;
        Fri, 20 Dec 2019 21:18:26 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1576905506; cv=none;
        d=google.com; s=arc-20160816;
        b=lld1gANqMbgTnBfmEI7B6bets+HxMW+SZJBSP6nikcJ8S0uml8HnMRj8vLTr/uFx9l
         V10jPVzR+XEEgEXvsPs+jL1IWgwc97dxrRJiBjQGFHCGaHhw5Ze+u7tLfD3ASalCO5lQ
         KcKrK8geHqOodwvLqk5HBCJ83QKJvLdPF7z7YekNQ4lTIPk1QHp7y+F3OT7B38KaVnkV
         a/w569KepQAQZaCbrbdo31E7rgrm/WZOySuTLX1kUdKUxCK9AKiTR2OtlwpZmvCz/rJ+
         L3kqN9uWjHZ01efPvI3Ts07I02kkxgzDxH1OwmHlXltoduK2kNb097ECDvuNPvkTsMxo
         biBw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:content-transfer-encoding:mime-version
         :references:in-reply-to:from:subject:cc:to:message-id:date;
        bh=wRv8gd+nbU+mb0biW/LFvhleJKlKAAVAMlo9aqIJDck=;
        b=ljcZ4oORyINobhTW6OZiRDv0jm1k8rH9jdSRoIxKeQspGgT/KQqhHbwk5L9GMMNXuJ
         QtXY5pVcUcY9VOROaKAdntU4i3A9CxlNGyud3wjCW2lHRWzhE7g4yZ9P25MgSUJHQO//
         1KIyjOlEtgHsIJgw5vLJWb5anFq9uUGQWV8Ola3Z7HIyehr3QpGcbx7weQuxuv8lIU5W
         guX5SxSn+4TXhUxgYdIlrAaIiR2NCIt4d4pIvIm883bc4wYKBNN3jwUU4FkgoVhOdOOv
         lBu3QBQIjrfZGWnFMHHhWT8VhpJCYdBe3fe8AlDLl3e3DUlUU/n4TBQTuewdRFzeeuaG
         1zZA==
ARC-Authentication-Results: i=1; mx.google.com;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67])
        by mx.google.com with ESMTP id w129si6126921oig.83.2019.12.20.21.18.14;
        Fri, 20 Dec 2019 21:18:26 -0800 (PST)
Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Authentication-Results: mx.google.com;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1726087AbfLUFRf (ORCPT <rfc822;ahaning.tech@gmail.com>
        + 99 others); Sat, 21 Dec 2019 00:17:35 -0500
Received: from shards.monkeyblade.net ([23.128.96.9]:56854 "EHLO
        shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1725774AbfLUFRf (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Sat, 21 Dec 2019 00:17:35 -0500
Received: from localhost (unknown [IPv6:2601:601:9f00:1c3::3d5])
        (using TLSv1 with cipher AES256-SHA (256/256 bits))
        (Client did not present a certificate)
        (Authenticated sender: davem-davemloft)
        by shards.monkeyblade.net (Postfix) with ESMTPSA id 50522153CAB2E;
        Fri, 20 Dec 2019 21:17:34 -0800 (PST)
Date:   Fri, 20 Dec 2019 21:17:33 -0800 (PST)
Message-Id: <20191220.211733.1421052503969423092.davem@davemloft.net>
To:     vincent.cheng.xh@renesas.com
Cc:     robh+dt@kernel.org, mark.rutland@arm.com, richardcochran@gmail.com,
        devicetree@vger.kernel.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 net-next 1/1] ptp: clockmatrix: Rework clockmatrix
 version information.
From:   David Miller <davem@davemloft.net>
In-Reply-To: <1576725697-11828-2-git-send-email-vincent.cheng.xh@renesas.com>
References: <1576725697-11828-1-git-send-email-vincent.cheng.xh@renesas.com>
        <1576725697-11828-2-git-send-email-vincent.cheng.xh@renesas.com>
X-Mailer: Mew version 6.8 on Emacs 26.1
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 20 Dec 2019 21:17:34 -0800 (PST)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: vincent.cheng.xh@renesas.com
Date: Wed, 18 Dec 2019 22:21:37 -0500

> From: Vincent Cheng <vincent.cheng.xh@renesas.com>
> 
> Remove pipeline id, bond id, csr id, and irq id.
> Changes source register for reading HW rev id.
> Add OTP config select.
> 
> Signed-off-by: Vincent Cheng <vincent.cheng.xh@renesas.com>

Nothing in this commit message explains why this change is being made.

What is wrong with the existing version code?  What is better about the
new code?

You always must explain why a change is being made and give as much
information and details and background as possible.

Thank you.