Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Milind Parab <mparab@cadence.com>
To:     Russell King - ARM Linux admin <linux@armlinux.org.uk>
CC:     "andrew@lunn.ch" <andrew@lunn.ch>,
        "antoine.tenart@bootlin.com" <antoine.tenart@bootlin.com>,
        "f.fainelli@gmail.com" <f.fainelli@gmail.com>,
        "davem@davemloft.net" <davem@davemloft.net>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "hkallweit1@gmail.com" <hkallweit1@gmail.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Dhananjay Vilasrao Kangude <dkangude@cadence.com>,
        "a.fatoum@pengutronix.de" <a.fatoum@pengutronix.de>,
        "brad.mouring@ni.com" <brad.mouring@ni.com>,
        Parshuram Raju Thombare <pthombar@cadence.com>,
        "Nicolas.Ferre@microchip.com" <Nicolas.Ferre@microchip.com>
Subject: RE: [PATCH v2 3/3] net: macb: add support for high speed interface
Thread-Topic: [PATCH v2 3/3] net: macb: add support for high speed interface
Thread-Index: AQHVsZm5l82MVXLf60OyobQPmImAGae7UQaAgAACAgCAAWMWwIAACq4AgAe4FfA=
Date:   Sat, 21 Dec 2019 11:08:18 +0000
Message-ID: <BY5PR07MB6514F3B5E2A1B910218F7EFBD32C0@BY5PR07MB6514.namprd07.prod.outlook.com>
References: <1576230007-11181-1-git-send-email-mparab@cadence.com>
 <1576230177-11404-1-git-send-email-mparab@cadence.com>
 <20191215151249.GA25745@shell.armlinux.org.uk>
 <20191215152000.GW1344@shell.armlinux.org.uk>
 <BY5PR07MB65143D385836FF49966F5F6AD3510@BY5PR07MB6514.namprd07.prod.outlook.com>
 <20191216130908.GI25745@shell.armlinux.org.uk>
In-Reply-To: <20191216130908.GI25745@shell.armlinux.org.uk>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: cadence.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: fcba9aa4-7f33-4678-6cb4-08d786061594
X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Dec 2019 11:08:18.4310
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: d36035c5-6ce6-4662-a3dc-e762e61ae4c9
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: ZIuMK6MS+VBfsvlOytH2HPJIf9j4mqtB9vKb/luH998YvuABw9ZHx9pJ0BCGtRPg1vcbygQ5WkLCU1s2/Vyh9o5FGwPHzoSGFrpqR2tApn0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR07MB7202
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.95,18.0.572
 definitions=2019-12-21_02:2019-12-17,2019-12-21 signatures=0
X-Proofpoint-Spam-Details: rule=outbound_check_notspam policy=outbound_check score=0 spamscore=0
 impostorscore=0 mlxscore=0 lowpriorityscore=0 malwarescore=0 bulkscore=0
 clxscore=1015 suspectscore=0 phishscore=0 mlxlogscore=791
 priorityscore=1501 adultscore=0 classifier=spam adjust=0 reason=mlx
 scancount=1 engine=8.12.0-1910280000 definitions=main-1912210097
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>>
>> Additional 3rd party I2C IP required (not part of GEM) for module
>> interrogation (MDIO to I2C handled by SW
>>  +--------------+                                  +-----------+
>>  |              |       |        |                 |  SFP+     |
>>  | GEM MAC/DMA  | <---> | SerDes | <---- SFI-----> | Optical   |
>>  |   USX PCS|   |       | (PMA)  |                 | Module    |
>>  +--------------+                                  +-----------+
>>                                                          ^
>>         +--------+                                       |
>>         | I2C    |                                       |
>>         | Master | <-------------------------------------|
>>         +--------+
>The kernel supports this through the sfp and phylink support. SFI is
>more commonly known as 10GBASE-R. Note that this is *not* USXGMII.
>Link status needs to come from the MAC side, so macb_mac_pcs_get_state()
>is required.
>
>> Rate determined by 10GBASE-T PHY capability through auto-negotiation.
>> I2C IP required
>>  +--------------+                                  +-----------+
>>  |              |       |        |                 |  SFP+ to  |
>>  | GEM MAC/DMA  | <---> | SerDes | <---- SFI-----> | 10GBASE-T |
>>  |   USX PCS|   |       | (PMA)  |                 |           |
>>  +--------------+                                  +-----------+
>>                                                          ^
>>         +--------+                                       |
>>         | I2C    |                                       |
>>         | Master | <-------------------------------------|
>>         +--------+
>
>The 10G copper module I have uses 10GBASE-R, 5000BASE-X, 2500BASE-X,
>and SGMII (without in-band status), dynamically switching between
>these depending on the results of the copper side negotiation.
>
>> USXGMII PHY. Uses MDIO or equivalent for status xfer
>>  +-------------+                                    +--------+
>>  |             |       |        |                   |        |
>>  | GEM MAC/DMA | <---> | SerDes | <--- USXGMII ---> |  PHY   |
>>  |  USX PCS    |       | (PMA)  |                   |        |
>>  +-------------+                                    +--------+
>>        ^                                                 ^
>>        |_____________________ MDIO ______________________|
>
>Overall, please implement phylink properly for your MAC, rather than
>the current half-hearted approach that *will* break in various
>circumstances.
>

We would need more time to get back on the restructured implementation.=20
While we work on that, is it okay to accept patch 1/3 and patch 2/3?