Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20191220001517.105297-1-olof@lixom.net> <ff6dc8997083c5d8968df48cc191e5b9e8797618.camel@perches.com>
In-Reply-To: <ff6dc8997083c5d8968df48cc191e5b9e8797618.camel@perches.com>
From:   Olof Johansson <olof@lixom.net>
Date:   Sat, 21 Dec 2019 13:19:40 -0800
Message-ID: <CAOesGMgxHGBdkdVOoWYpqSF-13iP3itJksCRL8QSiS0diL26dA@mail.gmail.com>
Subject: Re: [PATCH] net/mlx5e: Fix printk format warning
To:     Joe Perches <joe@perches.com>
Cc:     Saeed Mahameed <saeedm@mellanox.com>,
        Leon Romanovsky <leon@kernel.org>,
        Network Development <netdev@vger.kernel.org>,
        linux-rdma@vger.kernel.org,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, Dec 19, 2019 at 6:07 PM Joe Perches <joe@perches.com> wrote:
>
> On Thu, 2019-12-19 at 16:15 -0800, Olof Johansson wrote:
> > Use "%zu" for size_t. Seen on ARM allmodconfig:
> []
> > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/wq.c b/drivers/net/ethernet/mellanox/mlx5/core/wq.c
> []
> > @@ -89,7 +89,7 @@ void mlx5_wq_cyc_wqe_dump(struct mlx5_wq_cyc *wq, u16 ix, u8 nstrides)
> >       len = nstrides << wq->fbc.log_stride;
> >       wqe = mlx5_wq_cyc_get_wqe(wq, ix);
> >
> > -     pr_info("WQE DUMP: WQ size %d WQ cur size %d, WQE index 0x%x, len: %ld\n",
> > +     pr_info("WQE DUMP: WQ size %d WQ cur size %d, WQE index 0x%x, len: %zu\n",
> >               mlx5_wq_cyc_get_size(wq), wq->cur_sz, ix, len);
> >       print_hex_dump(KERN_WARNING, "", DUMP_PREFIX_OFFSET, 16, 1, wqe, len, false);
> >  }
>
> One might expect these 2 outputs to be at the same KERN_<LEVEL> too.
> One is KERN_INFO the other KERN_WARNING

Sure, but I'll leave that up to the driver maintainers to decide/fix
-- I'm just addressing the type warning here.


-Olof