Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp5392751ybl; Sun, 22 Dec 2019 05:17:21 -0800 (PST) X-Google-Smtp-Source: APXvYqy5aTmQxnzAjn1yiHXXPHW7witMI82LVJZ6ZOrK8Udy6mTMGJXzDuFHzzuhGETA5d7wzr53 X-Received: by 2002:a9d:7590:: with SMTP id s16mr25119225otk.89.1577020641107; Sun, 22 Dec 2019 05:17:21 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1577020641; cv=none; d=google.com; s=arc-20160816; b=vVz1nBqmo2zo6WLHJmBBhEGoqZ/3NZ/cnD7L3rJeJgW5gg5tuMncDminpyz3w+43T2 9L6z6Yiz7lJL1K7srmPTLCWuShhW/mTRJBKf6L1KWSHlERluMsg2ncuBcHCLjWpzWMsd 0RK6uIBomktZvuhJJfG8Zc5amqB3V3zcHYgQaArLqmM3cbQ+Hr1/RsisWntEN2I2w2e4 ulnSN+sqkKFuKUTtUeeI3krRGl4VU2kJTahG9sOJ9qW73HQkfshL8dNy6vLfREPFUvS3 WWenVYog1q5ZK082z6sfYgbESO5pyun6F2Hk10T34w38S+MzZPrkYX2kszqm84HND4jS KykA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=7gCpuLlUP9MlgLBoutsCmLPmUqjnC7xAMqI1v5Bo+1w=; b=S1eceeDWMgiu5NG4iThrcALxFrAJ7mNrzGcgwtxVggGS77e/pzzHLbU3GAHa9h3qc+ V8Y3jZ2saswcqYkO2yXaYUhDeE32dmdOwAR2JuLruNsFK3fAB7d4k7r2xGyY58CoMQrZ VUaUCkz32DrXcXJgDBldoMjlHx+8LG/JRSEgzbaRtcDbRrbnO8x+Cuo/SrmAqOINYAQj K/skNcTqasK0Qsd3x46+6YESbl76boJw6J1Ijiu/XAfhtGwoce/2hhTKLAvESqMQHk5H AfBKIHp3WFjcW4stWHrWyksm5wGw8m85XOVq25UsDv+LfQrD3FjcmXpv8ZJ4ikhfoJ4P Sqgw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=eFW56aRl; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z16si8989411otk.80.2019.12.22.05.16.37; Sun, 22 Dec 2019 05:17:21 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=eFW56aRl; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726393AbfLVNLa (ORCPT + 99 others); Sun, 22 Dec 2019 08:11:30 -0500 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:34982 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725840AbfLVNL3 (ORCPT ); Sun, 22 Dec 2019 08:11:29 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1577020287; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7gCpuLlUP9MlgLBoutsCmLPmUqjnC7xAMqI1v5Bo+1w=; b=eFW56aRlDtYw8KN20qT/5ZtAuzrxmc9MI9Sw8fXFJYBUo9Qxbdsrqxj17wuIS6bUFz/I3Q Sbm0korOniwfHQihm7DDVJyMkCgVDLhrjR77+oBP05wY6IW1naTEldGp6XMMzTDCc9MZr4 +HHJ/8VYIr8ozDnzf9RoDv1Ba9yOcoA= Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-108-hKbIeLJ1OVGm1IOAbeUFnA-1; Sun, 22 Dec 2019 08:11:24 -0500 X-MC-Unique: hKbIeLJ1OVGm1IOAbeUFnA-1 Received: by mail-qt1-f200.google.com with SMTP id k27so9380861qtu.12 for ; Sun, 22 Dec 2019 05:11:24 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=7gCpuLlUP9MlgLBoutsCmLPmUqjnC7xAMqI1v5Bo+1w=; b=F+eCLz9IX7sPdCYFuJNKnLTRtb9T+FyrmpNE5Q+Uhw/ogX/tlcGJwIkBrIQqrZ41Uy LFBflvzegdj0jBJ+pgZ61qC3Qd8kie/OtMJAVn1XNexCCgdqruF+IK0nYxQsaH3n9sL6 P+Ibjh/cJddloK+TnG723ByqkqAIm/hxBSM9TmAxdQgD+ay0SulRGpRzm/CwD46yxVVA X9S/xXRzPIfHBZ6INOPXDeotwyYcy/RfRc1I9ut5l5rSepzRZ5sm60pvyEEti6d/bCVf FbAbvyYoUWgEs1KGVyyLEobbU0NS3ldv5eQ2DTUcaZf0kgehGGsyd4VvxHKW7B+t7tf5 dcyA== X-Gm-Message-State: APjAAAVp+4ObvFeNEUnIQodc3yQVlL65ONcqLkmStyoA/0NrG1LVUdlW r/B3lgUpijvLAF6pbh0RTDWBR3XN5lAfS/Xrs+1IeN+J3RkRn554gw2yokCR9Egei8gsaBXVjXL WtVLkc/qLooySeL94KoDmLYc6 X-Received: by 2002:a05:6214:10c1:: with SMTP id r1mr20617246qvs.70.1577020282492; Sun, 22 Dec 2019 05:11:22 -0800 (PST) X-Received: by 2002:a05:6214:10c1:: with SMTP id r1mr20617225qvs.70.1577020282261; Sun, 22 Dec 2019 05:11:22 -0800 (PST) Received: from redhat.com (bzq-79-181-48-215.red.bezeqint.net. [79.181.48.215]) by smtp.gmail.com with ESMTPSA id t38sm5308551qta.78.2019.12.22.05.11.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 22 Dec 2019 05:11:21 -0800 (PST) Date: Sun, 22 Dec 2019 08:11:15 -0500 From: "Michael S. Tsirkin" To: Willem de Bruijn Cc: Alistair Delva , Network Development , stable , Jason Wang , "David S . Miller" , kernel-team@android.com, virtualization@lists.linux-foundation.org, linux-kernel Subject: Re: [PATCH net] virtio-net: Skip set_features on non-cvq devices Message-ID: <20191222080754-mutt-send-email-mst@kernel.org> References: <20191220212207.76726-1-adelva@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 20, 2019 at 10:08:41PM -0500, Willem de Bruijn wrote: > On Fri, Dec 20, 2019 at 4:22 PM Alistair Delva wrote: > > > > On devices without control virtqueue support, such as the virtio_net > > implementation in crosvm[1], attempting to configure LRO will panic the > > kernel: > > > > kernel BUG at drivers/net/virtio_net.c:1591! > > invalid opcode: 0000 [#1] PREEMPT SMP PTI > > CPU: 1 PID: 483 Comm: Binder:330_1 Not tainted 5.4.5-01326-g19463e9acaac #1 > > Hardware name: ChromiumOS crosvm, BIOS 0 > > RIP: 0010:virtnet_send_command+0x15d/0x170 [virtio_net] > > Code: d8 00 00 00 80 78 02 00 0f 94 c0 65 48 8b 0c 25 28 00 00 00 48 3b 4c 24 70 75 11 48 8d 65 d8 5b 41 5c 41 5d 41 5e 41 5f 5d c3 <0f> 0b e8 ec a4 12 c8 66 90 66 2e 0f 1f 84 00 00 00 00 00 55 48 89 > > RSP: 0018:ffffb97940e7bb50 EFLAGS: 00010246 > > RAX: ffffffffc0596020 RBX: ffffa0e1fc8ea840 RCX: 0000000000000017 > > RDX: ffffffffc0596110 RSI: 0000000000000011 RDI: 000000000000000d > > RBP: ffffb97940e7bbf8 R08: ffffa0e1fc8ea0b0 R09: ffffa0e1fc8ea0b0 > > R10: ffffffffffffffff R11: ffffffffc0590940 R12: 0000000000000005 > > R13: ffffa0e1ffad2c00 R14: ffffb97940e7bc08 R15: 0000000000000000 > > FS: 0000000000000000(0000) GS:ffffa0e1fd100000(006b) knlGS:00000000e5ef7494 > > CS: 0010 DS: 002b ES: 002b CR0: 0000000080050033 > > CR2: 00000000e5eeb82c CR3: 0000000079b06001 CR4: 0000000000360ee0 > > DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 > > DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 > > Call Trace: > > ? preempt_count_add+0x58/0xb0 > > ? _raw_spin_lock_irqsave+0x36/0x70 > > ? _raw_spin_unlock_irqrestore+0x1a/0x40 > > ? __wake_up+0x70/0x190 > > virtnet_set_features+0x90/0xf0 [virtio_net] > > __netdev_update_features+0x271/0x980 > > ? nlmsg_notify+0x5b/0xa0 > > dev_disable_lro+0x2b/0x190 > > ? inet_netconf_notify_devconf+0xe2/0x120 > > devinet_sysctl_forward+0x176/0x1e0 > > proc_sys_call_handler+0x1f0/0x250 > > proc_sys_write+0xf/0x20 > > __vfs_write+0x3e/0x190 > > ? __sb_start_write+0x6d/0xd0 > > vfs_write+0xd3/0x190 > > ksys_write+0x68/0xd0 > > __ia32_sys_write+0x14/0x20 > > do_fast_syscall_32+0x86/0xe0 > > entry_SYSENTER_compat+0x7c/0x8e > > > > This happens because virtio_set_features() does not check the presence > > of the control virtqueue feature, which is sanity checked by a BUG_ON > > in virtnet_send_command(). > > > > Fix this by skipping any feature processing if the control virtqueue is > > missing. This should be OK for any future feature that is added, as > > presumably all of them would require control virtqueue support to notify > > the endpoint that offload etc. should begin. > > > > [1] https://chromium.googlesource.com/chromiumos/platform/crosvm/ > > > > Fixes: a02e8964eaf9 ("virtio-net: ethtool configurable LRO") > > Cc: stable@vger.kernel.org [4.20+] > > Cc: Michael S. Tsirkin > > Cc: Jason Wang > > Cc: David S. Miller > > Cc: kernel-team@android.com > > Cc: virtualization@lists.linux-foundation.org > > Cc: linux-kernel@vger.kernel.org > > Signed-off-by: Alistair Delva > > Thanks for debugging this, Alistair. > > > --- > > drivers/net/virtio_net.c | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c > > index 4d7d5434cc5d..709bcd34e485 100644 > > --- a/drivers/net/virtio_net.c > > +++ b/drivers/net/virtio_net.c > > @@ -2560,6 +2560,9 @@ static int virtnet_set_features(struct net_device *dev, > > u64 offloads; > > int err; > > > > + if (!vi->has_cvq) > > + return 0; > > + > > Instead of checking for this in virtnet_set_features, how about we > make configurability contingent on cvq in virtnet_probe: > > - if (virtio_has_feature(vdev, VIRTIO_NET_F_CTRL_GUEST_OFFLOADS)) > + if (virtio_has_feature(vdev, VIRTIO_NET_F_CTRL_GUEST_OFFLOADS) && > + virtio_has_feature(vdev, VIRTIO_NET_F_CTRL_VQ)) > dev->hw_features |= NETIF_F_LRO; > > Based on this logic a little below in the same function > > if (virtio_has_feature(vdev, VIRTIO_NET_F_CTRL_VQ)) > vi->has_cvq = true; This would be a regression on old hypervisors which didn't have CTL VQ - suddenly they will lose offloads. -- MST