Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp5646334ybl; Sun, 22 Dec 2019 10:48:02 -0800 (PST) X-Google-Smtp-Source: APXvYqyGTaSjtDUtsZQnpN4fG11tTt3BeHBawvF1wy8jP3o1qM6t7lJEKIfuPk+uMkaBAk4+ucZm X-Received: by 2002:a05:6830:13d3:: with SMTP id e19mr18741751otq.135.1577040482510; Sun, 22 Dec 2019 10:48:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1577040482; cv=none; d=google.com; s=arc-20160816; b=RFX9er1rnDjgxgajsakXxbORDGsXc6RlALVs+PpuSEHErejHuLdxDLFGZpLgLargyn 9ciePZAV2/v2kA+9C6c3xFTu35cSA0IWw8eaIAvAyiV0z30VdYpaekfu6PayQaUGCAA/ FCru/2qjeM5T08cpitmYLIPBV9BEaJhQ+JlUeqxnNcfeTHimAPlmDHe1dNEGjmMM4rR5 HpfW5lYMpx4i5BO930SM3MOof6G1sPIOr4Ml/J03caiGP+dGuNvuLjwD0hhOGlKZjgS8 UcyL6Uwo+LedZW+icyMSw/Ar6IzF6iZj23rRNpPF94VC6aZKrvGyA0d/bjW3GI877Rtj ZF0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=lQN/KmgfOeiDptX5ags0bleZyx9JYpZ5dsx+WtdOnWQ=; b=EwAc+L3vZHcf3/nNu7aw0NwI/hc7/UtQa1pEPcDJb/+mmCwji9bDiThA3AC7oTOUQa H2CU2pNODTn1h8zAarFVuNhlt8Fw+oOiE/Pqaj1rK5kH01pMKQ2Oz94PlarUsSCVke2Y Xhq1jOw2VuU2+ToTyGzmjnIatxg3L04uQO+GMBAKkPYQc8WKr/0PsSux7GDaLESuyOVe /F8XZSIOBl6SKUu8VQHHJeCoaCkV31ogxE+YOj4sntKC75n9uFJlOZ9jsFxCIs/RX3Gv +LITwr8HGOxOegQy4qi0YzPBViovYhY8uzmMxQDa6ZeqACDePtaR3UAlBs7QoJvmBYqZ A1NQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t1si9149840otq.322.2019.12.22.10.47.50; Sun, 22 Dec 2019 10:48:02 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726604AbfLVSfZ (ORCPT + 99 others); Sun, 22 Dec 2019 13:35:25 -0500 Received: from jabberwock.ucw.cz ([46.255.230.98]:54804 "EHLO jabberwock.ucw.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725932AbfLVSfZ (ORCPT ); Sun, 22 Dec 2019 13:35:25 -0500 Received: by jabberwock.ucw.cz (Postfix, from userid 1017) id DBB8F1C2453; Sun, 22 Dec 2019 19:35:23 +0100 (CET) Date: Sun, 22 Dec 2019 19:35:23 +0100 From: Pavel Machek To: Dan Murphy Cc: jacek.anaszewski@gmail.com, linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v17 19/19] leds: lp55xx-common: Remove extern from lp55xx-common header Message-ID: <20191222183523.GH23369@amd> References: <20191114133023.32185-1-dmurphy@ti.com> <20191114133023.32185-20-dmurphy@ti.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="OpLPJvDmhXTZE4Lg" Content-Disposition: inline In-Reply-To: <20191114133023.32185-20-dmurphy@ti.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --OpLPJvDmhXTZE4Lg Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu 2019-11-14 07:30:23, Dan Murphy wrote: > extern is implied and is not needed in the common header file. > Remove the extern keyword and re-align the code. >=20 > Signed-off-by: Dan Murphy Lets not do this. Pavel --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --OpLPJvDmhXTZE4Lg Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAl3/t2oACgkQMOfwapXb+vK7ngCgplr/QI77DCpwzm2O/p8FCuRu YgIAoLJic74HVsOc+21FBN01/Lv0H+/K =uO9y -----END PGP SIGNATURE----- --OpLPJvDmhXTZE4Lg--