Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp5952137ybl; Sun, 22 Dec 2019 19:06:42 -0800 (PST) X-Google-Smtp-Source: APXvYqyDk7/AWGFFIhCrbwLUD4kRzeOc6stc3FUisOSK8QqqcIAXsIJaTRBOGkdF7eDvpMz0DkCP X-Received: by 2002:a9d:66c1:: with SMTP id t1mr27374344otm.73.1577070402126; Sun, 22 Dec 2019 19:06:42 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1577070402; cv=none; d=google.com; s=arc-20160816; b=KZgySTIza1KXqunxlJcQH3i1aiTXYS7a8S7lzF0znRk5E6Vijs1ndm2OOKzbbPmTnj xH4eXJlb9GuQ1zFts8bW64oH4sDckjjZZp603nDP3knzjyGGMeN4kD8DY0efC63eVe46 yZj8bBVQ289QEEMQiJXUNbm1pIN90jPpEM8FmGPpxraX4zixQn0UYFo3eiri4E1d/R1P IsSZtKB5K8Dj8rzPkWaQqc5RclsFaQA40WSrbvRDb7C++X0XNp8xsWSowHwL5QEe09YP W0ZpymVToyNO2HJQ7vxS3tAXQFW/l7h2Mi2JI2xDPkF0cAXXK9ZRn7ODeYOrcs8aKubI sBpw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:reply-to:message-id :subject:cc:to:from:date; bh=yA71nE/bY22+CvCs8cPlwbMAelNIz54wZebiuXRtoro=; b=pTZvX7qLyKO+yNUI4QlgjrViLqB55DdI8ll8MAB1u/TPICMrWW/+ytnjyxo8NfaZEU D+VR7xbOSQJMMznxWt1j2CcrR4AA83oN2PmQWepCztHwNSysMA8o61IMvvKxZNI9+PgA l6C+tl31uT6QtJInE4FgvNz2bO5GLjPXiRvsdQ/uH8yd7HtLrKpXXYZwWLXj+GRPfCFa Z4rqwK08ANwZmvV4di92BqzngFexeDkuVrcpj/GLHUOsT9RR9zLL+R76+Sr9sfyYkCRu rAqRdqKgLGiEaFoQ+l36g9Hm6/mxDK6z+G7YDa/tjjcanifGjMy0wn3qfr9kAwFuntGH ZPcw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b17si7543317otl.320.2019.12.22.19.06.31; Sun, 22 Dec 2019 19:06:42 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726826AbfLWDFl (ORCPT + 99 others); Sun, 22 Dec 2019 22:05:41 -0500 Received: from mga03.intel.com ([134.134.136.65]:43745 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726539AbfLWDFl (ORCPT ); Sun, 22 Dec 2019 22:05:41 -0500 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 Dec 2019 19:05:40 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,346,1571727600"; d="scan'208";a="249340513" Received: from richard.sh.intel.com (HELO localhost) ([10.239.159.54]) by fmsmga002.fm.intel.com with ESMTP; 22 Dec 2019 19:05:38 -0800 Date: Mon, 23 Dec 2019 11:05:38 +0800 From: Wei Yang To: Wei Yang Cc: akpm@linux-foundation.org, vbabka@suse.cz, kirill.shutemov@linux.intel.com, yang.shi@linux.alibaba.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [RESEND [PATCH] 0/2] mm/mmap.c: reduce subtree gap propagation a little Message-ID: <20191223030538.GA31929@richard> Reply-To: Wei Yang References: <20190828060614.19535-1-richardw.yang@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190828060614.19535-1-richardw.yang@linux.intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Any other comments for these two? On Wed, Aug 28, 2019 at 02:06:12PM +0800, Wei Yang wrote: >When insert and delete a vma, it will compute and propagate related subtree >gap. After some investigation, we can reduce subtree gap propagation a little. > >[1]: This one reduce the propagation by update *next* gap after itself, since > *next* must be a parent in this case. >[2]: This one achieve this by unlinking vma from list. > >After applying these two patches, test shows it reduce 0.3% function call for >vma_compute_subtree_gap. > >BTW, this series is based on some un-merged cleanup patched. > >--- >This version is rebased on current linus tree, whose last commit is >commit 9e8312f5e160 ("Merge tag 'nfs-for-5.3-3' of >git://git.linux-nfs.org/projects/trondmy/linux-nfs"). > >Wei Yang (2): > mm/mmap.c: update *next* gap after itself > mm/mmap.c: unlink vma before rb_erase > > mm/mmap.c | 15 ++++++++------- > 1 file changed, 8 insertions(+), 7 deletions(-) > >-- >2.17.1 -- Wei Yang Help you, Help me