Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp6119043ybl; Sun, 22 Dec 2019 23:53:54 -0800 (PST) X-Google-Smtp-Source: APXvYqwZ59tKY+JJodUWT63QiS8lB4vNarMoLnF2+9Zy8exBxbxtC1eyoXRMpdD/xZ9nTC0sylOe X-Received: by 2002:a9d:65cb:: with SMTP id z11mr12794679oth.348.1577087634379; Sun, 22 Dec 2019 23:53:54 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1577087634; cv=none; d=google.com; s=arc-20160816; b=RTEe9/QbVuSBrrian99Y7h1fUSg8l39Pbjw5MF9Gl2S+89R6GpG4zLsGi/HKb45snd RbcW4r1zxzf8Sf/X+spYH00/3JFTMiCwj+BhEy5/PqOdTB3ETnGd0xShTLXREfRy13Yo qkFcR6GSItpaYt4l7cf0zXRZip/dd3pmwEdWUm/kjLy81JM53PErCx8BCkr9eB1Gm1iG jwGYGERkhcScXRsVwP4i+rA0YCH3nwCFwIv/SiAlWWsi0tLKlGY3Ul08ocsreKmFPPZ6 9q3bwzHj5foWmSJRxpKLmyupQJFbYyTzvkEsN3R8SktUa67ROaCZNYieHuApETuqQQzo H+bQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=6MOCyM7tp/74PToOqk7pZBD3H2wMMyABHMcKP28CHcY=; b=tK1Vej6D/VUGi9wIW8s0NzKY9nOZhyv0b4VjdhJCB4l+mq/m5WirNnN93iLbTQkuvE YfFf4kf+Lt6uBVWYjD+ixMcLM5SbJRCqSZ0HZn9snvoIKDh/dWhFvwnSwFQiG4fi3qL3 TGScUdbY8ZEFYexf0J45MiMsnV/dpucdsRYLMoK32SFn2it/Dmy/JgyXA7GLAIc/6Tdn 0/EkMszJ8ogkT0d2s4rqK3xKL3fHCHYsPCws+s3EtSJ4mefMwVQIPKwKl9FdevlFH1Ng 2Kk10kkbrrdfJF9C3ele+MlYsiA19zB7uFZ3YEP0moYqolteLBJ8CBXSLafjKgqlwUH/ jVJA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="z/LPLi/3"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h3si9896759otq.203.2019.12.22.23.53.41; Sun, 22 Dec 2019 23:53:54 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="z/LPLi/3"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726007AbfLWHxD (ORCPT + 99 others); Mon, 23 Dec 2019 02:53:03 -0500 Received: from mail.kernel.org ([198.145.29.99]:57458 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725810AbfLWHxC (ORCPT ); Mon, 23 Dec 2019 02:53:02 -0500 Received: from localhost (unknown [223.226.34.186]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3D7CC206B7; Mon, 23 Dec 2019 07:53:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1577087582; bh=ZDywtafLELZOwgunZ6njALEVERK9QcJfzVci1TRYhoU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=z/LPLi/3mzqScE76JGG4kOKYc70pK5CJ4RsAsaf7vCGWfEYTnR8iJWGDI4XONa2mE GGsNvwizK/gTgbi9ks+Kt1fbXImJdcj2yA+4oBsOuHN0nWtLIHUY8tpCUwJc7bwpVU znUp8cZYhmIzh2OZM2/x/gK3VVXnj1Q0nR4EDcX4= Date: Mon, 23 Dec 2019 13:22:57 +0530 From: Vinod Koul To: Peter Ujfalusi Cc: dan.j.williams@intel.com, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, alexandru.ardelean@analog.com, s.hauer@pengutronix.de Subject: Re: [PATCH] dmaengine: virt-dma: Fix access after free in vcna_complete() Message-ID: <20191223075257.GD2536@vkoul-mobl> References: <20191220131100.21804-1-peter.ujfalusi@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191220131100.21804-1-peter.ujfalusi@ti.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 20-12-19, 15:11, Peter Ujfalusi wrote: > vchan_vdesc_fini() is freeing up 'vd' so the access to vd->tx_result is > via already freed up memory. > > Move the vchan_vdesc_fini() after invoking the callback to avoid this. Applied, thanks -- ~Vinod