Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
IronPort-SDR: /Dd/5G8ZixAieCds/iB8OgiPPmpLnPoT53Bshk5N6ryAfgDbGZlf2u6yV15CF34b3zVpGLYLBl
 kRqJZxupg+ms+FYn6TgHkUUocajU0F/VeuCYvJymqvnOwWSbunQq2v3f7IRufVBUHhyfSPqHMj
 zTBNJZjvpRr+minHn9RjqMXUlnLtbsGqiBzMZx+x6EV6fF8X93pQGAxf+LJ5uk0+1A53S0u0ej
 BU5H/qilPHwNCqKWSLGHPRRQ3p6syEnJxQg8PK1qGc/WcT2hqyXTgXqJPpyu79MsXAMcQjEjmW
 X9k=
Subject: Re: [PATCH 1/2] ARM: dts: tegra20: add labels to i2c nodes
To:     Dmitry Osipenko <digetx@gmail.com>, <robh+dt@kernel.org>,
        <mark.rutland@arm.com>, <thierry.reding@gmail.com>,
        <jonathanh@nvidia.com>
CC:     <devicetree@vger.kernel.org>, <linux-tegra@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
References: <20191219130431.30458-1-richard.leitner@skidata.com>
 <01ac756c-1e51-5d62-ca45-9e0b4f106a29@gmail.com>
From:   Richard Leitner <richard.leitner@skidata.com>
Message-ID: <27d4c933-8117-f38e-d4da-e58326fc6ee4@skidata.com>
Date:   Mon, 23 Dec 2019 08:46:02 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.2.2
MIME-Version: 1.0
In-Reply-To: <01ac756c-1e51-5d62-ca45-9e0b4f106a29@gmail.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi,
thanks for the reply.

On 20/12/2019 15:00, Dmitry Osipenko wrote:
> 19.12.2019 16:04, Richard Leitner пишет:
>> Add numbered labels to the i2c nodes of the Tegra20 SoC so we just need
>> to alias it from derived boards.
>>
>> Signed-off-by: Richard Leitner <richard.leitner@skidata.com>
>> ---
>>   arch/arm/boot/dts/tegra20.dtsi | 6 +++---
>>   1 file changed, 3 insertions(+), 3 deletions(-)

...

> 
> Hello Richard,
> 
> Why derived boards couldn't label nodes by themselves? That's what all
> derived boards are doing already.

Of course they can, but IMHO its more useful to have the same labels for
all derived boards.

> 
> BTW, upstream should benefit from the submitted changes. This is not a
> very useful change for upstream if you're not updating the actual DTs of
> any of the boards in arch/arm/boot/dts/*.

That's true. I thought of also patching the actual DTs but wasn't sure
if that should be in the same series...
Based on your answer I guess it should be.

Therefore I'll send a v2 soon.

Thanks again & regards;richard.l