Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] usb: cdns3: gadget: Remove unneeded variable ret
To:     Xu Wang <vulab@iscas.ac.cn>, <gregkh@linuxfoundation.org>
CC:     <pawell@cadence.com>, <balbi@kernel.org>, <peter.chen@nxp.com>,
        <colin.king@canonical.com>, <linux-usb@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
References: <1576826378-4387-1-git-send-email-vulab@iscas.ac.cn>
From:   Roger Quadros <rogerq@ti.com>
Message-ID: <890bc22f-9f03-f4c3-9fdc-7afe4c7321ff@ti.com>
Date:   Mon, 23 Dec 2019 10:53:54 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.2.1
MIME-Version: 1.0
In-Reply-To: <1576826378-4387-1-git-send-email-vulab@iscas.ac.cn>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 20/12/2019 09:19, Xu Wang wrote:
> Remove unneeded variable ret used to store return value,just return 0.
> 
> Signed-off-by: Xu Wang <vulab@iscas.ac.cn>

Acked-by: Roger Quadros <rogerq@ti.com>

> ---
>   drivers/usb/cdns3/gadget.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/usb/cdns3/gadget.c b/drivers/usb/cdns3/gadget.c
> index 4c1e755..73b75a3 100644
> --- a/drivers/usb/cdns3/gadget.c
> +++ b/drivers/usb/cdns3/gadget.c
> @@ -2389,7 +2389,6 @@ static int cdns3_gadget_udc_stop(struct usb_gadget *gadget)
>   	struct cdns3_endpoint *priv_ep;
>   	u32 bEndpointAddress;
>   	struct usb_ep *ep;
> -	int ret = 0;
>   	int val;
>   
>   	priv_dev->gadget_driver = NULL;
> @@ -2413,7 +2412,7 @@ static int cdns3_gadget_udc_stop(struct usb_gadget *gadget)
>   	writel(0, &priv_dev->regs->usb_ien);
>   	writel(USB_CONF_DEVDS, &priv_dev->regs->usb_conf);
>   
> -	return ret;
> +	return 0;
>   }
>   
>   static const struct usb_gadget_ops cdns3_gadget_ops = {
> 

-- 
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki