Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Date:   Mon, 23 Dec 2019 16:21:34 +0530
From:   sthella@codeaurora.org
To:     Bjorn Andersson <bjorn.andersson@linaro.org>
Cc:     srinivas.kandagatla@linaro.org, agross@kernel.org,
        linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH] nvmem: add QTI SDAM driver
In-Reply-To: <20191220002929.GJ448416@yoga>
References: <1576574432-9649-1-git-send-email-sthella@codeaurora.org>
 <20191218061400.GV3143381@builder>
 <17c718c483db710b32b2dbbcf4637783@codeaurora.org>
 <20191220002929.GJ448416@yoga>
Message-ID: <9d1cd4bdf63fd2ad980554e913c5741a@codeaurora.org>
User-Agent: Roundcube Webmail/1.3.9
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 2019-12-20 05:59, Bjorn Andersson wrote:
> On Thu 19 Dec 02:29 PST 2019, sthella@codeaurora.org wrote:
> 
>> On 2019-12-18 11:44, Bjorn Andersson wrote:
>> > On Tue 17 Dec 01:20 PST 2019, Shyam Kumar Thella wrote:
> [..]
>> > > +subsys_initcall(sdam_init);
>> >
>> > module_platform_driver(sdam_driver), unless you have some strong
>> > arguments for why this needs to be subsys_initcall
>> There are some critical sybsystems which depend on nvmem data. So I 
>> would
>> prefer using subsys_initcall().
> 
> How critical? Needed to kernel module loading?
> 
> Can you please document this need somehow? (either a comment here or
> something in the commit message). Be specific.
Sure. I will add the need in commit message in its next patch.
> 
> THanks,
> Bjorn