Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Received-SPF: Pass (protection.outlook.com: domain of arm.com designates
 63.35.35.123 as permitted sender) receiver=protection.outlook.com;
 client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com;
From:   Mihail Atanassov <Mihail.Atanassov@arm.com>
To:     james qian wang <james.qian.wang@arm.com>
CC:     nd <nd@arm.com>, Jonathan Chai <Jonathan.Chai@arm.com>,
        Lowry Li <Lowry.Li@arm.com>, Tiannan Zhu <Tiannan.Zhu@arm.com>,
        nd <nd@arm.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>,
        Ben Davis <Ben.Davis@arm.com>,
        Oscar Zhang <Oscar.Zhang@arm.com>,
        Channing Chen <Channing.Chen@arm.com>,
        james qian wang <james.qian.wang@arm.com>
Subject: Re: [PATCH] drm/komeda: Add event handling for EMPTY/FULL
Thread-Topic: [PATCH] drm/komeda: Add event handling for EMPTY/FULL
Thread-Index: AQHVsL2rU4ctbxXpak2vHcPGkTYTb6fHm3SA
Date:   Mon, 23 Dec 2019 13:02:15 +0000
Message-ID: <9392127.Ov6ziQ9xEP@e123338-lin>
References: <20191212072737.30116-1-james.qian.wang@arm.com>
In-Reply-To: <20191212072737.30116-1-james.qian.wang@arm.com>
Accept-Language: en-GB, en-US
Content-Language: en-US
Authentication-Results-Original: spf=none (sender IP is )
 smtp.mailfrom=Mihail.Atanassov@arm.com; 
x-ms-exchange-messagesentrepresentingtype: 1
x-ms-publictraffictype: Email
X-MS-Office365-Filtering-HT: Tenant
X-MS-Office365-Filtering-Correlation-Id: 3fc38298-2415-4977-8936-08d787a85a57
X-MS-TrafficTypeDiagnostic: VI1PR08MB3760:|VI1PR08MB3760:|DB6PR0801MB1669:
x-ms-exchange-transport-forked: True
X-Microsoft-Antispam-PRVS: <DB6PR0801MB1669338E3169AB73AB23DC6E8F2E0@DB6PR0801MB1669.eurprd08.prod.outlook.com>
x-checkrecipientrouted: true
x-ms-oob-tlc-oobclassifiers: OLM:8882;OLM:8882;
x-forefront-prvs: 0260457E99
X-Forefront-Antispam-Report-Untrusted: SFV:NSPM;SFS:(10009020)(7916004)(4636009)(396003)(376002)(39860400002)(346002)(366004)(136003)(51914003)(189003)(199004)(478600001)(81166006)(8676002)(2906002)(6512007)(9686003)(8936002)(316002)(4326008)(54906003)(6506007)(81156014)(6862004)(33716001)(6486002)(6636002)(86362001)(52116002)(186003)(5660300002)(66946007)(64756008)(66476007)(66446008)(71200400001)(26005)(66556008)(39026012);DIR:OUT;SFP:1101;SCL:1;SRVR:VI1PR08MB3760;H:VI1PR08MB4078.eurprd08.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1;
received-spf: None (protection.outlook.com: arm.com does not designate
 permitted sender hosts)
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam-Untrusted: BCL:0;
X-Microsoft-Antispam-Message-Info-Original: J02n6PYUkllv2QqiZq+wBcEzyzq5Ec58+wkVeUTx23mSopYZq3XWswy7hvxKomlSQ77hkXU10VlTjGqxdIzwDsP0JvAcQa9Gr+B2P/IQ7rIcDCbQHmR/wLnqpk1eyVTQxeMap7vfCNcR/hY7E0O40u666On2wqIO/6vtBLrLtCP89lfq5Ya/XbmQd6A7pCe0IpQ7ovOzoAfinKbGyWp0wtcDPxO8D5Yy1Rt8g7bl9IOnVMDraom/rupaWNmnR/kUQmXXh2LfRBpxKsAYpQDLSnx5t/99AKoJl2Xjr99oechu7CgyDK4y2JjdnusM8KcDj/UJx0QujgLDxLwOpYC7E16Fp0AlQW23InfkdJfBQAV0EGjUfhZOzmMDvtNu8X6o2/hNdu4OCitIdoDmdpG50VCMXQEj4m5q1sM8mOifT5THoJspJT4+VbOeVlGyZsgE9nBYCUHQvR0jbX6QL3c1ibS1buER+Hze9r7ugKQgIyFpoaZzqhMDb6Qlafy+q1SLKhnBETZ3uedfrYnZUhEHig==
Content-Type: text/plain; charset="us-ascii"
Content-ID: <08FF363DBD80ED40A7E6D6EB3E338690@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR08MB3760
Original-Authentication-Results: spf=none (sender IP is )
 smtp.mailfrom=Mihail.Atanassov@arm.com; 
X-EOPAttributedMessage: 0
X-MS-Exchange-Transport-CrossTenantHeadersStripped: VE1EUR03FT049.eop-EUR03.prod.protection.outlook.com
X-Forefront-Antispam-Report: CIP:63.35.35.123;IPV:CAL;SCL:-1;CTRY:IE;EFV:NLI;SFV:NSPM;SFS:(10009020)(7916004)(4636009)(136003)(396003)(376002)(346002)(39860400002)(51914003)(189003)(199004)(6862004)(5660300002)(4326008)(356004)(36906005)(86362001)(54906003)(316002)(6486002)(6636002)(33716001)(8676002)(70206006)(478600001)(81166006)(70586007)(6512007)(336012)(186003)(6506007)(8936002)(9686003)(81156014)(26005)(2906002)(26826003)(76130400001)(39026012);DIR:OUT;SFP:1101;SCL:1;SRVR:DB6PR0801MB1669;H:64aa7808-outbound-1.mta.getcheckrecipient.com;FPR:;SPF:Pass;LANG:en;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;MX:1;A:1;
X-MS-Office365-Filtering-Correlation-Id-Prvs: 4bd6488b-c97a-44e7-8bc1-08d787a85540
NoDisclaimer: True
X-Forefront-PRVS: 0260457E99
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: aVQ0zBlhwLH2N5ZdqpYtgNmml/3fWitwsbBdQkSSSrW571hKNHI1NKQs903cTmYh3+3QhhUXp4/+QdyNnR4Hab2UeCYdP7tER19IaP8QeaaM2DvjmqMs4P045hzih9txPD7bYuHKw7TSWpXeNtbkq8WZLQc7cuq5kqmUIX5yamE+dITsIiEzd6TRcvWZnLjPg4pLc9c39mudElRT2LxT2le2L+QdKxvNJk2i5DbOBLGFEh51GgqVEsHrHh1bou7wGlizWCbAsmPXEAJLK6HB8JhixebQr99Gppchwh6K6zK9xfNnKOUZPgdmO4XWCQ/ailwyf8wxAkNH2QunpqbmPiPUvajlU/k81FTuSVOlvTz60FTCgu7+/NjBW4/0RGO81vKX9c6OAi6f22Xx9yn/pzTs8Gu7c/Ypho2ma78J0BMEyHAM8EPgC4XWK96icv//IobezGttVPjLAPpy9pYl1Sovtv/I1nZ49AhImzzrTfW6PMWPJPfhNds5DkMRPGXwHoto5OhGKMEjnAttm8/7og==
X-OriginatorOrg: arm.com
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Dec 2019 13:02:23.5075
 (UTC)
X-MS-Exchange-CrossTenant-Network-Message-Id: 3fc38298-2415-4977-8936-08d787a85a57
X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com]
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0801MB1669
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi James,

On Thursday, 12 December 2019 07:27:55 GMT james qian wang (Arm Technology =
China) wrote:
> EMPTY/FULL are HW input/output FIFO condition identifer, which are
> useful information for addressing the problem, so expose them.
>=20
> Signed-off-by: james qian wang (Arm Technology China) <james.qian.wang@ar=
m.com>
> ---
>  drivers/gpu/drm/arm/display/komeda/d71/d71_dev.c  | 13 ++++++++++++-
>  drivers/gpu/drm/arm/display/komeda/d71/d71_regs.h |  3 +++
>  drivers/gpu/drm/arm/display/komeda/komeda_dev.h   |  5 ++++-
>  drivers/gpu/drm/arm/display/komeda/komeda_event.c |  2 ++
>  4 files changed, 21 insertions(+), 2 deletions(-)
>=20
> diff --git a/drivers/gpu/drm/arm/display/komeda/d71/d71_dev.c b/drivers/g=
pu/drm/arm/display/komeda/d71/d71_dev.c
> index dd1ecf4276d3..00fa56c29b3e 100644
> --- a/drivers/gpu/drm/arm/display/komeda/d71/d71_dev.c
> +++ b/drivers/gpu/drm/arm/display/komeda/d71/d71_dev.c
> @@ -20,8 +20,10 @@ static u64 get_lpu_event(struct d71_pipeline *d71_pipe=
line)
>  		evts |=3D KOMEDA_EVENT_IBSY;
>  	if (raw_status & LPU_IRQ_EOW)
>  		evts |=3D KOMEDA_EVENT_EOW;
> +	if (raw_status & LPU_IRQ_OVR)
> +		evts |=3D KOMEDA_EVENT_OVR;
> =20
> -	if (raw_status & (LPU_IRQ_ERR | LPU_IRQ_IBSY)) {
> +	if (raw_status & (LPU_IRQ_ERR | LPU_IRQ_IBSY | LPU_IRQ_OVR)) {
>  		u32 restore =3D 0, tbu_status;
>  		/* Check error of LPU status */
>  		status =3D malidp_read32(reg, BLK_STATUS);
> @@ -45,6 +47,15 @@ static u64 get_lpu_event(struct d71_pipeline *d71_pipe=
line)
>  			restore |=3D LPU_STATUS_ACE3;
>  			evts |=3D KOMEDA_ERR_ACE3;
>  		}
> +		if (status & LPU_STATUS_FEMPTY) {
> +			restore |=3D LPU_STATUS_FEMPTY;
> +			evts |=3D KOMEDA_EVENT_EMPTY;
> +		}
> +		if (status & LPU_STATUS_FFULL) {
> +			restore |=3D LPU_STATUS_FFULL;
> +			evts |=3D KOMEDA_EVENT_FULL;
> +		}
> +
>  		if (restore !=3D 0)
>  			malidp_write32_mask(reg, BLK_STATUS, restore, 0);
> =20
> diff --git a/drivers/gpu/drm/arm/display/komeda/d71/d71_regs.h b/drivers/=
gpu/drm/arm/display/komeda/d71/d71_regs.h
> index 81de6a23e7f3..e80172a0b320 100644
> --- a/drivers/gpu/drm/arm/display/komeda/d71/d71_regs.h
> +++ b/drivers/gpu/drm/arm/display/komeda/d71/d71_regs.h
> @@ -175,6 +175,7 @@
>  #define TBU_DOUTSTDCAPB_MASK	0x3F
> =20
>  /* LPU_IRQ_BITS */
> +#define LPU_IRQ_OVR		BIT(9)
>  #define LPU_IRQ_IBSY		BIT(10)
>  #define LPU_IRQ_ERR		BIT(11)
>  #define LPU_IRQ_EOW		BIT(12)
> @@ -185,6 +186,8 @@
>  #define LPU_STATUS_AXIE		BIT(4)
>  #define LPU_STATUS_AXIRP	BIT(5)
>  #define LPU_STATUS_AXIWP	BIT(6)
> +#define LPU_STATUS_FEMPTY	BIT(11)
> +#define LPU_STATUS_FFULL	BIT(14)
>  #define LPU_STATUS_ACE0		BIT(16)
>  #define LPU_STATUS_ACE1		BIT(17)
>  #define LPU_STATUS_ACE2		BIT(18)
> diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_dev.h b/drivers/gp=
u/drm/arm/display/komeda/komeda_dev.h
> index 4a67a80d5fcf..ce27f2f27c24 100644
> --- a/drivers/gpu/drm/arm/display/komeda/komeda_dev.h
> +++ b/drivers/gpu/drm/arm/display/komeda/komeda_dev.h
> @@ -20,6 +20,8 @@
>  #define KOMEDA_EVENT_OVR		BIT_ULL(4)
>  #define KOMEDA_EVENT_EOW		BIT_ULL(5)
>  #define KOMEDA_EVENT_MODE		BIT_ULL(6)
> +#define KOMEDA_EVENT_FULL		BIT_ULL(7)
> +#define KOMEDA_EVENT_EMPTY		BIT_ULL(8)
> =20
>  #define KOMEDA_ERR_TETO			BIT_ULL(14)
>  #define KOMEDA_ERR_TEMR			BIT_ULL(15)
> @@ -49,7 +51,8 @@
>  	KOMEDA_ERR_ZME		| KOMEDA_ERR_MERR	| KOMEDA_ERR_TCF |\
>  	KOMEDA_ERR_TTNG		| KOMEDA_ERR_TTF)
> =20
> -#define KOMEDA_WARN_EVENTS	KOMEDA_ERR_CSCE
> +#define KOMEDA_WARN_EVENTS	\
> +	(KOMEDA_ERR_CSCE | KOMEDA_EVENT_FULL | KOMEDA_EVENT_EMPTY)
> =20
>  #define KOMEDA_INFO_EVENTS (0 \
>  			    | KOMEDA_EVENT_VSYNC \
> diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_event.c b/drivers/=
gpu/drm/arm/display/komeda/komeda_event.c
> index 977c38d516da..53f944e66dfc 100644
> --- a/drivers/gpu/drm/arm/display/komeda/komeda_event.c
> +++ b/drivers/gpu/drm/arm/display/komeda/komeda_event.c
> @@ -78,6 +78,8 @@ static void evt_str(struct komeda_str *str, u64 events)
> =20
>  	/* LPU errors or events */
>  	evt_sprintf(str, events & KOMEDA_EVENT_IBSY, "IBSY|");
> +	evt_sprintf(str, events & KOMEDA_EVENT_EMPTY, "EMPTY|");
> +	evt_sprintf(str, events & KOMEDA_EVENT_FULL, "FULL|");
>  	evt_sprintf(str, events & KOMEDA_ERR_AXIE, "AXIE|");
>  	evt_sprintf(str, events & KOMEDA_ERR_ACE0, "ACE0|");
>  	evt_sprintf(str, events & KOMEDA_ERR_ACE1, "ACE1|");
>=20

Thanks for the patch,

Reviewed-by: Mihail Atanassov <mihail.atanassov@arm.com>

--=20
Mihail