Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [RFC PATCH] io-wq: kill cpu hog worker
To:     Hillf Danton <hdanton@sina.com>, io-uring@vger.kernel.org
Cc:     viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-mm <linux-mm@kvack.org>
References: <20191223024145.11580-1-hdanton@sina.com>
From:   Jens Axboe <axboe@kernel.dk>
Message-ID: <ae2945f0-c3ff-7d78-4947-f87c3026100e@kernel.dk>
Date:   Mon, 23 Dec 2019 08:15:00 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.2.2
MIME-Version: 1.0
In-Reply-To: <20191223024145.11580-1-hdanton@sina.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 12/22/19 7:41 PM, Hillf Danton wrote:
> 
> Reschedule the current IO worker if it is becoming a cpu hog.

Might make more sense to put this a bit earlier, to avoid the
awkward lock juggle. In theory it shouldn't make a difference
if we do it _before_ doing new work, or _after_ doing work. We
should only be rescheduling if it's running for quite a while.

How about putting it after the flushing of signals instead?

-- 
Jens Axboe