Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp7093631ybl; Mon, 23 Dec 2019 18:08:40 -0800 (PST) X-Google-Smtp-Source: APXvYqz2rvrHQAzguR1/Fxkf4COG73mejjUeuxGoXJJZop9i4Hg6U65GCi7Oy5egKeZr60va2Za1 X-Received: by 2002:a9d:768b:: with SMTP id j11mr35720990otl.116.1577153320815; Mon, 23 Dec 2019 18:08:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1577153320; cv=none; d=google.com; s=arc-20160816; b=KESv3/GQ0x6OHfBoOzamfwMkvUKoYipSL7R86fJHkFLHw+XuSP0kkOpw73LVsdc5nf MveNRlmjnANfywtNd88QpUwLZ/k3XvCMgwDL3LBGJKgvzj5TPSR7k1axGHLyO6IhBCyT w2xCee8XeBXKLc83s724zjHotZbYalW3snyN3A99H3DSaz2YMPNZUJHctwdMPFU7R7Je Xmr2eEsCofHeNXCxNFG4KwNvK8jAD05f68lw4nYUSh4ZneioBzZx7etqfxpWH4cc8COs nPfcQEHpuNCcykA2UUt2mlM+mCk++alGicDg9fqEshsuQqVhi5Z4UnHwB6IRbnT8RP5J /AwA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=HId726PpNcYYRC95wuryNxsC7cJtS5k6cb4OpB7cQnA=; b=Um959c7ckB6Ny2SYiw/+JpJzF6q5c93PLyTVyZGI49Y7gFDBMRj9jJUs67S54ORRew H0RyZDKXH/IawdCerv9FmiGwZz6qwcIZNnYgM5gXjPigZ2LfBKy0VH1aKRecN4v+S5I1 XWsH3pZWTINn8MnaHFJxkYrfpoSGPwu6giO0Y1u+NJuegts6+ySaKqBXhtzBzWG5XPkD sWs6tGxDg2e5Z//mtkZ0G7r+nhJ2IDmgIZ3ygeW0NGnOQdT09obx17NrlqtBRPs8yywy Metv1S35g+FHoYNEdBxtlI6s8F1KrBk+L6BjwbhH21OGkZ4roY88hW9TQgi11tgCfSIW g0Xw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=E6kVU9g2; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w1si9258681oia.169.2019.12.23.18.08.27; Mon, 23 Dec 2019 18:08:40 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=E6kVU9g2; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727102AbfLXCHp (ORCPT + 99 others); Mon, 23 Dec 2019 21:07:45 -0500 Received: from mail.kernel.org ([198.145.29.99]:46946 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726997AbfLXCHp (ORCPT ); Mon, 23 Dec 2019 21:07:45 -0500 Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5119321927 for ; Tue, 24 Dec 2019 02:07:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1577153264; bh=nuWZ8yhnitZpPr2h+5PU5xzGudc3XC10lX5Ec91GR+s=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=E6kVU9g202rFhym4tXVVBYm1fF7zrf4imuKY1UsLFAoqO0HfSsUASADU8FpcnUTFX au8dQB0MMEwRaITZ7AkOA+CdDJ26kZ865Lo1+fULgI1ZCLw1Y/TN1ZP2AMm5x/siU4 pk8YakrCG+Ck+yePKWOcsbZyKUUeS+p1lIRxmwIs= Received: by mail-wr1-f49.google.com with SMTP id q6so18560544wro.9 for ; Mon, 23 Dec 2019 18:07:44 -0800 (PST) X-Gm-Message-State: APjAAAV6j1fZcEc/TcvetFzIWFa/n4tWiLL06/VFS4gD7yMzy493paPm b4yWSZOhAGDEPES0TVqsBpVZplFFu/kX7ok/6/CRcg== X-Received: by 2002:adf:eb09:: with SMTP id s9mr34073707wrn.61.1577153262733; Mon, 23 Dec 2019 18:07:42 -0800 (PST) MIME-Version: 1.0 References: <47701b5fb73cf536db074031db8e6e3fa3695168.1577111365.git.christophe.leroy@c-s.fr> In-Reply-To: <47701b5fb73cf536db074031db8e6e3fa3695168.1577111365.git.christophe.leroy@c-s.fr> From: Andy Lutomirski Date: Mon, 23 Dec 2019 18:07:30 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [RFC PATCH v2 01/10] lib: vdso: ensure all arches have 32bit fallback To: Christophe Leroy Cc: Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Arnd Bergmann , Thomas Gleixner , Vincenzo Frascino , Andrew Lutomirski , LKML , linuxppc-dev , linux-arm-kernel , "open list:MIPS" , X86 ML Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 23, 2019 at 6:31 AM Christophe Leroy wrote: > > In order to simplify next step which moves fallback call at arch > level, ensure all arches have a 32bit fallback instead of handling > the lack of 32bit fallback in the common code based > on VDSO_HAS_32BIT_FALLBACK I don't like this. You've implemented what appear to be nonsensical fallbacks (the 32-bit fallback for a 64-bit vDSO build? There's no such thing). How exactly does this simplify patch 2? --Andy