Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp7177167ybl; Mon, 23 Dec 2019 20:17:44 -0800 (PST) X-Google-Smtp-Source: APXvYqwdajiszqITbUHmlorCeHmXpqEPpOGwthIMxZO0znRHkWkbGF4fx57OOguXUfEkKbw1I/Yn X-Received: by 2002:a05:6830:4b9:: with SMTP id l25mr37443625otd.266.1577161063870; Mon, 23 Dec 2019 20:17:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1577161063; cv=none; d=google.com; s=arc-20160816; b=SNAlsrHzSKUmlrLC/Y8wOEdgbUir7wYhBXUvsWGVklljsDe3ib5Ct9M6CWaABVP9TD z2n8E/ErTw8fj5GRScswKB2fJPoX8GaB16rDSeEn6r1nIQdPmdG/gP05K80Y8Ko2HAk9 gB6qUq5uHvlay2dsXNy+cmsEgXCEdYkK8IzT0TSBpJwZK0/ZdwmMldoTsssuVa8P2+IG VIZEtCbLzzOrDM6S5430ed7g1DxUjCf+JeUagkVSOMTZcSTTr8eNq+uKBYoCMwyph+tx XqRs1dN/ln/MJqChdayYs4WAFcGNsNpo1IhB6gTbVVas/tovCgMfceTZ3Ts2Xy+uBhfJ Tx1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:from:references:cc:to:subject:dkim-signature; bh=TJ71qsrHkOwyDS6wJPPpVKyLH1gnQyBIMJypk8M5lmo=; b=PY2JVNVvtT09ZOIG67UObvaJYrs8oI1TJb9Y4vExSDMwlK4aBppeGvHP4tAqd7+Vb/ VT+/O3cFvfyWnIR11K+eQeNupXs/Y7Rx6sZwPuT/6adwdrO7LkbW8XbbE2O0MhvlGxm7 a36bsm3ZdkmjnixlAmKw0Dn1eXnNuZ/qrx+XfwlMJBjn1Tm/9z8w/SO3LdcrjI1MXiHl LD1GoPettL3azQdrDOFCc/Ve7kk4oMzLk2JIxaDNTw+ptx0eCh0OpfasA1d8pdqoXHA8 hpNJnC4RIiniffuSfOBCkPi6LxoTPk4ConbyjyOZ+JfK/7zmSXsmBJbnLsrcXjI7zonA 5Cnw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=rnJzMUnS; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f9si11477649otp.111.2019.12.23.20.17.32; Mon, 23 Dec 2019 20:17:43 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=rnJzMUnS; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726910AbfLXEQ6 (ORCPT + 99 others); Mon, 23 Dec 2019 23:16:58 -0500 Received: from mail-pj1-f68.google.com ([209.85.216.68]:53226 "EHLO mail-pj1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726866AbfLXEQ6 (ORCPT ); Mon, 23 Dec 2019 23:16:58 -0500 Received: by mail-pj1-f68.google.com with SMTP id a6so661008pjh.2; Mon, 23 Dec 2019 20:16:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:autocrypt:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=TJ71qsrHkOwyDS6wJPPpVKyLH1gnQyBIMJypk8M5lmo=; b=rnJzMUnSlasxHv03A8kW01I8C+yidstsfhIi1CXLYJkcJd5HtmfsE5ehTavDUaCCqO 64V9ouEdgeAukgCF7JI4cRMNbuSj+98RGPStIevX/et37I0Cze7frb/4v7fhIqrABI8E C96xtM7zvnANKbR0ECFZbgnT3zQV2zAuJ0YqP+iAq+cgJOppBdYmqCI7JEOqkETSKAT2 iT6PdlmjBmDquWx5N9Pgust12P4xZlgElFa0xQG4no9SyRhalgKDzDPkYY21XTsawy7O jpcSxB9YfwrX+h+K+pwota8H/gZyYOHXfetFRDBCKXRKAWtop9vQgJgNSpU5zKr4Kwpw +LkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=TJ71qsrHkOwyDS6wJPPpVKyLH1gnQyBIMJypk8M5lmo=; b=gYURAVbrAfyF65AFEC2PuH+ky5gGREoi5FQkbiWpE0YwEcZltFBIlAdZvKequr2f3J 1/V+MOiLsYkxzxStn5FGnOCPBC3bJ0tuuO7a1yXjU6ybbG0ONefAmiFgJlsSN9DvqYtA o8hH6Wr3J5LaS0/j/udOR62TQmQP4NkNwbPyOmsERTEZ5paF51ptiApVYEtnnyis2uS1 UNcq2RVRNAi4hUABLrsKOlC0QCIDbjIl7NRmGDK8AEd8HZyTarm+dXKbzVgXYpjmm9oU KO2WJ7wax5eRMWH6hc9gAqYlTDUEnG10y1T6/HkqY+2vAPc1ObjFgPTXzHNIqPriGw+O FznQ== X-Gm-Message-State: APjAAAUTOcAl84j7xHQeGpRqNsXTC66GD9bmm02bwj3ktxv/f1XJczQ6 ns3x4jJQMGprOw8nHmvVGL7cxDXr X-Received: by 2002:a17:902:8bc5:: with SMTP id r5mr34874328plo.189.1577161017292; Mon, 23 Dec 2019 20:16:57 -0800 (PST) Received: from [192.168.1.3] (ip68-111-84-250.oc.oc.cox.net. [68.111.84.250]) by smtp.gmail.com with ESMTPSA id y62sm26858514pfg.45.2019.12.23.20.16.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 23 Dec 2019 20:16:56 -0800 (PST) Subject: Re: [PATCH net-next v8 04/14] ethtool: support for netlink notifications To: Michal Kubecek , David Miller , netdev@vger.kernel.org Cc: Jakub Kicinski , Jiri Pirko , Andrew Lunn , John Linville , Stephen Hemminger , Johannes Berg , linux-kernel@vger.kernel.org References: From: Florian Fainelli Autocrypt: addr=f.fainelli@gmail.com; keydata= mQGiBEjPuBIRBACW9MxSJU9fvEOCTnRNqG/13rAGsj+vJqontvoDSNxRgmafP8d3nesnqPyR xGlkaOSDuu09rxuW+69Y2f1TzjFuGpBk4ysWOR85O2Nx8AJ6fYGCoeTbovrNlGT1M9obSFGQ X3IzRnWoqlfudjTO5TKoqkbOgpYqIo5n1QbEjCCwCwCg3DOH/4ug2AUUlcIT9/l3pGvoRJ0E AICDzi3l7pmC5IWn2n1mvP5247urtHFs/uusE827DDj3K8Upn2vYiOFMBhGsxAk6YKV6IP0d ZdWX6fqkJJlu9cSDvWtO1hXeHIfQIE/xcqvlRH783KrihLcsmnBqOiS6rJDO2x1eAgC8meAX SAgsrBhcgGl2Rl5gh/jkeA5ykwbxA/9u1eEuL70Qzt5APJmqVXR+kWvrqdBVPoUNy/tQ8mYc nzJJ63ng3tHhnwHXZOu8hL4nqwlYHRa9eeglXYhBqja4ZvIvCEqSmEukfivk+DlIgVoOAJbh qIWgvr3SIEuR6ayY3f5j0f2ejUMYlYYnKdiHXFlF9uXm1ELrb0YX4GMHz7QnRmxvcmlhbiBG YWluZWxsaSA8Zi5mYWluZWxsaUBnbWFpbC5jb20+iGYEExECACYCGyMGCwkIBwMCBBUCCAME FgIDAQIeAQIXgAUCVF/S8QUJHlwd3wAKCRBhV5kVtWN2DvCVAJ4u4/bPF4P3jxb4qEY8I2gS 6hG0gACffNWlqJ2T4wSSn+3o7CCZNd7SLSC5BA0ESM+4EhAQAL/o09boR9D3Vk1Tt7+gpYr3 WQ6hgYVON905q2ndEoA2J0dQxJNRw3snabHDDzQBAcqOvdi7YidfBVdKi0wxHhSuRBfuOppu pdXkb7zxuPQuSveCLqqZWRQ+Cc2QgF7SBqgznbe6Ngout5qXY5Dcagk9LqFNGhJQzUGHAsIs hap1f0B1PoUyUNeEInV98D8Xd/edM3mhO9nRpUXRK9Bvt4iEZUXGuVtZLT52nK6Wv2EZ1TiT OiqZlf1P+vxYLBx9eKmabPdm3yjalhY8yr1S1vL0gSA/C6W1o/TowdieF1rWN/MYHlkpyj9c Rpc281gAO0AP3V1G00YzBEdYyi0gaJbCEQnq8Vz1vDXFxHzyhgGz7umBsVKmYwZgA8DrrB0M oaP35wuGR3RJcaG30AnJpEDkBYHznI2apxdcuTPOHZyEilIRrBGzDwGtAhldzlBoBwE3Z3MY 31TOpACu1ZpNOMysZ6xiE35pWkwc0KYm4hJA5GFfmWSN6DniimW3pmdDIiw4Ifcx8b3mFrRO BbDIW13E51j9RjbO/nAaK9ndZ5LRO1B/8Fwat7bLzmsCiEXOJY7NNpIEpkoNoEUfCcZwmLrU +eOTPzaF6drw6ayewEi5yzPg3TAT6FV3oBsNg3xlwU0gPK3v6gYPX5w9+ovPZ1/qqNfOrbsE FRuiSVsZQ5s3AAMFD/9XjlnnVDh9GX/r/6hjmr4U9tEsM+VQXaVXqZuHKaSmojOLUCP/YVQo 7IiYaNssCS4FCPe4yrL4FJJfJAsbeyDykMN7wAnBcOkbZ9BPJPNCbqU6dowLOiy8AuTYQ48m vIyQ4Ijnb6GTrtxIUDQeOBNuQC/gyyx3nbL/lVlHbxr4tb6YkhkO6shjXhQh7nQb33FjGO4P WU11Nr9i/qoV8QCo12MQEo244RRA6VMud06y/E449rWZFSTwGqb0FS0seTcYNvxt8PB2izX+ HZA8SL54j479ubxhfuoTu5nXdtFYFj5Lj5x34LKPx7MpgAmj0H7SDhpFWF2FzcC1bjiW9mjW HaKaX23Awt97AqQZXegbfkJwX2Y53ufq8Np3e1542lh3/mpiGSilCsaTahEGrHK+lIusl6mz Joil+u3k01ofvJMK0ZdzGUZ/aPMZ16LofjFA+MNxWrZFrkYmiGdv+LG45zSlZyIvzSiG2lKy kuVag+IijCIom78P9jRtB1q1Q5lwZp2TLAJlz92DmFwBg1hyFzwDADjZ2nrDxKUiybXIgZp9 aU2d++ptEGCVJOfEW4qpWCCLPbOT7XBr+g/4H3qWbs3j/cDDq7LuVYIe+wchy/iXEJaQVeTC y5arMQorqTFWlEOgRA8OP47L9knl9i4xuR0euV6DChDrguup2aJVU4hPBBgRAgAPAhsMBQJU X9LxBQkeXB3fAAoJEGFXmRW1Y3YOj4UAn3nrFLPZekMeqX5aD/aq/dsbXSfyAKC45Go0YyxV HGuUuzv+GKZ6nsysJ7kCDQRXG8fwARAA6q/pqBi5PjHcOAUgk2/2LR5LjjesK50bCaD4JuNc YDhFR7Vs108diBtsho3w8WRd9viOqDrhLJTroVckkk74OY8r+3t1E0Dd4wHWHQZsAeUvOwDM PQMqTUBFuMi6ydzTZpFA2wBR9x6ofl8Ax+zaGBcFrRlQnhsuXLnM1uuvS39+pmzIjasZBP2H UPk5ifigXcpelKmj6iskP3c8QN6x6GjUSmYx+xUfs/GNVSU1XOZn61wgPDbgINJd/THGdqiO iJxCLuTMqlSsmh1+E1dSdfYkCb93R/0ZHvMKWlAx7MnaFgBfsG8FqNtZu3PCLfizyVYYjXbV WO1A23riZKqwrSJAATo5iTS65BuYxrFsFNPrf7TitM8E76BEBZk0OZBvZxMuOs6Z1qI8YKVK UrHVGFq3NbuPWCdRul9SX3VfOunr9Gv0GABnJ0ET+K7nspax0xqq7zgnM71QEaiaH17IFYGS sG34V7Wo3vyQzsk7qLf9Ajno0DhJ+VX43g8+AjxOMNVrGCt9RNXSBVpyv2AMTlWCdJ5KI6V4 KEzWM4HJm7QlNKE6RPoBxJVbSQLPd9St3h7mxLcne4l7NK9eNgNnneT7QZL8fL//s9K8Ns1W t60uQNYvbhKDG7+/yLcmJgjF74XkGvxCmTA1rW2bsUriM533nG9gAOUFQjURkwI8jvMAEQEA AYkCaAQYEQIACQUCVxvH8AIbAgIpCRBhV5kVtWN2DsFdIAQZAQIABgUCVxvH8AAKCRCH0Jac RAcHBIkHD/9nmfog7X2ZXMzL9ktT++7x+W/QBrSTCTmq8PK+69+INN1ZDOrY8uz6htfTLV9+ e2W6G8/7zIvODuHk7r+yQ585XbplgP0V5Xc8iBHdBgXbqnY5zBrcH+Q/oQ2STalEvaGHqNoD UGyLQ/fiKoLZTPMur57Fy1c9rTuKiSdMgnT0FPfWVDfpR2Ds0gpqWePlRuRGOoCln5GnREA/ 2MW2rWf+CO9kbIR+66j8b4RUJqIK3dWn9xbENh/aqxfonGTCZQ2zC4sLd25DQA4w1itPo+f5 V/SQxuhnlQkTOCdJ7b/mby/pNRz1lsLkjnXueLILj7gNjwTabZXYtL16z24qkDTI1x3g98R/ xunb3/fQwR8FY5/zRvXJq5us/nLvIvOmVwZFkwXc+AF+LSIajqQz9XbXeIP/BDjlBNXRZNdo dVuSU51ENcMcilPr2EUnqEAqeczsCGpnvRCLfVQeSZr2L9N4svNhhfPOEscYhhpHTh0VPyxI pPBNKq+byuYPMyk3nj814NKhImK0O4gTyCK9b+gZAVvQcYAXvSouCnTZeJRrNHJFTgTgu6E0 caxTGgc5zzQHeX67eMzrGomG3ZnIxmd1sAbgvJUDaD2GrYlulfwGWwWyTNbWRvMighVdPkSF 6XFgQaosWxkV0OELLy2N485YrTr2Uq64VKyxpncLh50e2RnyAJ9qfUATKC9NgZjRvBztfqy4 a9BQwACgnzGuH1BVeT2J0Ra+ZYgkx7DaPR0= Message-ID: Date: Mon, 23 Dec 2019 20:16:55 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.3.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/22/2019 3:45 PM, Michal Kubecek wrote: > Add infrastructure for ethtool netlink notifications. There is only one > multicast group "monitor" which is used to notify userspace about changes > and actions performed. Notification messages (types using suffix _NTF) > share the format with replies to GET requests. > > Notifications are supposed to be broadcasted on every configuration change, > whether it is done using the netlink interface or ioctl one. Netlink SET > requests only trigger a notification if some data is actually changed. > > To trigger an ethtool notification, both ethtool netlink and external code > use ethtool_notify() helper. This helper requires RTNL to be held and may > sleep. Handlers sending messages for specific notification message types > are registered in ethnl_notify_handlers array. As notifications can be > triggered from other code, ethnl_ok flag is used to prevent an attempt to > send notification before genetlink family is registered. > > Signed-off-by: Michal Kubecek Reviewed-by: Florian Fainelli -- Florian