Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp7192421ybl; Mon, 23 Dec 2019 20:42:48 -0800 (PST) X-Google-Smtp-Source: APXvYqx0kDc73t2ONK+UU2j28oeVsUTAvduTzhQjIjLXVGY8pv1ZwhMZ5uQFhxsx3OCF7DsMToJQ X-Received: by 2002:a05:6830:128e:: with SMTP id z14mr35045852otp.184.1577162568715; Mon, 23 Dec 2019 20:42:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1577162568; cv=none; d=google.com; s=arc-20160816; b=dCA2eFe5HPG1hqVoxQV9D6JAnBLVw0ciIQmDrDhlWBAGGDkBDFGEaJBfPSSNM3GgRp 0UxeKgyicLtsMNTP8Rm7XkJYdCTlNhmLbQohpQ1LUAjqT5qUK3sLKSHQko2+7gQNyokJ nOtqJ8Xp6QFjthUWdVuyy1qLlx4gN+5fbCtyt6e6q7k5eGFX5bQZG7rRhCzA3BlJtuYC XZtgIueMW9pEYvgnnHf4cuhCdcMqe7WmEQg60R6slZzNVFvJDuWPGh9Gnrb+AUMdSx6H F8/SNSwGr3iPwPdKUoBj1DVqL63+CwqjU/AervzdTMsvHIoOlTyRkYXpaOJfzHqgA8G/ L9Fw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:from:references:cc:to:subject:dkim-signature; bh=JoTjvPy6XkZPG7BWE7ZFfAl28h/iHccBxD+gsbcLBcw=; b=lO188OuWACfYv6tnac2WYDkCusipTBbDZFWSjLz9CsyJjV2GRyWpfKdFZy/P1FvWse 25ksTvuC4MAvGvIbmQxV6iF/DEyGahjRsQ/rcx/AVzUf5vcvwZqph17s9Yu/G5byV1sK 7PCR77cn0mf+GFwv2VWd71BTBwDuy9wyA/9lDpwzwLFhIKTlxdzAXL1JzMf6a9j1NLo+ 7ZTUZXneHUee6eoQeJDtHI+UILPBhJsur2Q1DR1n60r6r94WUtvQ6pEy3TJsu+f5JThB 61xfy7nr6JX6hjPDXtGGR0mHobR5gyZIqihK8Aze+m5pPUv8xn9zwPRYcp7VnaWptqOf 0RzA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=hHw0HWkr; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p71si10732276oic.138.2019.12.23.20.42.37; Mon, 23 Dec 2019 20:42:48 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=hHw0HWkr; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727070AbfLXElv (ORCPT + 99 others); Mon, 23 Dec 2019 23:41:51 -0500 Received: from mail-pg1-f194.google.com ([209.85.215.194]:43866 "EHLO mail-pg1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726881AbfLXElv (ORCPT ); Mon, 23 Dec 2019 23:41:51 -0500 Received: by mail-pg1-f194.google.com with SMTP id k197so9831707pga.10; Mon, 23 Dec 2019 20:41:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:autocrypt:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=JoTjvPy6XkZPG7BWE7ZFfAl28h/iHccBxD+gsbcLBcw=; b=hHw0HWkrZkYBgqOOwKyRBdGAGisIzUhlBYXQIg+CB7ZUeeoaHvpFFx1jOjtJYmCq1g dXoCYWz9WhTOHzWFPf2PMi4fc9+j4+esHY4YFARuFyZMAO4zPMitPrLrMriSynRUeuXp 4oUPmkVK1ldi+nJmjWFdFwD/m3xPpN3sg4QYs/un3LZ9ojMn4yYSqS2eE1iKQQLB6kJ9 dbSy6n8+tZcsSP4iua0f4qFZzv5OiCYL9g8+SNtiGkAp9meYOSwPszdDKeFxBU9CJYNT nSzlE76gCsTxjDxSB+8Wc/O1qW0dBrHA5nU6PtgcNToi/yr+rwp9Mb7bSzqjYdpYELg/ 9acg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=JoTjvPy6XkZPG7BWE7ZFfAl28h/iHccBxD+gsbcLBcw=; b=ByWMNhkjNqfKXBL3Kv3dd1kO0kkd7DSJVHdHOFpBtaHIwxlmWE0SYR+XxMSAXbyGqa lN9AxAVS6Yd8wenQcO0dFk5hY62JF9oQL/ocRc98E/4T2Q2RO9UiuQzzhq+VmuMutUuj XP0dyKmrTbcXYFI3rYPZDiBZKBlnwthf5M7Uee2Ut+TdZ0iaPFSvFxBOCeosWW1tu2d1 buFPTDSZxs4X/0pJOhPYErNCdr6e6YxsOAkfaop+6zIv26RrXiac0/ILEQgxHsgidyqa i5DOUpW8mYpIRvPHBpJdD/VnEWxmw4zJLPeYOd3GzJ6v4YvTVmGAKiNNcdcxwSFvCrFf Ljpg== X-Gm-Message-State: APjAAAXhW5O46L5mA7ggVSgMhWRFTwuoljV7jes7PhfLSz3EX6E8JPDw 1WCIPTKHu7fyHRft5FGipOKg1KU5 X-Received: by 2002:a63:4006:: with SMTP id n6mr27470203pga.139.1577162510609; Mon, 23 Dec 2019 20:41:50 -0800 (PST) Received: from [192.168.1.3] (ip68-111-84-250.oc.oc.cox.net. [68.111.84.250]) by smtp.gmail.com with ESMTPSA id u23sm26456043pfm.29.2019.12.23.20.41.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 23 Dec 2019 20:41:50 -0800 (PST) Subject: Re: [PATCH net-next v8 13/14] ethtool: add LINKMODES_NTF notification To: Michal Kubecek , David Miller , netdev@vger.kernel.org Cc: Jakub Kicinski , Jiri Pirko , Andrew Lunn , John Linville , Stephen Hemminger , Johannes Berg , linux-kernel@vger.kernel.org References: From: Florian Fainelli Autocrypt: addr=f.fainelli@gmail.com; keydata= mQGiBEjPuBIRBACW9MxSJU9fvEOCTnRNqG/13rAGsj+vJqontvoDSNxRgmafP8d3nesnqPyR xGlkaOSDuu09rxuW+69Y2f1TzjFuGpBk4ysWOR85O2Nx8AJ6fYGCoeTbovrNlGT1M9obSFGQ X3IzRnWoqlfudjTO5TKoqkbOgpYqIo5n1QbEjCCwCwCg3DOH/4ug2AUUlcIT9/l3pGvoRJ0E AICDzi3l7pmC5IWn2n1mvP5247urtHFs/uusE827DDj3K8Upn2vYiOFMBhGsxAk6YKV6IP0d ZdWX6fqkJJlu9cSDvWtO1hXeHIfQIE/xcqvlRH783KrihLcsmnBqOiS6rJDO2x1eAgC8meAX SAgsrBhcgGl2Rl5gh/jkeA5ykwbxA/9u1eEuL70Qzt5APJmqVXR+kWvrqdBVPoUNy/tQ8mYc nzJJ63ng3tHhnwHXZOu8hL4nqwlYHRa9eeglXYhBqja4ZvIvCEqSmEukfivk+DlIgVoOAJbh qIWgvr3SIEuR6ayY3f5j0f2ejUMYlYYnKdiHXFlF9uXm1ELrb0YX4GMHz7QnRmxvcmlhbiBG YWluZWxsaSA8Zi5mYWluZWxsaUBnbWFpbC5jb20+iGYEExECACYCGyMGCwkIBwMCBBUCCAME FgIDAQIeAQIXgAUCVF/S8QUJHlwd3wAKCRBhV5kVtWN2DvCVAJ4u4/bPF4P3jxb4qEY8I2gS 6hG0gACffNWlqJ2T4wSSn+3o7CCZNd7SLSC5BA0ESM+4EhAQAL/o09boR9D3Vk1Tt7+gpYr3 WQ6hgYVON905q2ndEoA2J0dQxJNRw3snabHDDzQBAcqOvdi7YidfBVdKi0wxHhSuRBfuOppu pdXkb7zxuPQuSveCLqqZWRQ+Cc2QgF7SBqgznbe6Ngout5qXY5Dcagk9LqFNGhJQzUGHAsIs hap1f0B1PoUyUNeEInV98D8Xd/edM3mhO9nRpUXRK9Bvt4iEZUXGuVtZLT52nK6Wv2EZ1TiT OiqZlf1P+vxYLBx9eKmabPdm3yjalhY8yr1S1vL0gSA/C6W1o/TowdieF1rWN/MYHlkpyj9c Rpc281gAO0AP3V1G00YzBEdYyi0gaJbCEQnq8Vz1vDXFxHzyhgGz7umBsVKmYwZgA8DrrB0M oaP35wuGR3RJcaG30AnJpEDkBYHznI2apxdcuTPOHZyEilIRrBGzDwGtAhldzlBoBwE3Z3MY 31TOpACu1ZpNOMysZ6xiE35pWkwc0KYm4hJA5GFfmWSN6DniimW3pmdDIiw4Ifcx8b3mFrRO BbDIW13E51j9RjbO/nAaK9ndZ5LRO1B/8Fwat7bLzmsCiEXOJY7NNpIEpkoNoEUfCcZwmLrU +eOTPzaF6drw6ayewEi5yzPg3TAT6FV3oBsNg3xlwU0gPK3v6gYPX5w9+ovPZ1/qqNfOrbsE FRuiSVsZQ5s3AAMFD/9XjlnnVDh9GX/r/6hjmr4U9tEsM+VQXaVXqZuHKaSmojOLUCP/YVQo 7IiYaNssCS4FCPe4yrL4FJJfJAsbeyDykMN7wAnBcOkbZ9BPJPNCbqU6dowLOiy8AuTYQ48m vIyQ4Ijnb6GTrtxIUDQeOBNuQC/gyyx3nbL/lVlHbxr4tb6YkhkO6shjXhQh7nQb33FjGO4P WU11Nr9i/qoV8QCo12MQEo244RRA6VMud06y/E449rWZFSTwGqb0FS0seTcYNvxt8PB2izX+ HZA8SL54j479ubxhfuoTu5nXdtFYFj5Lj5x34LKPx7MpgAmj0H7SDhpFWF2FzcC1bjiW9mjW HaKaX23Awt97AqQZXegbfkJwX2Y53ufq8Np3e1542lh3/mpiGSilCsaTahEGrHK+lIusl6mz Joil+u3k01ofvJMK0ZdzGUZ/aPMZ16LofjFA+MNxWrZFrkYmiGdv+LG45zSlZyIvzSiG2lKy kuVag+IijCIom78P9jRtB1q1Q5lwZp2TLAJlz92DmFwBg1hyFzwDADjZ2nrDxKUiybXIgZp9 aU2d++ptEGCVJOfEW4qpWCCLPbOT7XBr+g/4H3qWbs3j/cDDq7LuVYIe+wchy/iXEJaQVeTC y5arMQorqTFWlEOgRA8OP47L9knl9i4xuR0euV6DChDrguup2aJVU4hPBBgRAgAPAhsMBQJU X9LxBQkeXB3fAAoJEGFXmRW1Y3YOj4UAn3nrFLPZekMeqX5aD/aq/dsbXSfyAKC45Go0YyxV HGuUuzv+GKZ6nsysJ7kCDQRXG8fwARAA6q/pqBi5PjHcOAUgk2/2LR5LjjesK50bCaD4JuNc YDhFR7Vs108diBtsho3w8WRd9viOqDrhLJTroVckkk74OY8r+3t1E0Dd4wHWHQZsAeUvOwDM PQMqTUBFuMi6ydzTZpFA2wBR9x6ofl8Ax+zaGBcFrRlQnhsuXLnM1uuvS39+pmzIjasZBP2H UPk5ifigXcpelKmj6iskP3c8QN6x6GjUSmYx+xUfs/GNVSU1XOZn61wgPDbgINJd/THGdqiO iJxCLuTMqlSsmh1+E1dSdfYkCb93R/0ZHvMKWlAx7MnaFgBfsG8FqNtZu3PCLfizyVYYjXbV WO1A23riZKqwrSJAATo5iTS65BuYxrFsFNPrf7TitM8E76BEBZk0OZBvZxMuOs6Z1qI8YKVK UrHVGFq3NbuPWCdRul9SX3VfOunr9Gv0GABnJ0ET+K7nspax0xqq7zgnM71QEaiaH17IFYGS sG34V7Wo3vyQzsk7qLf9Ajno0DhJ+VX43g8+AjxOMNVrGCt9RNXSBVpyv2AMTlWCdJ5KI6V4 KEzWM4HJm7QlNKE6RPoBxJVbSQLPd9St3h7mxLcne4l7NK9eNgNnneT7QZL8fL//s9K8Ns1W t60uQNYvbhKDG7+/yLcmJgjF74XkGvxCmTA1rW2bsUriM533nG9gAOUFQjURkwI8jvMAEQEA AYkCaAQYEQIACQUCVxvH8AIbAgIpCRBhV5kVtWN2DsFdIAQZAQIABgUCVxvH8AAKCRCH0Jac RAcHBIkHD/9nmfog7X2ZXMzL9ktT++7x+W/QBrSTCTmq8PK+69+INN1ZDOrY8uz6htfTLV9+ e2W6G8/7zIvODuHk7r+yQ585XbplgP0V5Xc8iBHdBgXbqnY5zBrcH+Q/oQ2STalEvaGHqNoD UGyLQ/fiKoLZTPMur57Fy1c9rTuKiSdMgnT0FPfWVDfpR2Ds0gpqWePlRuRGOoCln5GnREA/ 2MW2rWf+CO9kbIR+66j8b4RUJqIK3dWn9xbENh/aqxfonGTCZQ2zC4sLd25DQA4w1itPo+f5 V/SQxuhnlQkTOCdJ7b/mby/pNRz1lsLkjnXueLILj7gNjwTabZXYtL16z24qkDTI1x3g98R/ xunb3/fQwR8FY5/zRvXJq5us/nLvIvOmVwZFkwXc+AF+LSIajqQz9XbXeIP/BDjlBNXRZNdo dVuSU51ENcMcilPr2EUnqEAqeczsCGpnvRCLfVQeSZr2L9N4svNhhfPOEscYhhpHTh0VPyxI pPBNKq+byuYPMyk3nj814NKhImK0O4gTyCK9b+gZAVvQcYAXvSouCnTZeJRrNHJFTgTgu6E0 caxTGgc5zzQHeX67eMzrGomG3ZnIxmd1sAbgvJUDaD2GrYlulfwGWwWyTNbWRvMighVdPkSF 6XFgQaosWxkV0OELLy2N485YrTr2Uq64VKyxpncLh50e2RnyAJ9qfUATKC9NgZjRvBztfqy4 a9BQwACgnzGuH1BVeT2J0Ra+ZYgkx7DaPR0= Message-ID: Date: Mon, 23 Dec 2019 20:41:48 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.3.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/22/2019 3:46 PM, Michal Kubecek wrote: > Send ETHTOOL_MSG_LINKMODES_NTF notification message whenever device link > settings or advertised modes are modified using ETHTOOL_MSG_LINKMODES_SET > netlink message or ETHTOOL_SLINKSETTINGS or ETHTOOL_SSET ioctl commands. > > The notification message has the same format as reply to LINKMODES_GET > request. ETHTOOL_MSG_LINKMODES_SET netlink request only triggers the > notification if there is a change but the ioctl command handlers do not > check if there is an actual change and trigger the notification whenever > the commands are executed. > > As all work is done by ethnl_default_notify() handler and callback > functions introduced to handle LINKMODES_GET requests, all that remains is > adding entries for ETHTOOL_MSG_LINKMODES_NTF into ethnl_notify_handlers and > ethnl_default_notify_ops lookup tables and calls to ethtool_notify() where > needed. > > Signed-off-by: Michal Kubecek Reviewed-by: Florian Fainelli -- Florian