Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp7193945ybl; Mon, 23 Dec 2019 20:45:10 -0800 (PST) X-Google-Smtp-Source: APXvYqxikU20fjmUZT2JdReNXzEvr9LBADAbFuIWVyP9WP3ha2NieQe7ORmTumuEBafarYg+rgTS X-Received: by 2002:a9d:1d02:: with SMTP id m2mr34118708otm.45.1577162710815; Mon, 23 Dec 2019 20:45:10 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1577162710; cv=none; d=google.com; s=arc-20160816; b=AtEzuS7bNDYzRpTUtQDuyMAJgDfNLkuq+fVjegs3rvlXsWhgRarjZJyN1kOw+UN0zv +4E836g+tSDfEDTGpVg0Q6rcGVK/8CDjlOEsENuqWGJYNrojTGJi8EuOmAcY6jDEjLoK D/Zqp5MUnL4WQOik6GZD4jQ22zzbvMxS5sz1YXM5N8oGqBjIIvZR436h3m6VchqGx5P6 HG+Xil/98KY82VJbbo/I3Mlx36dicY2+AHRmKv6ny4bD8b2M62Uj0Ua69SGZQRClIjjz 8t0KxZm3mPxR4Ed0QvydCQr4bJPU8Fc8EqDHIQX/pmtvt19ras4hiSxUp+NPRW8cV9/n s9TQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:from:references:cc:to:subject:dkim-signature; bh=WFYPDpSn46JwPjbFpRAIxd857o4nEm+35HGIctfhwtw=; b=TPwLDJ7l7HB4GZ2yFqgp5p3orYy0NmknMke1cE4ReaANV3NeykRd6WBPEVQOaAYHdJ kUQnJ/OGSk3qs9IeO+N845sSGPwYokiW1gMGj/KysYNAmV2+hUB2vzf0+vrXqJQQ51/v orwNWSVT6UGDwtAssjcMTKzBAUcIZwXtq3HXjEWGKqvicqc3h0Mt63u47/GF8SDllJWb dwUWXs1XjpiugmVYiEoDyVgQk34yeuRaGL6US1h4wt38CxtmuNzt1EhS/1fqxZUyWiPJ VQ0+VZPmtrX/vWnKmdrRAd/K/LcK1VwcckB4LEzJjulyNemsckDJCn50uCDyXXhhlFQR i5Eg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=YXANqMvx; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y3si8234202oto.98.2019.12.23.20.44.59; Mon, 23 Dec 2019 20:45:10 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=YXANqMvx; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726890AbfLXEoW (ORCPT + 99 others); Mon, 23 Dec 2019 23:44:22 -0500 Received: from mail-pj1-f65.google.com ([209.85.216.65]:54817 "EHLO mail-pj1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726853AbfLXEoW (ORCPT ); Mon, 23 Dec 2019 23:44:22 -0500 Received: by mail-pj1-f65.google.com with SMTP id kx11so680840pjb.4; Mon, 23 Dec 2019 20:44:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:autocrypt:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=WFYPDpSn46JwPjbFpRAIxd857o4nEm+35HGIctfhwtw=; b=YXANqMvx3LVDCPDqqSJFdzMeVCp9CYAxeDlNR8s4yEeHJKSsSSjAIRWdZj1sMSTALy +07xOb6CbaQ6R6Fc2fXWSVBSOl5/Kz6g28dAO3qt5ABY5/NlmDeD5QBUpmoqHWjorvRA 0BteGylIRE8G9HB/WDYuCpLDX6C6GYJegFsEHVv7wFx4Je8HTyGOqOtV2o86UVm/ttQe Jqf1UaSQqYe0hHHjhcwhJo/6UktWs/woVu7l9QHiMiFZFn+L5NJ2U7SmEZATJG+O5TDm 2+4rtBTzH6WePRBMztiDJDjuTWt19pEqZT1DOSo5t3faHS+4Kh4GyKuGd8PvQIezg0ZV 6GjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=WFYPDpSn46JwPjbFpRAIxd857o4nEm+35HGIctfhwtw=; b=Ma/IYaHzUIYuXp2iI+2utsQeR7FzUFaglVqTX5R6ydKaWoQRI7NTQoLhOk7iCqEqtw /ZxDruxVoEuA+Zi8XW3P/WEdOqv2yJXHfiVvu6Y5Xn6jtggGKVJG+TcAC49s7G9uv3xC jiwv2uQC2etwinUSrbx0i2MV7MT1pt53vanIs6nn03Waq102C0HZwn/Ak8T7pOOOi3Hi hWxUR4KW2Tdicv77QtfGDxdWutc8N5mbIwsFauskLjmiWY1sDyin8NV/VXGVOk/AgGrE hk/U83ivxDIsnLxVbLRPdiPzWVy2FNAleMimntgsTwvQNe1n41fOpNk9tWM1OGXkIyRe kQkg== X-Gm-Message-State: APjAAAXG/IUOrrkyS5+0Du3jhjUUN5u5vU9KQFnlyg1NIAKrmRlCdgy3 09bT8wv56MQ91GkJkTud0VFVGfE2 X-Received: by 2002:a17:902:7043:: with SMTP id h3mr34327594plt.332.1577162661251; Mon, 23 Dec 2019 20:44:21 -0800 (PST) Received: from [192.168.1.3] (ip68-111-84-250.oc.oc.cox.net. [68.111.84.250]) by smtp.gmail.com with ESMTPSA id f8sm26334210pfn.2.2019.12.23.20.44.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 23 Dec 2019 20:44:20 -0800 (PST) Subject: Re: [PATCH net-next v8 14/14] ethtool: provide link state with LINKSTATE_GET request To: Michal Kubecek , David Miller , netdev@vger.kernel.org Cc: Jakub Kicinski , Jiri Pirko , Andrew Lunn , John Linville , Stephen Hemminger , Johannes Berg , linux-kernel@vger.kernel.org References: <7a6c4161fc6d29620bdc95a919e03f8be8b91e48.1577052887.git.mkubecek@suse.cz> From: Florian Fainelli Autocrypt: addr=f.fainelli@gmail.com; keydata= mQGiBEjPuBIRBACW9MxSJU9fvEOCTnRNqG/13rAGsj+vJqontvoDSNxRgmafP8d3nesnqPyR xGlkaOSDuu09rxuW+69Y2f1TzjFuGpBk4ysWOR85O2Nx8AJ6fYGCoeTbovrNlGT1M9obSFGQ X3IzRnWoqlfudjTO5TKoqkbOgpYqIo5n1QbEjCCwCwCg3DOH/4ug2AUUlcIT9/l3pGvoRJ0E AICDzi3l7pmC5IWn2n1mvP5247urtHFs/uusE827DDj3K8Upn2vYiOFMBhGsxAk6YKV6IP0d ZdWX6fqkJJlu9cSDvWtO1hXeHIfQIE/xcqvlRH783KrihLcsmnBqOiS6rJDO2x1eAgC8meAX SAgsrBhcgGl2Rl5gh/jkeA5ykwbxA/9u1eEuL70Qzt5APJmqVXR+kWvrqdBVPoUNy/tQ8mYc nzJJ63ng3tHhnwHXZOu8hL4nqwlYHRa9eeglXYhBqja4ZvIvCEqSmEukfivk+DlIgVoOAJbh qIWgvr3SIEuR6ayY3f5j0f2ejUMYlYYnKdiHXFlF9uXm1ELrb0YX4GMHz7QnRmxvcmlhbiBG YWluZWxsaSA8Zi5mYWluZWxsaUBnbWFpbC5jb20+iGYEExECACYCGyMGCwkIBwMCBBUCCAME FgIDAQIeAQIXgAUCVF/S8QUJHlwd3wAKCRBhV5kVtWN2DvCVAJ4u4/bPF4P3jxb4qEY8I2gS 6hG0gACffNWlqJ2T4wSSn+3o7CCZNd7SLSC5BA0ESM+4EhAQAL/o09boR9D3Vk1Tt7+gpYr3 WQ6hgYVON905q2ndEoA2J0dQxJNRw3snabHDDzQBAcqOvdi7YidfBVdKi0wxHhSuRBfuOppu pdXkb7zxuPQuSveCLqqZWRQ+Cc2QgF7SBqgznbe6Ngout5qXY5Dcagk9LqFNGhJQzUGHAsIs hap1f0B1PoUyUNeEInV98D8Xd/edM3mhO9nRpUXRK9Bvt4iEZUXGuVtZLT52nK6Wv2EZ1TiT OiqZlf1P+vxYLBx9eKmabPdm3yjalhY8yr1S1vL0gSA/C6W1o/TowdieF1rWN/MYHlkpyj9c Rpc281gAO0AP3V1G00YzBEdYyi0gaJbCEQnq8Vz1vDXFxHzyhgGz7umBsVKmYwZgA8DrrB0M oaP35wuGR3RJcaG30AnJpEDkBYHznI2apxdcuTPOHZyEilIRrBGzDwGtAhldzlBoBwE3Z3MY 31TOpACu1ZpNOMysZ6xiE35pWkwc0KYm4hJA5GFfmWSN6DniimW3pmdDIiw4Ifcx8b3mFrRO BbDIW13E51j9RjbO/nAaK9ndZ5LRO1B/8Fwat7bLzmsCiEXOJY7NNpIEpkoNoEUfCcZwmLrU +eOTPzaF6drw6ayewEi5yzPg3TAT6FV3oBsNg3xlwU0gPK3v6gYPX5w9+ovPZ1/qqNfOrbsE FRuiSVsZQ5s3AAMFD/9XjlnnVDh9GX/r/6hjmr4U9tEsM+VQXaVXqZuHKaSmojOLUCP/YVQo 7IiYaNssCS4FCPe4yrL4FJJfJAsbeyDykMN7wAnBcOkbZ9BPJPNCbqU6dowLOiy8AuTYQ48m vIyQ4Ijnb6GTrtxIUDQeOBNuQC/gyyx3nbL/lVlHbxr4tb6YkhkO6shjXhQh7nQb33FjGO4P WU11Nr9i/qoV8QCo12MQEo244RRA6VMud06y/E449rWZFSTwGqb0FS0seTcYNvxt8PB2izX+ HZA8SL54j479ubxhfuoTu5nXdtFYFj5Lj5x34LKPx7MpgAmj0H7SDhpFWF2FzcC1bjiW9mjW HaKaX23Awt97AqQZXegbfkJwX2Y53ufq8Np3e1542lh3/mpiGSilCsaTahEGrHK+lIusl6mz Joil+u3k01ofvJMK0ZdzGUZ/aPMZ16LofjFA+MNxWrZFrkYmiGdv+LG45zSlZyIvzSiG2lKy kuVag+IijCIom78P9jRtB1q1Q5lwZp2TLAJlz92DmFwBg1hyFzwDADjZ2nrDxKUiybXIgZp9 aU2d++ptEGCVJOfEW4qpWCCLPbOT7XBr+g/4H3qWbs3j/cDDq7LuVYIe+wchy/iXEJaQVeTC y5arMQorqTFWlEOgRA8OP47L9knl9i4xuR0euV6DChDrguup2aJVU4hPBBgRAgAPAhsMBQJU X9LxBQkeXB3fAAoJEGFXmRW1Y3YOj4UAn3nrFLPZekMeqX5aD/aq/dsbXSfyAKC45Go0YyxV HGuUuzv+GKZ6nsysJ7kCDQRXG8fwARAA6q/pqBi5PjHcOAUgk2/2LR5LjjesK50bCaD4JuNc YDhFR7Vs108diBtsho3w8WRd9viOqDrhLJTroVckkk74OY8r+3t1E0Dd4wHWHQZsAeUvOwDM PQMqTUBFuMi6ydzTZpFA2wBR9x6ofl8Ax+zaGBcFrRlQnhsuXLnM1uuvS39+pmzIjasZBP2H UPk5ifigXcpelKmj6iskP3c8QN6x6GjUSmYx+xUfs/GNVSU1XOZn61wgPDbgINJd/THGdqiO iJxCLuTMqlSsmh1+E1dSdfYkCb93R/0ZHvMKWlAx7MnaFgBfsG8FqNtZu3PCLfizyVYYjXbV WO1A23riZKqwrSJAATo5iTS65BuYxrFsFNPrf7TitM8E76BEBZk0OZBvZxMuOs6Z1qI8YKVK UrHVGFq3NbuPWCdRul9SX3VfOunr9Gv0GABnJ0ET+K7nspax0xqq7zgnM71QEaiaH17IFYGS sG34V7Wo3vyQzsk7qLf9Ajno0DhJ+VX43g8+AjxOMNVrGCt9RNXSBVpyv2AMTlWCdJ5KI6V4 KEzWM4HJm7QlNKE6RPoBxJVbSQLPd9St3h7mxLcne4l7NK9eNgNnneT7QZL8fL//s9K8Ns1W t60uQNYvbhKDG7+/yLcmJgjF74XkGvxCmTA1rW2bsUriM533nG9gAOUFQjURkwI8jvMAEQEA AYkCaAQYEQIACQUCVxvH8AIbAgIpCRBhV5kVtWN2DsFdIAQZAQIABgUCVxvH8AAKCRCH0Jac RAcHBIkHD/9nmfog7X2ZXMzL9ktT++7x+W/QBrSTCTmq8PK+69+INN1ZDOrY8uz6htfTLV9+ e2W6G8/7zIvODuHk7r+yQ585XbplgP0V5Xc8iBHdBgXbqnY5zBrcH+Q/oQ2STalEvaGHqNoD UGyLQ/fiKoLZTPMur57Fy1c9rTuKiSdMgnT0FPfWVDfpR2Ds0gpqWePlRuRGOoCln5GnREA/ 2MW2rWf+CO9kbIR+66j8b4RUJqIK3dWn9xbENh/aqxfonGTCZQ2zC4sLd25DQA4w1itPo+f5 V/SQxuhnlQkTOCdJ7b/mby/pNRz1lsLkjnXueLILj7gNjwTabZXYtL16z24qkDTI1x3g98R/ xunb3/fQwR8FY5/zRvXJq5us/nLvIvOmVwZFkwXc+AF+LSIajqQz9XbXeIP/BDjlBNXRZNdo dVuSU51ENcMcilPr2EUnqEAqeczsCGpnvRCLfVQeSZr2L9N4svNhhfPOEscYhhpHTh0VPyxI pPBNKq+byuYPMyk3nj814NKhImK0O4gTyCK9b+gZAVvQcYAXvSouCnTZeJRrNHJFTgTgu6E0 caxTGgc5zzQHeX67eMzrGomG3ZnIxmd1sAbgvJUDaD2GrYlulfwGWwWyTNbWRvMighVdPkSF 6XFgQaosWxkV0OELLy2N485YrTr2Uq64VKyxpncLh50e2RnyAJ9qfUATKC9NgZjRvBztfqy4 a9BQwACgnzGuH1BVeT2J0Ra+ZYgkx7DaPR0= Message-ID: <918da8cd-7ebc-b895-85c8-afad9eed6036@gmail.com> Date: Mon, 23 Dec 2019 20:44:19 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.3.1 MIME-Version: 1.0 In-Reply-To: <7a6c4161fc6d29620bdc95a919e03f8be8b91e48.1577052887.git.mkubecek@suse.cz> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/22/2019 3:46 PM, Michal Kubecek wrote: > Implement LINKSTATE_GET netlink request to get link state information. > > At the moment, only link up flag as provided by ETHTOOL_GLINK ioctl command > is returned. > > LINKSTATE_GET request can be used with NLM_F_DUMP (without device > identification) to request the information for all devices in current > network namespace providing the data. > > Signed-off-by: Michal Kubecek > --- [snip] > +Kernel response contents: > + > + ==================================== ====== ========================== > + ``ETHTOOL_A_LINKSTATE_HEADER`` nested reply header > + ``ETHTOOL_A_LINKSTATE_LINK`` u8 autonegotiation status ^ ==== Humm, auto-negotiation status may not be exactly accurate especially with complex devices with SerDes/PHY/SFPs/what have you/. Other than that, the code looks correct: Reviewed-by: Florian Fainelli -- Florian