Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp7240258ybl; Mon, 23 Dec 2019 21:57:23 -0800 (PST) X-Google-Smtp-Source: APXvYqxbltNdQ4CfjKQJNRzKDsPXNGdTg2PTAkDqvnXsqtuN+uKcBoByzPxLJPQcI/oRAbeNN8/K X-Received: by 2002:a05:6830:4a4:: with SMTP id l4mr37296064otd.91.1577167042996; Mon, 23 Dec 2019 21:57:22 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1577167042; cv=none; d=google.com; s=arc-20160816; b=O4T317HkLu393pgKI35M8VCnKDFd09VICvjLzR1ybp5evIJxr7MvNTNtad0ozQOfA1 c4oa/dm0VJgP1nOFyaKctEOT0NN/A4AtDYBOQf3f7k02Np8MeKm8DFy4yFnXFxOWUzhm n+65Kkgg76bWQ1AVuv8Mua35HFNo0S6Y+kOKHTdrjF3ednvB7PvnFpXwV4gHKfgwBA5Q NW8bf8InU41pvxDisbMyT6+xEdS7IWL1aQenPDB1vNWQMz7gpVzyt6eAxYxwbCnKvXO7 r59eFaZo93rllkt3gCQCbPgG23szI3ry1pAd3RoFsiep/Xkn+8EvAcKSYGOMhDax6j66 0zNQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:message-id:references :in-reply-to:subject:cc:to:from:date:content-transfer-encoding :mime-version:dkim-signature; bh=N78ejg9rqJGWEVBDpiZaJ8zMo/6RK3GuNyY8fajolbU=; b=Astglg6WcVENJqrcF0dqiOKfp5M4W4ZZAbdWGwXx41Kv3+HaeGm8eZc12VE5lDgKSB RDaaEiUXijxsu1FLW7XlE5gRnarptvXayMBnxgtnI8HkXZItwIUU2ZedyVU6iyFYZGYb 9cwwQ42HTfuDsrdQ3p71sRxnZfu3Z+YFsGMa357Dwgq334gS0w4Fl6QGNA8PFidLXAb4 2iIekAR0gigEJbPwrqkx6IhA5dqfFUS6Cpe4IrJELj/XLigF+H2K6zK+GyzmoKvABHGX 72z20h837l4Ke2HwWDWtCR5GLZ9x2+QOhGz9yRJFIUI27eUbDXOLGAtjITGuc747W9Lw 0Nzg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@mg.codeaurora.org header.s=smtp header.b=D2s5SS70; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h7si7629948otk.86.2019.12.23.21.57.11; Mon, 23 Dec 2019 21:57:22 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@mg.codeaurora.org header.s=smtp header.b=D2s5SS70; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726206AbfLXF4X (ORCPT + 99 others); Tue, 24 Dec 2019 00:56:23 -0500 Received: from mail25.static.mailgun.info ([104.130.122.25]:44992 "EHLO mail25.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726037AbfLXF4W (ORCPT ); Tue, 24 Dec 2019 00:56:22 -0500 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1577166982; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=N78ejg9rqJGWEVBDpiZaJ8zMo/6RK3GuNyY8fajolbU=; b=D2s5SS70aEftc8TnUTzXCQL9MqB1afoEiLj7GyOkEgk2mU+gcKPIbkqiQeUMlFTrAndssDBc HXmHX09TUzhU6geBZ/82tjgD9zQcm3s/LZhAf7AqLAtgyUqyZgllUvC6Q3mj3xIUj/Iy3uBL guEIqTR4Ivaz1JJKEwR83a6H8ZI= X-Mailgun-Sending-Ip: 104.130.122.25 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by mxa.mailgun.org with ESMTP id 5e01a882.7fc08109fbc8-smtp-out-n01; Tue, 24 Dec 2019 05:56:18 -0000 (UTC) Received: by smtp.codeaurora.org (Postfix, from userid 1001) id CA6E0C4479F; Tue, 24 Dec 2019 05:56:17 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-caf-mail-1.web.codeaurora.org X-Spam-Level: * X-Spam-Status: No, score=1.3 required=2.0 tests=ALL_TRUSTED,TVD_SUBJ_WIPE_DEBT, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: cang) by smtp.codeaurora.org (Postfix) with ESMTPSA id 84677C433CB; Tue, 24 Dec 2019 05:56:17 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Tue, 24 Dec 2019 13:56:17 +0800 From: Can Guo To: Vinod Koul Cc: Kishon Vijay Abraham I , linux-arm-msm@vger.kernel.org, Bjorn Andersson , Andy Gross , Jeffrey Hugo , Manu Gautam , linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 2/4] phy: qcom-qmp: remove duplicate powerdown write In-Reply-To: <20191223143046.3376299-3-vkoul@kernel.org> References: <20191223143046.3376299-1-vkoul@kernel.org> <20191223143046.3376299-3-vkoul@kernel.org> Message-ID: X-Sender: cang@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2019-12-23 22:30, Vinod Koul wrote: > We already write to QPHY_POWER_DOWN_CONTROL in qcom_qmp_phy_com_init() > before invoking qcom_qmp_phy_configure() so remove the duplicate write. > > Signed-off-by: Vinod Koul Reviewed-by: Can Guo > --- > drivers/phy/qualcomm/phy-qcom-qmp.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/phy/qualcomm/phy-qcom-qmp.c > b/drivers/phy/qualcomm/phy-qcom-qmp.c > index 1196c85aa023..4f2e65c7cf45 100644 > --- a/drivers/phy/qualcomm/phy-qcom-qmp.c > +++ b/drivers/phy/qualcomm/phy-qcom-qmp.c > @@ -885,7 +885,6 @@ static const struct qmp_phy_init_tbl > msm8998_usb3_pcs_tbl[] = { > }; > > static const struct qmp_phy_init_tbl sm8150_ufsphy_serdes_tbl[] = { > - QMP_PHY_INIT_CFG(QPHY_POWER_DOWN_CONTROL, 0x01), > QMP_PHY_INIT_CFG(QSERDES_V4_COM_SYSCLK_EN_SEL, 0xd9), > QMP_PHY_INIT_CFG(QSERDES_V4_COM_HSCLK_SEL, 0x11), > QMP_PHY_INIT_CFG(QSERDES_V4_COM_HSCLK_HS_SWITCH_SEL, 0x00),