Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp7416145ybl; Tue, 24 Dec 2019 02:06:15 -0800 (PST) X-Google-Smtp-Source: APXvYqxC3+dAlllWdiafuCopTmYs4+jZGAZYEz0q7GWks5zs3vV0CgppVV2+DfDH76JRmwWwJNRs X-Received: by 2002:a9d:6441:: with SMTP id m1mr19444918otl.310.1577181975809; Tue, 24 Dec 2019 02:06:15 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1577181975; cv=none; d=google.com; s=arc-20160816; b=NEvxvgLCeGuRMMejiJSMDLASV2OMzi5AwHZHeixjaMyA+F35ZkFxS/jOA8S9VlPqOF Sm+hx0BbnWw2zR73B2GJ9xH7Pp1oxO0QLOuSotJfp5IObR++xQ/ZSxvB+CCPT5YQkmAh C29zSQl6gVrCiW9hJixO5FCFiW0hYs3INbsKQ+KTzTXVD9k/vO3YueaeKoRM0dih7E/5 n7Xix2dK+6Su/zYnlRRYucx42kif9xxSedBrw9aeBYX+1leheKWlnkaFaO/naTfC5DA1 mDA9rn5dvaCQBf3PkHQrek65E+tJvjuCbceezNgbtZRrAgNrS7mv9BwnPKXMmJZF6l3+ xE4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=lZBp7WJCTDYPOomy6Za4skPEqciE2e9sbtVlgHLZuQw=; b=O9bwtrtzgiUoV+KG7wF8+suKikSLY1OS1Z10i7yX6iEEDLQeiBI1h/O+TPTO1k+iQU VrPQ0I0cvFi/KmpWyK4sVTrat1ebLsK7i/4qE2Cyl1H6Pww6eLWIzqb9uMVKaE45LFjJ b/QGJiMnqn6p4WmZJ7/CcS6oLnVexzsQszkotfkQzdYzERrSjbbQLR3eMN7gG+/8+ACs GNgG6ma5GFwpNFEu03V8dham6bXxQ+Gs9PYI0cjbbx5kMzywGOZSkvhCok0ys8Ypdbc4 qDbZyYH0bQZIf4kS2AOqRjGYW0tlhpie+SKxs8SHHu+YRMOoRugCsP5q/0k0yQkZnHPp NYdA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=F7NfYjT8; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a15si8139310otq.83.2019.12.24.02.06.04; Tue, 24 Dec 2019 02:06:15 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@alien8.de header.s=dkim header.b=F7NfYjT8; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=alien8.de Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726222AbfLXKEb (ORCPT + 99 others); Tue, 24 Dec 2019 05:04:31 -0500 Received: from mail.skyhub.de ([5.9.137.197]:39508 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726128AbfLXKEb (ORCPT ); Tue, 24 Dec 2019 05:04:31 -0500 Received: from zn.tnic (p200300EC2F0ED600E4E5C00CE9FEB53D.dip0.t-ipconnect.de [IPv6:2003:ec:2f0e:d600:e4e5:c00c:e9fe:b53d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.skyhub.de (SuperMail on ZX Spectrum 128k) with ESMTPSA id 47AE31EC0273; Tue, 24 Dec 2019 11:04:28 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=alien8.de; s=dkim; t=1577181868; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:in-reply-to:in-reply-to: references:references; bh=lZBp7WJCTDYPOomy6Za4skPEqciE2e9sbtVlgHLZuQw=; b=F7NfYjT8T7RuQTVZZX4JYza98gxXNuJUZSmRdHlZ12yiRY3KZJgYpmHVLQEFgOXjwQ5QCy 1MFaouSTNo2iWf5/mbdUyCgmtdmVAYiNH0Ulj8Ci2/PlEXzNg8dFZvEBKlzjSehTG9UuR6 3QEBi6606+OQuFC3xIJ5Ft4HG7Fk0eY= Date: Tue, 24 Dec 2019 11:04:23 +0100 From: Borislav Petkov To: Thomas Garnier Cc: kernel-hardening@lists.openwall.com, kristen@linux.intel.com, keescook@chromium.org, Juergen Gross , Thomas Hellstrom , "VMware, Inc." , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, virtualization@lists.linux-foundation.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v10 10/11] x86/paravirt: Adapt assembly for PIE support Message-ID: <20191224100423.GC21017@zn.tnic> References: <20191205000957.112719-1-thgarnie@chromium.org> <20191205000957.112719-11-thgarnie@chromium.org> <20191223172350.GH16710@zn.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20191223172350.GH16710@zn.tnic> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 23, 2019 at 06:23:50PM +0100, Borislav Petkov wrote: > On Wed, Dec 04, 2019 at 04:09:47PM -0800, Thomas Garnier wrote: > > If PIE is enabled, switch the paravirt assembly constraints to be > > compatible. The %c/i constrains generate smaller code so is kept by > > default. > > > > Position Independent Executable (PIE) support will allow to extend the > > KASLR randomization range below 0xffffffff80000000. > > > > Signed-off-by: Thomas Garnier > > Acked-by: Juergen Gross > > --- > > arch/x86/include/asm/paravirt_types.h | 32 +++++++++++++++++++++++---- > > 1 file changed, 28 insertions(+), 4 deletions(-) > > More missed feedback: > > https://lkml.kernel.org/r/CAJcbSZG-JhBC9b1JMv1zq2r5uRQipYLtkNjM67sd7=eqy_iOaA@mail.gmail.com Whoops, it is in the comment above PARAVIRT_CALL_POST. I must've been blind yesterday. Forget what I said and sorry. Thx. -- Regards/Gruss, Boris. https://people.kernel.org/tglx/notes-about-netiquette