Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp7482374ybl;
        Tue, 24 Dec 2019 03:26:13 -0800 (PST)
X-Google-Smtp-Source: APXvYqxapche3z8y1h/QZYQ0Cx9E5gf2Yd+XnkIgGkR1HoauQYjpa56ibaND6fI9HkC5v2Av9fxP
X-Received: by 2002:a9d:3a65:: with SMTP id j92mr38113462otc.37.1577186773269;
        Tue, 24 Dec 2019 03:26:13 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1577186773; cv=none;
        d=google.com; s=arc-20160816;
        b=UZcNdqfIZU9rVlWSKIIMsK4Tx6Wdl7RXGLtUS6G8tXVMEH5QBjUNMK4a5ymSLfEch1
         Sujtqs1BAwL3wYd0NUHja9oQ4oPySWXV44laIEsdmTYGFA4iVesHJiiYMPekdPvoXH9c
         aGpom41y9Wc3qLyhRaMnD1VfhEUZl6iOiOIXjdj4J/PKzlNwBwaG1wre7ZxK39ve3kbS
         kNqloj8QhXGk8FMpaki3zytFN8+pUmmvyVEsQ1h9MPNdy0gUGYG5vCJzcZqwXKRd0PMV
         uXrfeYVaNLcCW3WyEA96xzyvmv0Oa5+kJhb3+qx66gtmc5M38FF2tc6opYGXvg8Morlt
         OVyA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:in-reply-to:content-disposition
         :mime-version:references:message-id:subject:cc:to:from:date
         :dkim-signature;
        bh=RlgHb21b1QROs2UcIgO+a02Y6c38zuK0+5BmDk4rpWk=;
        b=lXOg10DhKp4Q3Xs6nINutUOy6J8uEhj34fv/7e5UEblTaBLT2qIBCirNuOqqktD1P+
         ZF0YisrltovrlMesmMPvEdm+lwVc9w9op1GJLNxT6D1lYaSYeY0XqeBzTWyL23e2sRl6
         McyiGmMtIP2QsgVrOmKUIwzZCinnuMD5jEWVUfX3IsTyug2B3tlMpkiyY3xlWS5EaivT
         cyIOH5dUwfuJrTrrvHcRkjmytwzk9XO6fxg+eGFSjS/NBr+D1etMSSOtcBdm6qgi+MkU
         omN5lmgeXQWifU/ajtY8Aw+6498LaGg9luymv65RrBIVDdSdKSIVBtakjKQE/dummX4w
         cXgw==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=fail header.i=@lunn.ch header.s=20171124 header.b=a634Z6nf;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67])
        by mx.google.com with ESMTP id s5si2830419oic.116.2019.12.24.03.26.01;
        Tue, 24 Dec 2019 03:26:13 -0800 (PST)
Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Authentication-Results: mx.google.com;
       dkim=fail header.i=@lunn.ch header.s=20171124 header.b=a634Z6nf;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1726225AbfLXLZX (ORCPT <rfc822;uzarths@gmail.com> + 99 others);
        Tue, 24 Dec 2019 06:25:23 -0500
Received: from vps0.lunn.ch ([185.16.172.187]:39140 "EHLO vps0.lunn.ch"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1726102AbfLXLZX (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 24 Dec 2019 06:25:23 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch;
        s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:
        Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID:
        Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc
        :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe:
        List-Post:List-Owner:List-Archive;
        bh=RlgHb21b1QROs2UcIgO+a02Y6c38zuK0+5BmDk4rpWk=; b=a634Z6nfsEg2DuTjgk0y38H9Aj
        eHijwgzBFVvP96OpECb5Qi7CryXjfxc8xCZzbzQ8aKE0zIlh1L2GIM57KkQ8BwqI2QUtgHxvll7BL
        o7m6Tg/te4WWhrENOytd67H6kHwxSAZsw1moLIcICSws6yrouXMsJ4y8bRpMA4UrGKgE=;
Received: from andrew by vps0.lunn.ch with local (Exim 4.93)
        (envelope-from <andrew@lunn.ch>)
        id 1ijiJP-0002Ib-2P; Tue, 24 Dec 2019 12:25:15 +0100
Date:   Tue, 24 Dec 2019 12:25:15 +0100
From:   Andrew Lunn <andrew@lunn.ch>
To:     Mao Wenan <maowenan@huawei.com>
Cc:     vivien.didelot@gmail.com, f.fainelli@gmail.com,
        davem@davemloft.net, linux@rempel-privat.de,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        kernel-janitors@vger.kernel.org
Subject: Re: [PATCH net-next] net: dsa: drop pointless static qualifier in
 ar9331_sw_mbus_init
Message-ID: <20191224112515.GE3395@lunn.ch>
References: <20191224024059.184847-1-maowenan@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20191224024059.184847-1-maowenan@huawei.com>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Dec 24, 2019 at 10:40:59AM +0800, Mao Wenan wrote:
> There is no need to have the 'T *v' variable static

What does 'T *v' mean?

The patch itself looks O.K, but the description should be better, and
the subject line.

    Andrew