Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
IronPort-SDR: hvsLMFnd7tHrJiqSfM+1rOSWUxtnpZpvdXzATacCljDV4MUroG8S1KJcgxeddapq60ob1vzTV2
 HeObGvetGmWw==
From:   "Jubran, Samih" <sameehj@amazon.com>
To:     YueHaibing <yuehaibing@huawei.com>,
        "davem@davemloft.net" <davem@davemloft.net>
CC:     "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH net-next] net: ena: remove set but not used variable
 'rx_ring'
Thread-Topic: [PATCH net-next] net: ena: remove set but not used variable
 'rx_ring'
Thread-Index: AQHVulkN8QLfJfz+AUa2ZbHSPtnTmKfJPixA
Date:   Tue, 24 Dec 2019 12:56:32 +0000
Message-ID: <64328693e17744688e90e49cecd11aeb@EX13D11EUB003.ant.amazon.com>
References: <20191224125128.36680-1-yuehaibing@huawei.com>
In-Reply-To: <20191224125128.36680-1-yuehaibing@huawei.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Good catch, looks good.
Ack, thanks!

> -----Original Message-----
> From: YueHaibing <yuehaibing@huawei.com>
> Sent: Tuesday, December 24, 2019 2:51 PM
> To: davem@davemloft.net; Jubran, Samih <sameehj@amazon.com>
> Cc: netdev@vger.kernel.org; linux-kernel@vger.kernel.org; YueHaibing
> <yuehaibing@huawei.com>
> Subject: [PATCH net-next] net: ena: remove set but not used variable
> 'rx_ring'
>=20
> drivers/net/ethernet/amazon/ena/ena_netdev.c: In function
> ena_xdp_xmit_buff:
> drivers/net/ethernet/amazon/ena/ena_netdev.c:316:19: warning:
>  variable rx_ring set but not used [-Wunused-but-set-variable]
>=20
> commit 548c4940b9f1 ("net: ena: Implement XDP_TX action") left behind thi=
s
> unused variable.
>=20
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
>  drivers/net/ethernet/amazon/ena/ena_netdev.c | 3 ---
>  1 file changed, 3 deletions(-)
>=20
> diff --git a/drivers/net/ethernet/amazon/ena/ena_netdev.c
> b/drivers/net/ethernet/amazon/ena/ena_netdev.c
> index 081acf0..894e8c1 100644
> --- a/drivers/net/ethernet/amazon/ena/ena_netdev.c
> +++ b/drivers/net/ethernet/amazon/ena/ena_netdev.c
> @@ -313,7 +313,6 @@ static int ena_xdp_xmit_buff(struct net_device *dev,
>  	struct ena_com_tx_ctx ena_tx_ctx =3D {0};
>  	struct ena_tx_buffer *tx_info;
>  	struct ena_ring *xdp_ring;
> -	struct ena_ring *rx_ring;
>  	u16 next_to_use, req_id;
>  	int rc;
>  	void *push_hdr;
> @@ -324,8 +323,6 @@ static int ena_xdp_xmit_buff(struct net_device *dev,
>  	req_id =3D xdp_ring->free_ids[next_to_use];
>  	tx_info =3D &xdp_ring->tx_buffer_info[req_id];
>  	tx_info->num_of_bufs =3D 0;
> -	rx_ring =3D &xdp_ring->adapter->rx_ring[qid -
> -		  xdp_ring->adapter->xdp_first_ring];
>  	page_ref_inc(rx_info->page);
>  	tx_info->xdp_rx_page =3D rx_info->page;
>=20
> --
> 2.7.4
>=20