Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Uladzislau Rezki <urezki@gmail.com>
Date:   Tue, 24 Dec 2019 19:49:40 +0100
To:     Joel Fernandes <joel@joelfernandes.org>
Cc:     "Uladzislau Rezki (Sony)" <urezki@gmail.com>,
        LKML <linux-kernel@vger.kernel.org>,
        "Paul E . McKenney" <paulmck@kernel.org>,
        RCU <rcu@vger.kernel.org>, Steven Rostedt <rostedt@goodmis.org>,
        Oleksiy Avramchenko <oleksiy.avramchenko@sonymobile.com>
Subject: Re: [PATCH 1/1] rcu/tree: support kfree_bulk() interface in
 kfree_rcu()
Message-ID: <20191224184940.GA16346@pc636>
References: <20191220125624.3953-1-urezki@gmail.com>
 <20191221232117.GA67625@google.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20191221232117.GA67625@google.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hello, Joel.

> 
> Hi Uladzislau,
> 
> Your patch is based on an older version of the kfree_rcu work. The latest
> version is in Paul's -dev branch. There is also additional work done in that
> branch as well "rcu: Add multiple in-flight batches of kfree_rcu() work" :
> https://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git/commit/?h=dev&id=e38fa01b94c87dfa945afa603ed50b4f7955934b
> 
Ahh. I see there are some differences and my baseline is wrong. I will
double check and rebase on Paul's -dev branch.

>
> Could you rebase your patch on Paul's -dev branch? The branch also has an
> rcuperf patch for measuring memory footprint automatically (memory footprint
> value is printed by rcuperf). Although I'd say try to use the latest version
> of the rcuperf patch by reverting that and applying:
> https://lore.kernel.org/patchwork/patch/1170895/ . I can then add your
> Tested-by tag to any future postings of the patch for rcuperf as well!
> 
I will do that and run all tests based on the latest code base.

Thanks for your comments.

--
Vlad Rezki