Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp8127315ybl; Tue, 24 Dec 2019 15:53:47 -0800 (PST) X-Google-Smtp-Source: APXvYqwKgi31EmCTHElTwZCBLaKKyVfKZfgYWVQHwAsb4QDjx9bvnqinWjN9MexFyxXsWVKCRtyo X-Received: by 2002:a9d:24ea:: with SMTP id z97mr42528048ota.345.1577231627696; Tue, 24 Dec 2019 15:53:47 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1577231627; cv=none; d=google.com; s=arc-20160816; b=G6A5ZLXpANqzxNLX1FtfxsALKu1DWKC104en+ec1hGldgBgKZaJQVY1+ieS+nlwoBL ttGkLSWS/f0hYdk4se2qPL92vqWZi+6rNC9IoAQ+dCY8aH5Zl3+ii+SrsNYlxh/xiJhH s4S772nW8FXEAJWNkMw4ZMfoMDmXWjTgjzcbICptH5oAM6L9iZwc0rwwOEl4nz3JUhxQ VfCXRRBoY1ddTr6mpALPW/+qReCfDEyv9KLExN+DSwzcKnMpcAapwJdtVwPntFaCYVSM i8APKiycSAP+uHh7oQgBBbfw6rCg3GsBZx3eVTFlArFCTKJ4CVDLNyCkEJiLCjEKkGRR 0tFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=wVeG4o2wMLfWamY/spW73kzHgOHGF8sCfwGnxV1QecY=; b=v/OEaKRnBWiVmvhRhXCdyJAlSFS9VgEm8+3LuSi7m9CT92bniKQpq7DtmswfUv/xH1 hRFX+Nu+m/DvXhFcov3MiY9fSnPhow3h4nh2itDxPB1gFEYEBMjHBtkL7n4Aae9UR2zl CgeEybrWE7tf1D2eY8V2JfYnvCNeoA9oboqMcpt3Y8vZBjeiSeRLGaS/F0iPapI6lfUi C3s2tnmXbW5BQG9HsdfSrLGN1qJCmPNKZOQkPdgnWOMK3b8jcXq6il4MZ/fwaVtMuElS um21sGQaYgvfEqGxhRCIlZuG/zOt/fzE/pluE/kVPrXrPZvr2Kx+Ef+1RW0iLa0oK8LS J6Lg== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=Qqn84oRL; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t25si1936056oth.246.2019.12.24.15.53.35; Tue, 24 Dec 2019 15:53:47 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=Qqn84oRL; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726559AbfLXXwH (ORCPT + 99 others); Tue, 24 Dec 2019 18:52:07 -0500 Received: from heliosphere.sirena.org.uk ([172.104.155.198]:60882 "EHLO heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726237AbfLXXwG (ORCPT ); Tue, 24 Dec 2019 18:52:06 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=wVeG4o2wMLfWamY/spW73kzHgOHGF8sCfwGnxV1QecY=; b=Qqn84oRLhfEoicUtxn8KgThtq ekIL2BYMpXYFkDWCTQa3OkwsKbFICnezYVm5bxWhwismS5YCDkoRJSK3Gjt4AzP0ZPqHh7GgBJ90Z 1OjPgDhJpjrvi/XL0xlQRXwvVd91R79HneYLVJhdhyFMiEm9G14s5vKQgfqcz29GZO954=; Received: from cpc102320-sgyl38-2-0-cust46.18-2.cable.virginm.net ([82.37.168.47] helo=fitzroy.sirena.org.uk) by heliosphere.sirena.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ijtxr-0007BU-Pt; Tue, 24 Dec 2019 23:51:47 +0000 Received: by fitzroy.sirena.org.uk (Postfix, from userid 1000) id 9EAB1D01938; Tue, 24 Dec 2019 23:51:45 +0000 (GMT) Date: Tue, 24 Dec 2019 23:51:45 +0000 From: Mark Brown To: =?utf-8?B?amVmZl9jaGFuZyjlvLXkuJbkvbMp?= Cc: Jeff Chang , "lgirdwood@gmail.com" , "perex@perex.cz" , "tiwai@suse.com" , "matthias.bgg@gmail.com" , "alsa-devel@alsa-project.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] ASoC: Add MediaTek MT6660 Speaker Amp Driver Message-ID: <20191224235145.GA27497@sirena.org.uk> References: <1576836934-5370-1-git-send-email-richtek.jeff.chang@gmail.com> <20191220121152.GC4790@sirena.org.uk> <7a9bcf5d414c4a74ae8e101c54c9e46f@ex1.rt.l> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="SLDf9lqlvOQaIe6s" Content-Disposition: inline In-Reply-To: <7a9bcf5d414c4a74ae8e101c54c9e46f@ex1.rt.l> X-Cookie: I have many CHARTS and DIAGRAMS.. User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --SLDf9lqlvOQaIe6s Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Dec 23, 2019 at 02:10:12AM +0000, jeff_chang(=E5=BC=B5=E4=B8=96=E4= =BD=B3) wrote: > --> When I check other driver at sound/soc/codecs/ folder, I just follow = what others do. > It seems in .h --> /* SPDX-Liencese-Identifier: GPL-2.0 */ > In .c --> // SPDK-Liencese-Identifier: GPL-2.0 > Is it correct? Yes, headers use C style comments and source files use C++ style. --SLDf9lqlvOQaIe6s Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl4CpI4ACgkQJNaLcl1U h9DFVwf7Bvj8SH/istxSwNkLQ2Tr1SMqR95oagZSg6cNQ4V31uLCUSK/oD+TYaO/ 4JjGHrPKLlwBKweT/nJ6nOX9/YcS1N7hvb5bOwK2dbcpsNb0BmkuDC+fy4sEXqfY KyMmaYgN7+lkV2bYC7Y+x3FtZHs3IScuvGLk5pDp4NqXJddKTMEljQRdegtPDP3N sAzfTrBMczPhnb320cF+yBQk5xSGCrez8FAJPlpGiaS1TkuHMr4CczYtSgO2qCKW DYRLizqBUbJ0l8FkHW87f1YY8KdF4GKig5ihIiF8BQ4Vz7IiNTXiDC9eaayD/V71 hchxd/+izG1UhhEmm6NiVOIuyyUl9w== =YYW7 -----END PGP SIGNATURE----- --SLDf9lqlvOQaIe6s--