Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp8142764ybl; Tue, 24 Dec 2019 16:10:14 -0800 (PST) X-Google-Smtp-Source: APXvYqwxqxC9Wb4UgOsPlnfU9CQ1deKiIdf9vzcoU41s7rtRkCl6uNjf/LjnarhItGVXbQN4wg1t X-Received: by 2002:aca:4106:: with SMTP id o6mr1336600oia.173.1577232614227; Tue, 24 Dec 2019 16:10:14 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1577232614; cv=none; d=google.com; s=arc-20160816; b=oNa1vuKCGv3wzChGrcz8fcmVJSMe84jQwjGK1f9S8FzuXP8nbqiG5Dzy1MQRV7YkwV Cxw3on6jHfuU8KhwV0vWcAv+fb71FfbEdA3ZKN9xRjPUpQpy9dbOWUazZWZ+3DZeTr8F cDKHIaUEY+9PV/b6JPOA6oJJDR+72eyX5xFiZfeeisJsehaZ6Hvn8Rn3oGZbJ8Fwhaei zWP7KA4oYUeGA30lJz90FtSnbsPbV62y18zBwStIP1Ari1lKTxQARbH/b17du2uzx++Q wuyZGtDcFPi4/5/I9Gs4gM2qjWSb0SstTBcDtaf+Vb04a60uqrDfdkUMD5pg3LOlovdd l6GA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:message-id:in-reply-to:subject:cc:to :from:dkim-signature; bh=ZAC+d2JhJHnHloKpHt3+Xps6PellG/fLmAlbtuVbLVU=; b=D564oNmcWiboXtEwG97gDggFifH0O+md9Z2bSZk/tOIl9Ju7R5b649onrebPXYsAfN CIdkToFGeYLWSBvYyiB29oNbEwB01z3/qELf1plGrWAHOPoNOGhiq54VA9BCTenIxY10 nXK6NDreTvtSytMnKav+dbnD+8Nu69dIVkepYU/B11H2lfft3i42Bwz9Jy4Xl7IcdvjS v7oStZE7HL1Qhe/wkXOchDU4RumHcTtnblhFI5jmDKgB1XeC8T40nUX6I55RcEMUx7s4 h3/G2rHBGkaaeAx1V/svdVzQOQkAcE4WZKuC9gIcuNafiYY+0qOzeh8uCxwt39Qz7ZJq bmiQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b="bRt/n1MC"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r1si12606716otn.150.2019.12.24.16.10.02; Tue, 24 Dec 2019 16:10:14 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b="bRt/n1MC"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726997AbfLYAJR (ORCPT + 99 others); Tue, 24 Dec 2019 19:09:17 -0500 Received: from heliosphere.sirena.org.uk ([172.104.155.198]:33412 "EHLO heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726352AbfLYAJO (ORCPT ); Tue, 24 Dec 2019 19:09:14 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=Date:Message-Id:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner: List-Archive; bh=ZAC+d2JhJHnHloKpHt3+Xps6PellG/fLmAlbtuVbLVU=; b=bRt/n1MCrO/u xCRVANLJ6/mrTO6xb79b49qi0iI5agKkGFWVD0uD8ka0JAabDUX8Mziun4Vnwg6rZFc+ifcZjTNc1 IkaLM+fqNt3PcvicCGJMYiNLA/6xcu1cUvsd6VPvRIVriCjEq92WZb1NqBMnmZEWKS0rP78ZSs33I Ik8ak=; Received: from cpc102320-sgyl38-2-0-cust46.18-2.cable.virginm.net ([82.37.168.47] helo=fitzroy.sirena.org.uk) by heliosphere.sirena.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ijuEa-0007Ld-4Y; Wed, 25 Dec 2019 00:09:04 +0000 Received: by fitzroy.sirena.org.uk (Postfix, from userid 1000) id 9713CD01957; Wed, 25 Dec 2019 00:09:03 +0000 (GMT) From: Mark Brown To: Olivier Moysan Cc: alexandre.torgue@st.com, alsa-devel@alsa-project.org, broonie@kernel.org, lgirdwood@gmail.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, Mark Brown , mcoquelin.stm32@gmail.com, olivier.moysan@st.com, perex@perex.cz, tiwai@suse.com Subject: Applied "ASoC: stm32: spdifrx: fix input pin state management" to the asoc tree In-Reply-To: <20191204154333.7152-4-olivier.moysan@st.com> Message-Id: X-Patchwork-Hint: ignore Date: Wed, 25 Dec 2019 00:09:03 +0000 (GMT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The patch ASoC: stm32: spdifrx: fix input pin state management has been applied to the asoc tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark From 3b7658679d88b5628939f9bdc8e613f79cd821f9 Mon Sep 17 00:00:00 2001 From: Olivier Moysan Date: Wed, 4 Dec 2019 16:43:33 +0100 Subject: [PATCH] ASoC: stm32: spdifrx: fix input pin state management Changing input state in iec capture control is not safe, as the pin state may be changed concurrently by ASoC framework. Remove pin state handling in iec capture control. Note: This introduces a restriction on capture control, when pin sleep state is defined in device tree. In this case channel status can be captured only when an audio stream capture is active. Fixes: f68c2a682d44 ("ASoC: stm32: spdifrx: add power management") Signed-off-by: Olivier Moysan Link: https://lore.kernel.org/r/20191204154333.7152-4-olivier.moysan@st.com Signed-off-by: Mark Brown --- sound/soc/stm/stm32_spdifrx.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/sound/soc/stm/stm32_spdifrx.c b/sound/soc/stm/stm32_spdifrx.c index 3cb8e6db3eeb..3769d9ce5dbe 100644 --- a/sound/soc/stm/stm32_spdifrx.c +++ b/sound/soc/stm/stm32_spdifrx.c @@ -12,7 +12,6 @@ #include #include #include -#include #include #include @@ -484,8 +483,6 @@ static int stm32_spdifrx_get_ctrl_data(struct stm32_spdifrx_data *spdifrx) memset(spdifrx->cs, 0, SPDIFRX_CS_BYTES_NB); memset(spdifrx->ub, 0, SPDIFRX_UB_BYTES_NB); - pinctrl_pm_select_default_state(&spdifrx->pdev->dev); - ret = stm32_spdifrx_dma_ctrl_start(spdifrx); if (ret < 0) return ret; @@ -517,7 +514,6 @@ static int stm32_spdifrx_get_ctrl_data(struct stm32_spdifrx_data *spdifrx) end: clk_disable_unprepare(spdifrx->kclk); - pinctrl_pm_select_sleep_state(&spdifrx->pdev->dev); return ret; } -- 2.20.1