Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp8262583ybl; Tue, 24 Dec 2019 18:38:39 -0800 (PST) X-Google-Smtp-Source: APXvYqyOfYRMCIha0Xf9nS6XV5YSgBjLx/Jrl4AC/yNuUXyRT8wDp2jzZec1ieeKggeichEReiKU X-Received: by 2002:a05:6830:1353:: with SMTP id r19mr42876363otq.288.1577241519403; Tue, 24 Dec 2019 18:38:39 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1577241519; cv=none; d=google.com; s=arc-20160816; b=eOx//A9vjJHM73lfANVVeTNPfjsYg1Qa8B2eJ87NdMngsM6jkScKDO98oGvX4KXbTP EWuWw2IeSXqOOcAarWRtF1lsRdD6aucd/YCYtx/kMpaP7SCmvvsxPJWWBb5dX8XrBnlA EuxkeJv0+K7UcR8/cIsw26s50GL/klwsbedKwKTGdAsc4oqXquI059/8reUvys5VpBEr 2KFMksLB88NaYg1Z/OLp/sC4DuxtGBKXdJYvPAFW7MQwQv+8AarusMNP7gvt044KF55V hRSAPghB5qcG6BpLJXt8jaGri9MPwp3xReRqqtLiu7YknI/V26k2W8c8dTuZ1t8uCXaZ sCtg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature; bh=pdIbOs3lDS1y4SwDmDRq4hIBgk7hg9mVWHE7Ddel5uU=; b=Fj2pzni+EGX5mhcwHQ4SCoDDMFOE0qbnRvtJVhGkyHoR6RbrmMDT9je2XH83R9CaVN cAXd0uPldbiQjojEvvTZIenW1j0zEq8o5X3QE7xa0jxQSIb40NSg3ZGz5BJVzHBAPIZN +lHCNnms4sbYMXTJjMVc5RoaMeLpiLbsocV+S6DVAElDcgh64vLJBmbfiEOaDgo2NT0+ sGtVR5x43yViQgWN6ZGnVRtS0Rlb7JBJ/BlYjiAZCO0109d3YnPk5UHE0El7PMrj3tVc YaC7vsWByvEsA7nglx/sa4U02Or5HhcWFKVCjviQZ6DE4tEXL0wAg7okCJPDm+olJdOH hfIA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=dnV1PVKt; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c19si5317307oto.129.2019.12.24.18.38.18; Tue, 24 Dec 2019 18:38:39 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=dnV1PVKt; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726316AbfLYCgx (ORCPT + 99 others); Tue, 24 Dec 2019 21:36:53 -0500 Received: from mail-pj1-f66.google.com ([209.85.216.66]:34950 "EHLO mail-pj1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726258AbfLYCgx (ORCPT ); Tue, 24 Dec 2019 21:36:53 -0500 Received: by mail-pj1-f66.google.com with SMTP id s7so1895352pjc.0; Tue, 24 Dec 2019 18:36:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=pdIbOs3lDS1y4SwDmDRq4hIBgk7hg9mVWHE7Ddel5uU=; b=dnV1PVKt2H+CsjlMYnYLbstb7q7F2tr2GthayCFodUykVCzuV3+rJuxSKxewzZDEfS +fpWJye1uNAyPx2619mh1RhTj+PIVRXpATrD6ootqBJ3hL5A3C6WL0EhUt1t5PcDOywV HODmZkrvchjgUdAE4tFFgH+HiIBY/B3FEbnxTEuN7OCyqEeu5pezOYwNqk9Wh5c2JM06 /hjjTtT7sWGxt/z+8jlxyGU3VMigiP1yePUyJPrjAFAddkl9LT/GeG0IkagmcuZJn6R2 Y95iL4CYmQ1Ny6chVsIntCfHRHuq52pWlF68tPPrUw/2x46pPhV0WYgAzM0dA6RZW8pF 04Pw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=pdIbOs3lDS1y4SwDmDRq4hIBgk7hg9mVWHE7Ddel5uU=; b=qsC3ATkYvGLtO+KmYl0W/SMPCLj45/OQ54IBHnSL5JCsAKC1Y8pcUZisvFVK9MD/xN olX+gKRL5eV/ZKhgL05LrYupvGJ/SdfWUB3V7SpqncUeawDcwsT1N2kHbDln2fKFNF+V VpQ65swxM6sFbu9HzX0NzltBVo3XlGaMxMPHypD6ByB+jW5d4kuK1vnGCvqkLQDcUZI7 OiBI0Om2+ZN7aaRMTXKGx5w7JqPPwr2XYf7m+WMgfwdWRBuOSHliTEAs/a/CviAPNFFE 7x5jqiOmqmlAQUBnqsOKp30fFtPbr5pX4rc/5kmtuH+0fau8DmeP/EY07zJLn4Ej2AGX gJdQ== X-Gm-Message-State: APjAAAUvHJluv75J4TLOYdeiJ02mKLKvz01PGzYbfwaqiSIfKqvlrLuu 8yUre0BPCynQKwv7f+aFt4c= X-Received: by 2002:a17:90a:930f:: with SMTP id p15mr10170606pjo.2.1577241412487; Tue, 24 Dec 2019 18:36:52 -0800 (PST) Received: from localhost.localdomain (114-34-112-171.HINET-IP.hinet.net. [114.34.112.171]) by smtp.gmail.com with ESMTPSA id u18sm27245406pgi.44.2019.12.24.18.36.50 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 24 Dec 2019 18:36:52 -0800 (PST) From: Jun Chen To: laurent.pinchart@ideasonboard.com Cc: mchehab@kernel.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, ptchentw@gmail.com, Jun Chen Subject: [PATCH] media: uvcvideo: Fix annotation for uvc_video_clock_update() Date: Wed, 25 Dec 2019 10:34:17 +0800 Message-Id: <1577241257-9203-1-git-send-email-ptchentw@gmail.com> X-Mailer: git-send-email 1.9.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jun Chen The formula (2) is to convert from SOF to host clock, it should be fix as "TS = ((TS2 - TS1) * SOF + TS1 * SOF2 - TS2 * SOF1) / (SOF2 - SOF1)" Signed-off-by: Jun Chen --- drivers/media/usb/uvc/uvc_video.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/usb/uvc/uvc_video.c b/drivers/media/usb/uvc/uvc_video.c index 8fa77a8..a3150da 100644 --- a/drivers/media/usb/uvc/uvc_video.c +++ b/drivers/media/usb/uvc/uvc_video.c @@ -622,7 +622,7 @@ static u16 uvc_video_clock_host_sof(const struct uvc_clock_sample *sample) * to avoid losing precision in the division. Similarly, the host timestamp is * computed with * - * TS = ((TS2 - TS1) * PTS + TS1 * SOF2 - TS2 * SOF1) / (SOF2 - SOF1) (2) + * TS = ((TS2 - TS1) * SOF + TS1 * SOF2 - TS2 * SOF1) / (SOF2 - SOF1) (2) * * SOF values are coded on 11 bits by USB. We extend their precision with 16 * decimal bits, leading to a 11.16 coding. -- 1.9.1