Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751054AbWAYGlB (ORCPT ); Wed, 25 Jan 2006 01:41:01 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751055AbWAYGlB (ORCPT ); Wed, 25 Jan 2006 01:41:01 -0500 Received: from MAIL.13thfloor.at ([212.16.62.50]:46554 "EHLO mail.13thfloor.at") by vger.kernel.org with ESMTP id S1751052AbWAYGlA (ORCPT ); Wed, 25 Jan 2006 01:41:00 -0500 Date: Wed, 25 Jan 2006 07:40:59 +0100 From: Herbert Poetzl To: Jan Kara , Linus Torvalds , Andrew Morton Cc: Linux Kernel ML Subject: [Patch] quota: fix error code for ext2_new_inode() Message-ID: <20060125064059.GA3778@MAIL.13thfloor.at> Mail-Followup-To: Jan Kara , Linus Torvalds , Andrew Morton , Linux Kernel ML Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit User-Agent: Mutt/1.5.6i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 796 Lines: 32 Hi Honza! the quota check in ext2_new_inode() returns ENOSPC where IMHO it should return EDQUOT instead. here is a trivial patch to fix that ... rationale: ext3, reiser, udf and ufs do similar checks and already return EDQUOT best, Herbert Signed-off-by: Herbert P?tzl --- ./fs/ext2/ialloc.c.orig 2006-01-03 17:29:56 +0100 +++ ./fs/ext2/ialloc.c 2006-01-25 07:26:42 +0100 @@ -605,7 +605,7 @@ got: insert_inode_hash(inode); if (DQUOT_ALLOC_INODE(inode)) { - err = -ENOSPC; + err = -EDQUOT; goto fail_drop; } - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/