Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp8679888ybl; Wed, 25 Dec 2019 04:07:17 -0800 (PST) X-Google-Smtp-Source: APXvYqwNwRW9fpVo2xRn7HKPPa4j5nGmjkKhNiqWR2fG+KtKqjZxSrj0YiULzZy0tzRccPqmbV+s X-Received: by 2002:a9d:6481:: with SMTP id g1mr45388620otl.180.1577275637220; Wed, 25 Dec 2019 04:07:17 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1577275637; cv=none; d=google.com; s=arc-20160816; b=iPUA3KH/bNucjStDhttW1HQKhrcR4LcljqC3yfQxkQFSp3psCcWjKF/nV+geXDcit8 457m98SDAj5CDwYXJvwizcMQM4WcSVDZhwoOcwV9j3IgSFHdQrwoJSL6Ie9OMXE26aew ER2i1O7R2tR7GMcILUX+95Db1UHI8h7PW/lOlBzLWtN/p0MxFK5uETvo+Iaf7S7Smu/0 1pemnDGueGGOHdwORyJwVf3opjfiLRWmoCYkZWFi8rxD+LqdelJyUB9ecbfAcho4Yks/ GsSBmC8DBbh5hlVLtAmvkkvk882hsxNZEBNQVMOfWhfRWRW2JV5TVNuDRzrVZdL4a9Dx Fw4w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:autocrypt:from:references:cc:to:subject:dkim-signature; bh=DTT8QnXe0lhOsmN9ANSBHC1/T8Mi6PUOXnDRXRuVz5Y=; b=urKVQPNKbcqKUBkTYBLyOO4fgOdItfcI9TTCR0vmE4JdXIoS76B2rP77HwZShwCDYH 1JccNIY3v+7vAd6E9pf3OQWTTtekK+JET9gTl4P23YdKmvphYWnSj9kxRuYNutatR+LR GFyUJE4/3/SEpq1XQOP/8Bhg7dxIhNa/H1woUueAklhkvIDuML+bOBGZIBqU/2dlxinu GxDY4LhHnI32qKL6lWvzMCC1wVRnKTo4LluCObAYtvxJnlSbqEZ8Fwtjj+u4kdPQez5D l9gkMuQvckHRrTWy9u53r6dEFuOrm3yXJoNTAKIOgdUQCbmUTKLMaDH9dff+t8L5AIvO cUaw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@dawncrow.de header.s=strato-dkim-0002 header.b=XwEdLxI5; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g5si14620548otn.232.2019.12.25.04.06.53; Wed, 25 Dec 2019 04:07:17 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@dawncrow.de header.s=strato-dkim-0002 header.b=XwEdLxI5; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726415AbfLYMFi (ORCPT + 99 others); Wed, 25 Dec 2019 07:05:38 -0500 Received: from mo4-p01-ob.smtp.rzone.de ([81.169.146.165]:28299 "EHLO mo4-p01-ob.smtp.rzone.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726307AbfLYMFi (ORCPT ); Wed, 25 Dec 2019 07:05:38 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1577275534; s=strato-dkim-0002; d=dawncrow.de; h=In-Reply-To:Date:Message-ID:From:References:Cc:To:Subject: X-RZG-CLASS-ID:X-RZG-AUTH:From:Subject:Sender; bh=DTT8QnXe0lhOsmN9ANSBHC1/T8Mi6PUOXnDRXRuVz5Y=; b=XwEdLxI5OLWpILC+7sJdszyfi80sPWmu5JfZio3LsDYpfXOd3AhtqfeXN2o2e8chqC axoJAP6DRbEGibr2OwfnR3fCDSsEVhzPH03F+8fALNCt4X0O7+/xg1qx+97/V3JMkOn+ AQuTbWmrGTjhl3e28M9UmpZTjGtnckTtUBSmnWxO7ju72iuOOMxqtI9x5GKBR2Jcjuox 02G43txC/iZNbOxy+TwDOyNTTnpwuXx3N/o2wngi/DX9dx1IYrxQwytaOtUG3LAuapXH raJ66JPSkX6klRGHZp5jADzUyoUGHS2iJh6u3pKk5d7JZyTzpnW1Tj+c2zap2+6fdjYQ Gegg== X-RZG-AUTH: ":ImkWY2CseuihIZy6ZWWciR6unPhpN+aXzZ6bi4rK0b8tGDimOzIxQbIOZSqtgWHzDs8=" X-RZG-CLASS-ID: mo00 Received: from [192.168.178.40] by smtp.strato.de (RZmta 46.1.3 DYNA|AUTH) with ESMTPSA id I099d1vBPC5I4Uz (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256 bits)) (Client did not present a certificate); Wed, 25 Dec 2019 13:05:18 +0100 (CET) Subject: Re: [PATCH] ARM: dts: Add omap3-echo To: Tony Lindgren Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, linux@arm.linux.org.uk, linux-kernel@vger.kernel.org, robh+dt@kernel.org, bcousson@baylibre.com, linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20191224161005.28083-1-nerv@dawncrow.de> <20191224184503.GK35479@atomide.com> From: =?UTF-8?Q?Andr=c3=a9_Hentschel?= Autocrypt: addr=nerv@dawncrow.de; prefer-encrypt=mutual; keydata= xsDNBFN7n6MBDAC0neZ/lrjWZzrvVeO7bc70o4xze8gj5q1mb9Zr0ilxXWyo2hm5oZWt8Wf/ oCrDQmR49Be2VZMbruYp3YK+GmbYxi6R+nkEb+KZ7OAaHx6VcCpdtb3iEMfjsJCO6vD3phS9 C9JS++C3dKxallSdJrhYvU6eMJITW21eRZ112d12zNeCODGpMJ5Cwm0TQhQwI9dK7wPUPGNj GeuTqQp0cuIQswHCK0zy5Y6Xm8P7i7Au+cWEuiZuZ7iiTT9ycklUmuA/owWZRkd39DgwxfDh PV7vrAD9jNH8Kl5T8m54KQhgg+A+OiBZ/ugEWJeWwqJjs6RBIoECXO4GtNhQiD827PigeEm3 YE5iIjGygJE/1PPO3vmrVYrwn7fGTZJUFn97k4TROijNqj6fr2DLLEbW3Oj+B8vcxlxZGqze yU3qQUHCpukxVCwlFUEKI1OOvraB5rQRDRS/y28tI5IkKTycX9bjBq5FCEhLO9ErewRJsXyZ ff68fqX8CPUxGFUSGPPgmj8AEQEAAc0jQW5kcsOpIEhlbnRzY2hlbCA8bmVydkBkYXduY3Jv dy5kZT7CwPgEEwECACIFAlN7n6MCGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEGm5 GZTakYsskf8L/iFSlooD4kELDwXTRglHDxtzrgdN3kEjLd9RcW/AI1/HFlQlk5vk+0Ys1LZK 2kdBmm51qI6SbVG08wUZk4y/yLHlV2QbhfDcR5YfobHhB0XlJGMJ4vQw/GxVLlTa6CjP4aOb jpRCdhW2X3eRnmBsjCJ3TJLa9YWgmjH7PcVkXc84uSntQl17pmnbmLkBS9xa63Vt5YYe9G5i mT2qZn+2IH3Jcu8gYTURR5j6PuBrmjWc7M2pEY3LXHYpTEIS96Y4ZOan7LhAYTgBFEU7Mt2m BZX+BssyGKl4TKXwq6bHDg2tIJ8NzZ5ScERQjauUR+Dw11wxFc2KJFtrF2cnkdwVp9YWkGwJ iLbRTlfxjit/af3WO2c8DZsF+IyWVs/GzhMPYQ/Tdy2Z6xAj8hmtYeKO5erUNgeiNWh3keHq JQgfnVTgwNOHBTDC38/0B+FcgLDKiBtNrk4pqBsQEG2ab+ca3a/x6AIGX0KKuyJKv8toNXxO IsaDmTF1DbykjI1sQ98KQc7AzQRTe5+jAQwAz7GXGpdsZp1rU4cf87mDejTqxcSzVdw8KTQg 4baCC7sHY7QbJ+vhCminxVaWqxy1HuMGD/njDFB4h+ke2nfghjPRvfpOuDG/MRGmwchEuIQt wbpHVmimNL3ewxWaUpcjF/QAYhfXumGUefU1rLzmLlYvZoVUsoTemPFjB2wvJRW/PdKmN1nh pihT+AMIfyI4W0rcRFRSNgoACbj5PC7Fw3jNewVK7DreLvvVFdANA7NppT8dkuwj5MMpX/2b fLznagJMp++cXPTg9eSnUHL0ACIsUfcajuTG2KGeKJi84H5usKfzKK7IXvIsEvqqbSCA4ocZ Q55nrlmVsyfgmWUIuYA791a3exFEiDpeTRiDyP0bQUdkp7grwMFFFK09peU/EjgYGqAqEoxq fgkihY57PqDlbL9cZeZ3nns1PLwiyf9ZhcrDffe0Otm/Jad07UIz/GFr9bgMSi+ugNyQlEko ZQgLq0PxbL5GwK9XP5iBW90/nIW+Dkve7jZmfvm6AShHABEBAAHCwN8EGAECAAkFAlN7n6MC GwwACgkQabkZlNqRiyxzOAwAq9KfzyGLvcHStmVVqqLOx2DWEYL+erNcn2e3DdFhempLfH05 sUKx6SbgPn+EgQCkKCM81juW9vpJdKhERG6Bc627d5nCMH8BNp4v8SzeKY04uodjLe2V2uX1 KY7kn8llWbMdwJP50w71KP4lI841Kba0fHVy+nerPATgwGTyS02OwiM3XWUfOiLJtpPxt7u2 IVXGVde+hhvra2bhnW22g0gzGAL4qwjJz7XIpjpwHlUO7y8DuczaQd6rrCwMYwrbnKFxoLHU Ao05Mi5DD9JRT2Hi7Z85ZNW8fxR2wumzsTFTQNgdGEmUTcJQsMVQQ77syk/C3ViL+I617MuU Wc89hbJwEvglcs1BVQ8T+HGc2nOCvJCDDO7KZE3szTAkypU82TsK0UkJwdePyD3QGYfeARKg 643Y1Si/C9Ir3JXrKHqA10I2U77hVDzDGC9EAm2qs4DDkQdWVmuIP7DWQNgOPWpvCQECEwcA BZtrxq8dmex7tFXvQoJV4PIa20fGXq6S Message-ID: Date: Wed, 25 Dec 2019 13:05:17 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <20191224184503.GK35479@atomide.com> Content-Type: text/plain; charset=utf-8 Content-Language: de-LU Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 24.12.19 um 19:45 schrieb Tony Lindgren: > * André Hentschel [191224 16:11]: >> This is the first generation Amazon Echo from 2016. >> Audio support is not yet implemented. > > OK looks good to me, just worried about one part: > >> +&sgx_module { >> + status = "disabled"; >> +}; > > We should have a separate am3703.dtsi or whatever the SoC model > disabling sgx if not there on the SoC. That way board specific > dts files can just include it without having to debug this issue > over and over. Thanks for the quick review in that time of the year! The sgx issue came up in newer kernels and I had to bisect it to 3b72fc895a2e57f70276b46f386f35d752adf555 The device just wasn't booting without a message, so yes, we should make it easier for others to figure it out. SoC is DM3725 and only DM3730 has sgx support. And it's hard to say if the base is am37xx or omap36xx. But I see the reasons you picked am3703, so I would move everything from omap36xx.dtsi to am3703.dtsi except sgx? And then include am3703.dtsi in omap36xx.dtsi before sgx support? Or would it be better to have sgx support in a separate dtsi?