Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp8944587ybl; Wed, 25 Dec 2019 09:48:24 -0800 (PST) X-Google-Smtp-Source: APXvYqxz0dilDvofT5KQ1WnSz2HIqIVvqdqEwR01yxwTCHjBwwSUKYbvFav+eiH24/TPLDNhHJpG X-Received: by 2002:a9d:7cd0:: with SMTP id r16mr47697350otn.50.1577296104697; Wed, 25 Dec 2019 09:48:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1577296104; cv=none; d=google.com; s=arc-20160816; b=q3ajOlYnnfzxMAMjXaNBVam2U4tri23Qr5jgEH7IIAsl7E0kcF9LW6Vkdh2lGGH98c cws8vkiZIkZ0eOa4C1h466IDn8WBuzLL3KC1YoKeAZPAgrD/9/1G8ANqsHUsZ2XFcVi4 X+TPffgLTabXfVpoWi2h9jstj9QTXgQd7I8cczhyJyS/CbFs0jB2oNtD6i8Sh2fE8oye Bz0xQwnFzLi/IH3dlL4Ag2KhvRYqcAPg2Bnmcx1hUCFM3S4P5B5a8twegTQ7VDwH5Z59 qD46Tr+vFABTCgo1Fy7pglnRPVExjbv0cddfeS2Yb2nlTfYLPRO74UEPz6Sh5T5CCRm/ y2yg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=sqZ9HRtCdnjD8DXcSEjuElmOGdM4XxRfBfU9GjfcdkE=; b=l+EHF5qn6vqDzqVE3BUxnu1Q76u/aMjesHz3cTxMh49hYm19rSqq29WGZi/wyxmQ++ Ds2d/l/UdJ14NWaEmNEMDH7XeU1pd9uPsopjtxeM/azrw+a7BRJXP2416++ccjmOOdQj AmH0Bo1/7NpMA/Hk7OF4OiNd0wxl7pU4qEgkjE50zrWAgi0uuFFPaG4eOBLGmyQqg10l NW/uzgrEWcea1Lma31DJ1WBF4tSHSpNesx7DzxE+sJws1x34dwXzvxRZM2evCwA9AcNZ 0Cs7toZEOP1Z+5lVEhLi5ONPx1SjDPZp3smdICkIOXq19cQKWjm857byAN9w/1tLBy5s wlTQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=xh2L9IAY; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v5si14748550otn.155.2019.12.25.09.47.51; Wed, 25 Dec 2019 09:48:24 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=xh2L9IAY; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726435AbfLYRpl (ORCPT + 99 others); Wed, 25 Dec 2019 12:45:41 -0500 Received: from heliosphere.sirena.org.uk ([172.104.155.198]:58060 "EHLO heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726353AbfLYRpl (ORCPT ); Wed, 25 Dec 2019 12:45:41 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=sqZ9HRtCdnjD8DXcSEjuElmOGdM4XxRfBfU9GjfcdkE=; b=xh2L9IAY8F6aToclrkfPNsiKO R8JsvHw7bcWKqp0cboXhHjwtyrucBbi1vATkutReqRA4LzuzYDlH02xLmnb8ciFJWajJdZIgafPTZ U/yVAsVzL3fUesDItZipgPIS4Ije67vI/Ktfkce9tGLz6u/jKaG116BPMHbDjrM8DMOXU=; Received: from cpc102320-sgyl38-2-0-cust46.18-2.cable.virginm.net ([82.37.168.47] helo=fitzroy.sirena.org.uk) by heliosphere.sirena.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ikAiu-0001hl-Qx; Wed, 25 Dec 2019 17:45:28 +0000 Received: by fitzroy.sirena.org.uk (Postfix, from userid 1000) id 14D67D01A22; Wed, 25 Dec 2019 17:45:27 +0000 (GMT) Date: Wed, 25 Dec 2019 17:45:27 +0000 From: Mark Brown To: =?utf-8?B?amVmZl9jaGFuZyjlvLXkuJbkvbMp?= Cc: Jeff Chang , "lgirdwood@gmail.com" , "perex@perex.cz" , "tiwai@suse.com" , "matthias.bgg@gmail.com" , "alsa-devel@alsa-project.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] ASoC: Add MediaTek MT6660 Speaker Amp Driver Message-ID: <20191225174527.GB27497@sirena.org.uk> References: <1576836934-5370-1-git-send-email-richtek.jeff.chang@gmail.com> <20191220121152.GC4790@sirena.org.uk> <7a9bcf5d414c4a74ae8e101c54c9e46f@ex1.rt.l> <20191224235145.GA27497@sirena.org.uk> <938f562e322849328d5a7782b2c1de97@ex1.rt.l> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="IrhDeMKUP4DT/M7F" Content-Disposition: inline In-Reply-To: <938f562e322849328d5a7782b2c1de97@ex1.rt.l> X-Cookie: I have many CHARTS and DIAGRAMS.. User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --IrhDeMKUP4DT/M7F Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Dec 25, 2019 at 01:45:43AM +0000, jeff_chang(=E5=BC=B5=E4=B8=96=E4= =BD=B3) wrote: > This is adau1997 driver on upstream branch > @ sound/soc/codecs/adau1997.c > // SPDX-License-Identifier: GPL-2.0-only > /* > * ADAU1977/ADAU1978/ADAU1979 driver This is the result of an automatic conversion which wasn't reviewed, it's not ideal. > It seems not whole comment use c++. Only first line at source file, Right? Please do it like this: // SPDX-License-Identifier: GPL-2.0-only // // ADAU1977/ADAU1978/ADAU1979 driver --IrhDeMKUP4DT/M7F Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl4DoDMACgkQJNaLcl1U h9Dp2Af/aU0nU+b2UxZTkVGZHR3/l8NBevpw5Tzd3SGjZgaPfnLnnupSxFRHbMJh AYQybA/K1pTWIJsLSNcPjn0x/YstXMil9in42PqCANDLY6qQxi1nHQpqWo26S2+O u6x9f+rSrJA5zzbjVcbxvBFaEjUtl/O7DTfvf6LNKZ2Nr6DtIlO4vyX8Q5RjhtG8 zvotyES221ovg8TpQ9uv140oUlNtxDyBzstcRQhNXK7gaKqTIHde082f7uqmTspi xdwhz8EVLpe2LDDYLO5lFH5TKDeektnfhFfelKj26AJ3aFj7Qfn7faKPSNJR3Udy kXcrZVVgsxfIAjdAGGxzwXGoqw7gLQ== =YJiP -----END PGP SIGNATURE----- --IrhDeMKUP4DT/M7F--