Received: by 2002:a25:8b91:0:0:0:0:0 with SMTP id j17csp8990025ybl; Wed, 25 Dec 2019 10:55:22 -0800 (PST) X-Google-Smtp-Source: APXvYqzVe87UYXWBgVdF0vbQAmHc/cZzAqR84oADJlf66mKTc2iNZUxpwE59ulBe/xqyeAFsgxhO X-Received: by 2002:a05:6830:1e46:: with SMTP id e6mr41114709otj.245.1577300122160; Wed, 25 Dec 2019 10:55:22 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1577300122; cv=none; d=google.com; s=arc-20160816; b=xpihrkiVsi8aGobWwXOsAyOHpK8DcJavvwxNVLvWTH8n/BmXd79TTz3AbABFrRwAlp OyODoxebjCFO16tDVs08dncFlqVL8uGCTWs739wi7tx2d7oGiNBJLibppznPO/jYnS3t ZO96a5mYZJsMyoFhHbDN+vLNTkpawYmuBfMjOKWGEzt9WkFjQFbxS6tEnWT/zLo65RdP kBz0UiBw/ZOHb4kDvPAT1fJIhhLPNtkxiMTEl2R5F3+Vu7vRUrB+FFMhGwY4xWKUafja TrUxGTB6T20OXUG/FDh5XFv5iK528v91G4Lu8q8Z6+UK9NFse2eIELdmEogS+Qd9Uglo G3Jg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=V5zqjNU8lWxhx4T8vgAchYsOb6MwZXLIgZ6zmI6PMTY=; b=EAYUcD+Rnepd3G77a4jqyha3MHiMcQFYXESk5LuIAqKzPupK9Sy1bL/Q5+K+QgKlqL QcMVxQ/XbV5G4Dz08So2qAiYwxg4uT5tTDRpkz/dXr70XZas6OaCu+dIlnhE2KochquS ZDK5HESngo3RglKo4ysBJXSfv9Sys3JQiV9oraUeStYEbbdsuNEUVZPUx4oXgD8lCn1/ Ey7u1baEBa5Ym3AoZLrDAwgPSSNu5uUCgd79xPU59SptZbzfiiZ0bt4nVtdIDhgh0a4F pDDphBvY3qThl0IQDEbfoTk/yAZRIumGplsQrQ+IFbakSB0X0YXbVU62W4DKMI5fDa4f WDwg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u21si13199480oiv.267.2019.12.25.10.55.05; Wed, 25 Dec 2019 10:55:22 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726704AbfLYSyW (ORCPT + 99 others); Wed, 25 Dec 2019 13:54:22 -0500 Received: from relay1-d.mail.gandi.net ([217.70.183.193]:43311 "EHLO relay1-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726397AbfLYSyW (ORCPT ); Wed, 25 Dec 2019 13:54:22 -0500 X-Originating-IP: 88.190.179.123 Received: from localhost (unknown [88.190.179.123]) (Authenticated sender: repk@triplefau.lt) by relay1-d.mail.gandi.net (Postfix) with ESMTPSA id CF474240003; Wed, 25 Dec 2019 18:54:17 +0000 (UTC) Date: Wed, 25 Dec 2019 20:02:20 +0100 From: Remi Pommarel To: Kishon Vijay Abraham I , Yue Wang , Lorenzo Pieralisi , Andrew Murray , Neil Armstrong , Kevin Hilman , Martin Blumenstingl Cc: Jerome Brunet , linux-amlogic@lists.infradead.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org Subject: Re: [PATCH v3 5/5] dt-bindings: Add AXG PCIE PHY bindings Message-ID: <20191225190220.GF7304@voidbox> References: <20191224173942.18160-1-repk@triplefau.lt> <20191224173942.18160-6-repk@triplefau.lt> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191224173942.18160-6-repk@triplefau.lt> User-Agent: Mutt/1.12.2 (2019-09-21) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 24, 2019 at 06:39:42PM +0100, Remi Pommarel wrote: > Add documentation for PCIE PHYs found in AXG SoCs. > > Signed-off-by: Remi Pommarel > --- > .../bindings/phy/amlogic,meson-axg-pcie.yaml | 51 +++++++++++++++++++ > 1 file changed, 51 insertions(+) > create mode 100644 Documentation/devicetree/bindings/phy/amlogic,meson-axg-pcie.yaml > > diff --git a/Documentation/devicetree/bindings/phy/amlogic,meson-axg-pcie.yaml b/Documentation/devicetree/bindings/phy/amlogic,meson-axg-pcie.yaml > new file mode 100644 > index 000000000000..c622a1b38ffc > --- /dev/null > +++ b/Documentation/devicetree/bindings/phy/amlogic,meson-axg-pcie.yaml > @@ -0,0 +1,51 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +# Copyright 2019 BayLibre, SAS > +%YAML 1.2 > +--- > +$id: "http://devicetree.org/schemas/phy/amlogic,meson-axg-pcie.yaml#" > +$schema: "http://devicetree.org/meta-schemas/core.yaml#" > + > +title: Amlogic AXG PCIE PHY > + > +maintainers: > + - Remi Pommarel > + > +properties: > + compatible: > + enum: > + - amlogic,axg-pcie-phy > + > + reg: > + maxItems: 1 > + > + aml,hhi-gpr: > + maxItems: 1 My bad, I didn't know about devicetree schemas and their verification, I will fix the missing $ref: '/schemas/types.yaml#/definitions/phandle' here, add a description and add the missing include for reset in the example below in v4 along with upcoming comments on the other patches. Sorry about that. > + > + resets: > + maxItems: 1 > + > + reset-names: > + items: > + - const: phy > + > + "#phy-cells": > + const: 0 > + > +required: > + - compatible > + - reg > + - aml,hhi-gpr > + - resets > + - reset-names > + - "#phy-cells" > + > +examples: > + - | > + pcie_phy: pcie-phy@ff644000 { > + compatible = "amlogic,axg-pcie-phy"; > + reg = <0x0 0xff644000 0x0 0x2000>; > + aml,hhi-gpr = <&sysctrl>; > + resets = <&reset RESET_PCIE_PHY>; > + reset-names = "phy"; > + #phy-cells = <0>; > + }; > -- > 2.24.0 >