Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <5744632b88b44369a68c0b0704bfb48e@huawei.com>
In-Reply-To: <5744632b88b44369a68c0b0704bfb48e@huawei.com>
From:   Wanpeng Li <kernellwp@gmail.com>
Date:   Thu, 26 Dec 2019 10:35:10 +0800
Message-ID: <CANRm+Cx0LUkJZc4Y-cNenKB=SURSMQKDNjp0EoRQo2QQJV7SzA@mail.gmail.com>
Subject: Re: [PATCH] KVM: nvmx: retry writing guest memory after page fault injected
To:     linmiaohe <linmiaohe@huawei.com>
Cc:     Liran Alon <liran.alon@oracle.com>,
        "pbonzini@redhat.com" <pbonzini@redhat.com>,
        "rkrcmar@redhat.com" <rkrcmar@redhat.com>,
        "sean.j.christopherson@intel.com" <sean.j.christopherson@intel.com>,
        "vkuznets@redhat.com" <vkuznets@redhat.com>,
        "wanpengli@tencent.com" <wanpengli@tencent.com>,
        "jmattson@google.com" <jmattson@google.com>,
        "joro@8bytes.org" <joro@8bytes.org>,
        "tglx@linutronix.de" <tglx@linutronix.de>,
        "mingo@redhat.com" <mingo@redhat.com>,
        "bp@alien8.de" <bp@alien8.de>, "hpa@zytor.com" <hpa@zytor.com>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "x86@kernel.org" <x86@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Thu, 26 Dec 2019 at 10:32, linmiaohe <linmiaohe@huawei.com> wrote:
>
> Hi,
>
> Liran Alon <liran.alon@oracle.com> wrote:
> >> On 25 Dec 2019, at 4:21, linmiaohe <linmiaohe@huawei.com> wrote:
> >>
> >> From: Miaohe Lin <linmiaohe@huawei.com>
> >>
> >> We should retry writing guest memory when
> >> kvm_write_guest_virt_system() failed and page fault is injected in handle_vmread().
> >>
> >> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
> >
> >Patch fix seems correct to me:
> >Reviewed-by: Liran Alon <liran.alon@oracle.com>
>
> Thanks for your review.
>
> >However, I suggest to rephrase commit title & message as follows:
> >
> >"""
> >KVM: nVMX: vmread should not set rflags to specify success in case of #PF
> >
> >In case writing to vmread destination operand result in a #PF, vmread should not call nested_vmx_succeed() to set rflags to specify success. Similar to as done in for VMPTRST (See handle_vmptrst()).
> >"""
>
> Thanks for your sueestion, I would rephrase commit title & message accordingly.
>
> >
> >In addition, it will be appreciated if you would also submit kvm-unit-test that verifies this condition.
>
> I'd like to submit kvm-unit-test that verifies this condition, but I am not familiar with the kvm-unit-test code yet and
> also not in my recent todo list. So such a patch may come late. It would be appreciated too if you could submit this
> kvm-unit-test patch. :)

Hmm, did you verify your own patch? Please give the testcase.