Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH v3 2/4] dt-bindings: regulator: add document bindings for
 mpq7920
To:     Maxime Ripard <mripard@kernel.org>
Cc:     lgirdwood@gmail.com, broonie@kernel.org, robh+dt@kernel.org,
        mark.rutland@arm.com, shawnguo@kernel.org, heiko@sntech.de,
        sam@ravnborg.org, icenowy@aosc.io,
        laurent.pinchart@ideasonboard.com, gregkh@linuxfoundation.org,
        Jonathan.Cameron@huawei.com, davem@davemloft.net,
        mchehab+samsung@kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20191222204507.32413-1-sravanhome@gmail.com>
 <20191222204507.32413-3-sravanhome@gmail.com>
 <20191223105028.amtzf62yjdpdsfrt@hendrix.home>
From:   saravanan sekar <sravanhome@gmail.com>
Message-ID: <ec7d8937-724e-946c-0569-da685223d21d@gmail.com>
Date:   Thu, 26 Dec 2019 23:23:36 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.2.2
MIME-Version: 1.0
In-Reply-To: <20191223105028.amtzf62yjdpdsfrt@hendrix.home>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 23/12/19 11:50 am, Maxime Ripard wrote:

> On Sun, Dec 22, 2019 at 09:45:05PM +0100, Saravanan Sekar wrote:
>> Add device tree binding information for mpq7920 regulator driver.
>> Example bindings for mpq7920 are added.
>>
>> Signed-off-by: Saravanan Sekar <sravanhome@gmail.com>
>> ---
>>   .../bindings/regulator/mpq7920.yaml           | 143 ++++++++++++++++++
>>   1 file changed, 143 insertions(+)
>>   create mode 100644 Documentation/devicetree/bindings/regulator/mpq7920.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/regulator/mpq7920.yaml b/Documentation/devicetree/bindings/regulator/mpq7920.yaml
>> new file mode 100644
>> index 000000000000..d173ba1fb28d
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/regulator/mpq7920.yaml
>> @@ -0,0 +1,143 @@
>> +# SPDX-License-Identifier: GPL-2.0
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/regulator/mpq7920.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Monolithic Power System MPQ7920 PMIC
>> +
>> +maintainers:
>> +  - Saravanan Sekar <sravanhome@gmail.com>
>> +
>> +properties:
>> +  $nodename:
>> +    pattern: "pmic@[0-9a-f]{1,2}"
>> +  compatible:
>> +    enum:
>> +      - mps,mpq7920
>> +
>> +  reg:
>> +    maxItems: 1
>> +
>> +  mps,time-slot:
>> +    description:
>> +      each regulator output shall be delayed during power on/off sequence which
>> +      based on configurable time slot value, must be one of following corresponding
>> +      value 0.5ms, 2ms, 8ms, 16ms
>> +    allOf:
>> +      - $ref: "/schemas/types.yaml#/definitions/uint8"
>> +      - enum: [ 0, 1, 2, 3 ]
>> +      - default: 0
>> +
>> +  mps,fixed-on-time:
>> +     description:
>> +       select power on sequence with fixed time output delay mentioned in
>> +       time-slot reg for all the regulators.
>> +     type: boolean
>> +
>> +  mps,fixed-off-time:
>> +     description:
>> +        select power off sequence with fixed time output delay mentioned in
>> +        time-slot reg for all the regulators.
>> +     type: boolean
> I'm not sure what this fixed-on-time and fixed-off-time property is

the time slot register holds the time interval of Vout when enable the
each regulator.
fixed-on-time property is to specify each regulator shares same time
interval mention in time slot register.
variable on-time defines the factor or multiples of value in time slot
register.


> supposed to be doing. Why not just get rid of the time slot property,
> and set the power on / power off time in fixed-on-time /
> fixed-off-time property?

1. if fixed-on-time is needed with default time slot register settings,
then time slot property is not needed
2. if variable time is needed with modified time slot, then both
variable time factor & time slot property is needed,
Hope above explanations answers the necessary of all the above property

>
>> +  mps,inc-off-time:
>> +     description: |
>> +        mutually exclusive to mps,fixed-off-time an array of 8, linearly increase
>> +        output delay during power off sequence based on factor of time slot/interval
>> +        for each regulator.
>> +     allOf:
>> +       - $ref: "/schemas/types.yaml#/definitions/uint8-array"
>> +       - minimum: 0
>> +       - maximum: 15
>> +       - default: [ 0, 6, 0, 6, 7, 7, 7, 9 ]
> You should check the size of the array too, but if it's a property of
> the regulators, why not have it in the regulators node?

the node regulators & sub-node of regulators are parsed (initdata) by
regulator framework during regulator registration,
so it would be redundant parsing all the node if mentioned under each
regulator node and this is optional. If you still not
convinced I will change.

>> +  mps,inc-on-time:
>> +     description: |
>> +        mutually exclusive to mps,fixed-on-time an array of 8, linearly increase
>> +        output delay during power on sequence based on factor of time slot/interval
>> +        for each regulator.
>> +     allOf:
>> +       - $ref: "/schemas/types.yaml#/definitions/uint8-array"
>> +       - minimum: 0
>> +       - maximum: 15
>> +       - default: [ 0, 6, 0, 6, 7, 7, 7, 9 ]
>> +
>> +  mps,switch-freq:
>> +     description: |
>> +        switching frequency must be one of following corresponding value
>> +        1.1MHz, 1.65MHz, 2.2MHz, 2.75MHz
>> +     allOf:
>> +       - $ref: "/schemas/types.yaml#/definitions/uint8"
>> +       - enum: [ 0, 1, 2, 3 ]
>> +       - default: 2
>> +
>> +  mps,buck-softstart:
>> +     description: |
>> +        An array of 4 contains soft start time of each buck, must be one of
>> +        following corresponding values 150us, 300us, 610us, 920us
>> +     allOf:
>> +       - $ref: "/schemas/types.yaml#/definitions/uint8-array"
>> +       - enum: [ 0, 1, 2, 3 ]
>> +       - default: [ 1, 1, 1, 1 ]
>> +
>> +  mps,buck-ovp:
>> +     description: |
>> +        An array of 4 contains over voltage protection of each buck, must be
>> +        one of above values
>> +     allOf:
>> +       - $ref: "/schemas/types.yaml#/definitions/uint8-array"
>> +       - enum: [ 0, 1 ]
>> +       - default: [ 1, 1, 1, 1 ]
>> +
>> +  mps,buck-phase-delay:
>> +     description: |
>> +        An array of 4 contains phase delay of each buck must be one of above values
>> +        corresponding to 0deg, 90deg, 180deg, 270deg
>> +     allOf:
>> +       - $ref: "/schemas/types.yaml#/definitions/uint8-array"
>> +       - enum: [ 0, 1, 2, 3 ]
>> +       - default: [ 0, 0, 1, 1 ]
>> +
>> +  regulators:
>> +    type: object
>> +    description:
>> +      list of regulators provided by this controller, must be named
>> +      after their hardware counterparts BUCK[1-4], one LDORTC, and LDO[2-5]
>> +      The valid names for regulators are
>> +      buck1, buck2, buck3, buck4, ldortc, ldo2, ldo3, ldo4, ldo5
> For the third times now, the names should be validated using
> propertyNames.

Not sure did I understand your question correctly.
all the node name under regulators node are parsed by regulator
framework & validated against
name in regulator descriptors.

>
> Maxime


Thanks,

Saravanan

On 23/12/19 11:50 am, Maxime Ripard wrote:
> On Sun, Dec 22, 2019 at 09:45:05PM +0100, Saravanan Sekar wrote:
>> Add device tree binding information for mpq7920 regulator driver.
>> Example bindings for mpq7920 are added.
>>
>> Signed-off-by: Saravanan Sekar <sravanhome@gmail.com>
>> ---
>>   .../bindings/regulator/mpq7920.yaml           | 143 ++++++++++++++++++
>>   1 file changed, 143 insertions(+)
>>   create mode 100644 Documentation/devicetree/bindings/regulator/mpq7920.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/regulator/mpq7920.yaml b/Documentation/devicetree/bindings/regulator/mpq7920.yaml
>> new file mode 100644
>> index 000000000000..d173ba1fb28d
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/regulator/mpq7920.yaml
>> @@ -0,0 +1,143 @@
>> +# SPDX-License-Identifier: GPL-2.0
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/regulator/mpq7920.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Monolithic Power System MPQ7920 PMIC
>> +
>> +maintainers:
>> +  - Saravanan Sekar <sravanhome@gmail.com>
>> +
>> +properties:
>> +  $nodename:
>> +    pattern: "pmic@[0-9a-f]{1,2}"
>> +  compatible:
>> +    enum:
>> +      - mps,mpq7920
>> +
>> +  reg:
>> +    maxItems: 1
>> +
>> +  mps,time-slot:
>> +    description:
>> +      each regulator output shall be delayed during power on/off sequence which
>> +      based on configurable time slot value, must be one of following corresponding
>> +      value 0.5ms, 2ms, 8ms, 16ms
>> +    allOf:
>> +      - $ref: "/schemas/types.yaml#/definitions/uint8"
>> +      - enum: [ 0, 1, 2, 3 ]
>> +      - default: 0
>> +
>> +  mps,fixed-on-time:
>> +     description:
>> +       select power on sequence with fixed time output delay mentioned in
>> +       time-slot reg for all the regulators.
>> +     type: boolean
>> +
>> +  mps,fixed-off-time:
>> +     description:
>> +        select power off sequence with fixed time output delay mentioned in
>> +        time-slot reg for all the regulators.
>> +     type: boolean
> I'm not sure what this fixed-on-time and fixed-off-time property is
> supposed to be doing. Why not just get rid of the time slot property,
> and set the power on / power off time in fixed-on-time /
> fixed-off-time property?
>
>> +  mps,inc-off-time:
>> +     description: |
>> +        mutually exclusive to mps,fixed-off-time an array of 8, linearly increase
>> +        output delay during power off sequence based on factor of time slot/interval
>> +        for each regulator.
>> +     allOf:
>> +       - $ref: "/schemas/types.yaml#/definitions/uint8-array"
>> +       - minimum: 0
>> +       - maximum: 15
>> +       - default: [ 0, 6, 0, 6, 7, 7, 7, 9 ]
> You should check the size of the array too, but if it's a property of
> the regulators, why not have it in the regulators node?
>
>> +  mps,inc-on-time:
>> +     description: |
>> +        mutually exclusive to mps,fixed-on-time an array of 8, linearly increase
>> +        output delay during power on sequence based on factor of time slot/interval
>> +        for each regulator.
>> +     allOf:
>> +       - $ref: "/schemas/types.yaml#/definitions/uint8-array"
>> +       - minimum: 0
>> +       - maximum: 15
>> +       - default: [ 0, 6, 0, 6, 7, 7, 7, 9 ]
>> +
>> +  mps,switch-freq:
>> +     description: |
>> +        switching frequency must be one of following corresponding value
>> +        1.1MHz, 1.65MHz, 2.2MHz, 2.75MHz
>> +     allOf:
>> +       - $ref: "/schemas/types.yaml#/definitions/uint8"
>> +       - enum: [ 0, 1, 2, 3 ]
>> +       - default: 2
>> +
>> +  mps,buck-softstart:
>> +     description: |
>> +        An array of 4 contains soft start time of each buck, must be one of
>> +        following corresponding values 150us, 300us, 610us, 920us
>> +     allOf:
>> +       - $ref: "/schemas/types.yaml#/definitions/uint8-array"
>> +       - enum: [ 0, 1, 2, 3 ]
>> +       - default: [ 1, 1, 1, 1 ]
>> +
>> +  mps,buck-ovp:
>> +     description: |
>> +        An array of 4 contains over voltage protection of each buck, must be
>> +        one of above values
>> +     allOf:
>> +       - $ref: "/schemas/types.yaml#/definitions/uint8-array"
>> +       - enum: [ 0, 1 ]
>> +       - default: [ 1, 1, 1, 1 ]
>> +
>> +  mps,buck-phase-delay:
>> +     description: |
>> +        An array of 4 contains phase delay of each buck must be one of above values
>> +        corresponding to 0deg, 90deg, 180deg, 270deg
>> +     allOf:
>> +       - $ref: "/schemas/types.yaml#/definitions/uint8-array"
>> +       - enum: [ 0, 1, 2, 3 ]
>> +       - default: [ 0, 0, 1, 1 ]
>> +
>> +  regulators:
>> +    type: object
>> +    description:
>> +      list of regulators provided by this controller, must be named
>> +      after their hardware counterparts BUCK[1-4], one LDORTC, and LDO[2-5]
>> +      The valid names for regulators are
>> +      buck1, buck2, buck3, buck4, ldortc, ldo2, ldo3, ldo4, ldo5
> For the third times now, the names should be validated using
> propertyNames.
>
> Maxime