Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Peter Chen <peter.chen@nxp.com>
To:     Alan Stern <stern@rowland.harvard.edu>
CC:     Guenter Roeck <linux@roeck-us.net>,
        Peter Chen <peter.chen@freescale.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Michael Grzeschik <m.grzeschik@pengutronix.de>,
        "stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: Re: [PATCH] usb: chipidea: host: Disable port power only if
 previously enabled
Thread-Topic: [PATCH] usb: chipidea: host: Disable port power only if
 previously enabled
Thread-Index: AQHVvAVIstmi2Z+Az0y8RyzR9GDiKqfM0jmAgABkPAA=
Date:   Fri, 27 Dec 2019 01:45:03 +0000
Message-ID: <20191227014459.GA5283@b29397-desktop>
References: <20191226155754.25451-1-linux@roeck-us.net>
 <Pine.LNX.4.44L0.1912261428310.6148-100000@netrider.rowland.org>
In-Reply-To: <Pine.LNX.4.44L0.1912261428310.6148-100000@netrider.rowland.org>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: nxp.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-ID: <31E716C9DA2B6A42927990659E931A94@eurprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 8167a86d-e6bb-4175-5d78-08d78a6e6471
X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Dec 2019 01:45:03.0592
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Zotjv6AD48N277r3QDGvVghcZWUO/dphOtPCFfiMRWVIgqy5+Mj4hgRdefufcDkxmffPPwOce31aNMAAmL3abQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4318
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 19-12-26 14:46:15, Alan Stern wrote:
> On Thu, 26 Dec 2019, Guenter Roeck wrote:
>=20
> > On shutdown, ehci_power_off() is called unconditionally to power off
> > each port, even if it was never called to power on the port.
> > For chipidea, this results in a call to ehci_ci_portpower() with a requ=
est
> > to power off ports even if the port was never powered on.
> > This results in the following warning from the regulator code.
>=20
> That's weird -- we should always power-on every port during hub=20
> initialization.
>=20
> It looks like there's a bug in hub.c:hub_activate(): The line under
> HUB_INIT which calls hub_power_on() should call
> usb_hub_set_port_power() instead.  In fact, the comment near the start
> of hub_power_on() is wrong.  It says "Enable power on each port", but
> in fact it only enables power for ports that had been powered-on
> previously (i.e., the port's bit in hub->power_bits was set). =20
> Apparently this got messed up in commit ad493e5e5805 ("usb: add usb
> port auto power off mechanism").
>=20
> Now, the chipidea driver may still need to be updated, because=20
> ehci_turn_off_all_ports() will still be called during shutdown and it=20
> will try to power-down all ports, even those which are already powered=20
> down (for example, because the port is suspended).
>=20

Hi Alan,

When the port is suspended, why it was turned off? If it was turned
off, how could respond wakeup event?

--=20

Thanks,
Peter Chen=